All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Behun <marek.behun@nic.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: dsa: mc88e6xxx: Fix 88E6141/6341 2500mbps SERDES speed
Date: Sun, 7 Oct 2018 00:00:54 +0200	[thread overview]
Message-ID: <20181007000054.659166fa@nic.cz> (raw)
In-Reply-To: <20181006183700.GO4730@lunn.ch>

Hi Andrew, I think that dividing this patch into three would be too
much. How about this commit message?

  net: dsa: mv88e6xxx: Fix 88E6141/6341 2500mbps SERDES speed

  This is a fix for the port_set_speed method for the Topaz family.
  Currently the same method is used as for the Peridot family, but
  this is wrong for the SERDES port.

  On Topaz, the SERDES port is port 5, not 9 and 10 as in Peridot.
  Moreover setting alt_bit on Topaz only makes sense for port 0 (for
  (differentiating 100mbps vs 200mbps). The SERDES port does not
  support more than 2500mbps, so alt_bit does not make any difference.

On Sat, 6 Oct 2018 20:37:00 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Sat, Oct 06, 2018 at 02:38:10AM +0200, Marek Behun wrote:
> > > Hi Marek
> > > 
> > > I'm confused.
> > > 
> > > The alt bit is used for configuring 2500. You say 2500 is only
> > > supported on port 5. But !port is only true for port 0?
> > > 
> > > 	  Andrew  
> > 
> > On Topaz alt_bit is used only for port 0 for differentiating 100
> > mbps vs 200 mbps. The choices for SpdValue are 0 for 10 mbps, 1 for
> > 100 mbps or 200 mbps (if alt_bit), 2 for 1000 mbps and 3 for 2500
> > mbps. 2500 is allowed only on port 5. alt_bit is not used on Topaz
> > for port 5 (serdes), therefore I used !port.  
> 
> Hi Marek
> 
> The commit message could be clearer. It might be going too far, but
> you could split this into three.
> 
> 1) Basic framework code, with works correctly for ports 1-4.
> 2) The special 200Mbps for port 0
> 3) The special 2500Mbps for port 5.
> 
> But i would also accept a clearer commit message.
> 
>     Thanks
>     Andrew

      reply	other threads:[~2018-10-07  5:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 14:42 [PATCH net-next] net: dsa: mc88e6xxx: Fix 88E6141/6341 2500mbps SERDES speed Marek Behún
2018-10-05 21:20 ` Andrew Lunn
2018-10-06  0:38   ` Marek Behun
2018-10-06 18:37     ` Andrew Lunn
2018-10-06 22:00       ` Marek Behun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181007000054.659166fa@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.