All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Graute <oliver.graute@gmail.com>
To: "Vokáč Michal" <Michal.Vokac@ysoft.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: Can't set MX6UL_PAD_LCD_DATA10 register with devicetree
Date: Tue, 9 Oct 2018 11:20:32 +0200	[thread overview]
Message-ID: <20181009092032.GB13624@graute-opti> (raw)
In-Reply-To: <e4e78033-7eb2-67b7-e7b9-daf54895bc9e@ysoft.com>

On 09/10/18, Vokáč Michal wrote:
> On 9.10.2018 08:28, Oliver Graute wrote:
> > On 08/10/18, Fabio Estevam wrote:
> >> Hi Oliver,
> >>
> >> On Fri, Oct 5, 2018 at 9:46 AM Oliver Graute <oliver.graute@gmail.com> wrote:
> >>>
> >>> Hello list,
> >>>
> >>> I try to set the following PAD in my imx6ul devicetree (derived from
> >>> imx6ul-14x14-evk.dts)
> >>>
> >>> MX6UL_PAD_LCD_DATA10__GPIO3_IO15 0x100b0
> >>
> >> I don't see anything wrong with the definition of
> >> MX6UL_PAD_LCD_DATA10__GPIO3 in imx6ul-pinfunc.h.
> >>
> >> Could you share your whole dts file?
> > 
> > see dts file below
> >>
> >> Are you sure you are not getting a pin conflict due to previous usage
> >> of MX6UL_PAD_LCD_DATA10?
> > 
> > I commented out the MX6UL_PAD_LCD_DATA10__LCDIF_DATA10 Pad in the lcdif section
> > is this sufficient?
> 
> As Fabio noted - you use the same pad in two pinctrl groups.
> One usage is in the pinctrl_hog3 group as a GPIO and second usage is in
> the pinctrl_lcdif_dat group as a LCD data signal. That is actually OK.
> 
> The problem is that neither of those two pinctrl groups is used by some
> device node and hence the configuration is not applied.

yes you are right!
> 
> If you want configure all the pins in the pinctrl_hog3 group you probably
> need to use it in the iomuxc node. See bellow.
> 
> > &iomuxc {
> > 	pinctrl-names = "default";
> 
> Add this line to configure all the pins in hog3 group when pinctrl is probed.
> 
> 	pinctrl-0 = <&pinctrl_hog3>;

this line indeed solved my problem, now the register value is fine.

many thanks for this hint.

Best regards,

Oliver

  reply	other threads:[~2018-10-09 16:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 12:45 Can't set MX6UL_PAD_LCD_DATA10 register with devicetree Oliver Graute
2018-10-08  6:21 ` Shawn Guo
2018-10-09  2:55   ` A.s. Dong
2018-10-09  3:27   ` A.s. Dong
2018-10-09  9:15     ` Oliver Graute
2018-10-08 20:22 ` Fabio Estevam
2018-10-09  6:28   ` Oliver Graute
2018-10-09  7:48     ` Vokáč Michal
2018-10-09  9:20       ` Oliver Graute [this message]
2018-10-09 11:00         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009092032.GB13624@graute-opti \
    --to=oliver.graute@gmail.com \
    --cc=Michal.Vokac@ysoft.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.