All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
	broonie@kernel.org, andriy.shevchenko@linux.intel.com
Subject: [PATCH 0/3] Intel SST fixes for Chromebooks/HDaudio platorms
Date: Fri, 16 Nov 2018 18:47:03 -0600	[thread overview]
Message-ID: <20181117004706.15911-1-pierre-louis.bossart@linux.intel.com> (raw)

While testing Mark's for-next branch on Chromebooks, 3 problems were
exposed

a. the search loop for ACPI IDs is broken on SKL/KBL which are the
most advanced users of quirks. This is embarrassing since it's been
broken for a very very long time and those platforms have been stuck
in time with 3.18 and 4.4 kernels.

b. the change I personally made to use a common interface for machine
driver didn't work either for all the Chromebooks using information on
dmic number. My bad.

c. the change to use the common interface also missed the fact that
the Skylake driver passed the information using drv_data instead of
platform_data as done by the Atom and SOF drivers. The third patch
aligns the Skylake driver with the two others. We should now have no
dependencies between machine and platform drivers, which will help
reuse the same code.

These patches were tested on HDaudio platforms (ApolloLake and Whisky
Lake) as well as Chell (SKL) and Soraka (KBL) Chromebooks - for the
latter case we are still investigating DSP IPC errors that are
unrelated to these changes


Keyon Jie (1):
  ASoC: acpi: fix: continue searching when machine is ignored

Pierre-Louis Bossart (2):
  ASoC: Intel: fix interface for Chromebook machine drivers
  ASoC: Intel: use platform_data for machine drivers

 include/sound/soc-acpi.h                          |  1 +
 sound/soc/intel/boards/kbl_rt5663_max98927.c      | 10 +++++-----
 .../soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 10 +++++-----
 sound/soc/intel/boards/skl_hda_dsp_generic.c      |  2 +-
 sound/soc/intel/boards/skl_nau88l25_max98357a.c   | 10 +++++-----
 sound/soc/intel/boards/skl_nau88l25_ssm4567.c     | 10 +++++-----
 sound/soc/intel/skylake/skl.c                     | 15 +++++++++++----
 sound/soc/intel/skylake/skl.h                     |  3 ---
 sound/soc/soc-acpi.c                              | 10 ++++++++--
 9 files changed, 41 insertions(+), 30 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-11-17  0:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-17  0:47 Pierre-Louis Bossart [this message]
2018-11-17  0:47 ` [PATCH 1/3] ASoC: acpi: fix: continue searching when machine is ignored Pierre-Louis Bossart
2018-11-20 17:01   ` Applied "ASoC: acpi: fix: continue searching when machine is ignored" to the asoc tree Mark Brown
2018-11-17  0:47 ` [PATCH 2/3] ASoC: Intel: fix interface for Chromebook machine drivers Pierre-Louis Bossart
2018-11-20 17:01   ` Applied "ASoC: Intel: fix interface for Chromebook machine drivers" to the asoc tree Mark Brown
2018-11-17  0:47 ` [PATCH 3/3] ASoC: Intel: use platform_data for machine drivers Pierre-Louis Bossart
2018-11-20 17:01   ` Applied "ASoC: Intel: use platform_data for machine drivers" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181117004706.15911-1-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.