From: Matthew Wilcox <willy@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
linux-mm@kvack.org
Subject: Re: [PATCH 04/10] mm/khugepaged: collapse_shmem() stop if punched or truncated
Date: Tue, 27 Nov 2018 05:26:50 -0800 [thread overview]
Message-ID: <20181127132650.GO3065@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.LSU.2.11.1811261522040.2275@eggly.anvils>
On Mon, Nov 26, 2018 at 03:23:37PM -0800, Hugh Dickins wrote:
> VM_BUG_ON(index != xas.xa_index);
> if (!page) {
> + /*
> + * Stop if extent has been truncated or hole-punched,
> + * and is now completely empty.
> + */
> + if (index == start) {
> + if (!xas_next_entry(&xas, end - 1)) {
> + result = SCAN_TRUNCATED;
> + break;
> + }
> + xas_set(&xas, index);
> + }
> if (!shmem_charge(mapping->host, 1)) {
Reviewed-by: Matthew Wilcox <willy@infradead.org>
I'd use xas_find() directly here; I don't think it warrants the inlined
version of xas_next_entry(). But I'm happy either way.
next prev parent reply other threads:[~2018-11-27 13:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 23:13 [PATCH 00/10] huge_memory,khugepaged tmpfs split/collapse fixes Hugh Dickins
2018-11-26 23:19 ` [PATCH 02/10] mm/huge_memory: splitting set mapping+index before unfreeze Hugh Dickins
2018-11-27 7:26 ` Kirill A. Shutemov
2018-11-26 23:21 ` [PATCH 03/10] mm/huge_memory: fix lockdep complaint on 32-bit i_size_read() Hugh Dickins
2018-11-27 7:27 ` Kirill A. Shutemov
2018-11-26 23:23 ` [PATCH 04/10] mm/khugepaged: collapse_shmem() stop if punched or truncated Hugh Dickins
2018-11-27 7:31 ` Kirill A. Shutemov
2018-11-27 13:26 ` Matthew Wilcox [this message]
2018-11-26 23:25 ` [PATCH 05/10] mm/khugepaged: fix crashes due to misaccounted holes Hugh Dickins
2018-11-27 7:35 ` Kirill A. Shutemov
2018-11-26 23:26 ` [PATCH 06/10] mm/khugepaged: collapse_shmem() remember to clear holes Hugh Dickins
2018-11-27 7:38 ` Kirill A. Shutemov
2018-11-26 23:27 ` [PATCH 07/10] mm/khugepaged: minor reorderings in collapse_shmem() Hugh Dickins
2018-11-27 7:59 ` Kirill A. Shutemov
2018-11-27 20:23 ` Hugh Dickins
2018-11-28 10:59 ` Kirill A. Shutemov
2018-11-28 19:40 ` Hugh Dickins
2018-11-26 23:29 ` [PATCH 08/10] mm/khugepaged: collapse_shmem() without freezing new_page Hugh Dickins
2018-11-27 8:01 ` Kirill A. Shutemov
2018-11-26 23:31 ` [PATCH 09/10] mm/khugepaged: collapse_shmem() do not crash on Compound Hugh Dickins
2018-11-26 23:33 ` [PATCH 10/10] mm/khugepaged: fix the xas_create_range() error path Hugh Dickins
2018-11-27 8:02 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127132650.GO3065@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.