All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: dri-devel@lists.freedesktop.org, David Airlie <airlied@redhat.com>
Cc: andr2000@gmail.com, open list <linux-kernel@vger.kernel.org>,
	"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU"
	<virtualization@lists.linux-foundation.org>,
	David Airlie <airlied@linux.ie>,
	noralf@tronnes.org
Subject: [PATCH v4 01/16] drm/bochs: encoder cleanup
Date: Fri, 11 Jan 2019 06:37:37 +0100	[thread overview]
Message-ID: <20190111053752.4004-2-kraxel__6309.44067747823$1547692789$gmane$org@redhat.com> (raw)
In-Reply-To: <20190111053752.4004-1-kraxel@redhat.com>

Most unused callbacks can be NULL pointers these days.
Drop a bunch of empty encoder callbacks.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/bochs/bochs_kms.c | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c
index f87c284dd9..c8ce54498d 100644
--- a/drivers/gpu/drm/bochs/bochs_kms.c
+++ b/drivers/gpu/drm/bochs/bochs_kms.c
@@ -170,31 +170,6 @@ static void bochs_crtc_init(struct drm_device *dev)
 	drm_crtc_helper_add(crtc, &bochs_helper_funcs);
 }
 
-static void bochs_encoder_mode_set(struct drm_encoder *encoder,
-				   struct drm_display_mode *mode,
-				   struct drm_display_mode *adjusted_mode)
-{
-}
-
-static void bochs_encoder_dpms(struct drm_encoder *encoder, int state)
-{
-}
-
-static void bochs_encoder_prepare(struct drm_encoder *encoder)
-{
-}
-
-static void bochs_encoder_commit(struct drm_encoder *encoder)
-{
-}
-
-static const struct drm_encoder_helper_funcs bochs_encoder_helper_funcs = {
-	.dpms = bochs_encoder_dpms,
-	.mode_set = bochs_encoder_mode_set,
-	.prepare = bochs_encoder_prepare,
-	.commit = bochs_encoder_commit,
-};
-
 static const struct drm_encoder_funcs bochs_encoder_encoder_funcs = {
 	.destroy = drm_encoder_cleanup,
 };
@@ -207,7 +182,6 @@ static void bochs_encoder_init(struct drm_device *dev)
 	encoder->possible_crtcs = 0x1;
 	drm_encoder_init(dev, encoder, &bochs_encoder_encoder_funcs,
 			 DRM_MODE_ENCODER_DAC, NULL);
-	drm_encoder_helper_add(encoder, &bochs_encoder_helper_funcs);
 }
 
 
-- 
2.9.3

  parent reply	other threads:[~2019-01-11  5:37 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11  5:37 [PATCH v4 00/16] drm/bochs: cleanups, atomic modesetting, generic fbdev Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 01/16] drm/bochs: encoder cleanup Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann [this message]
2019-01-11  5:37 ` [PATCH v4 02/16] drm/bochs: split bochs_hw_setmode Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 03/16] drm/bochs: atomic: add atomic_flush+atomic_enable callbacks Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 04/16] drm/bochs: atomic: add mode_set_nofb callback Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 05/16] drm/bochs: atomic: switch planes to atomic, wire up helpers Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 06/16] drm/bochs: atomic: use atomic set_config helper Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 07/16] drm/bochs: atomic: use atomic page_flip helper Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11 11:08   ` Oleksandr Andrushchenko
2019-01-11 11:08     ` Oleksandr Andrushchenko
2019-01-11  5:37 ` [PATCH v4 09/16] drm/bochs: atomic: set DRIVER_ATOMIC Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 10/16] drm/bochs: remove old bochs_crtc_* functions Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 11/16] drm/bochs: drop unused gpu_addr arg from bochs_bo_pin() Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 12/16] drm/bochs: move ttm_bo_(un)reserve calls into bochs_bo_{pin, unpin} Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 12/16] drm/bochs: move ttm_bo_(un)reserve calls into bochs_bo_{pin,unpin} Gerd Hoffmann
2019-01-11  5:37   ` [PATCH v4 12/16] drm/bochs: move ttm_bo_(un)reserve calls into bochs_bo_{pin, unpin} Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 13/16] drm/bochs: add basic prime support Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 14/16] drm/bochs: switch to generic drm fbdev emulation Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 15/16] drm/bochs: drop old fbdev emulation code Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann
2019-01-11  5:37 ` [PATCH v4 16/16] drm/bochs: move remaining fb bits to kms Gerd Hoffmann
2019-01-11  5:37 ` Gerd Hoffmann
2019-01-11  5:37   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20190111053752.4004-2-kraxel__6309.44067747823$1547692789$gmane$org@redhat.com' \
    --to=kraxel@redhat.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=andr2000@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.