On Mon, Jan 14, 2019 at 02:22:40PM +0100, Marek Szyprowski wrote: > This reverts commit 1874619a7df4b14b23b14877e705ae15325773e3. > > That patch broke IOMMU support for devices, which fails to probe for the > first time and use deferred probe approach. When non-NULL dma_ops is set > in arm_iommu_detach_device(), the given device later ignored by > arch_setup_dma_ops() and stays with non-IOMMU dma_ops. > > Reported-by: Tobias Jakobi > Fixes: 1874619a7df4 "ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device()" > Signed-off-by: Marek Szyprowski > --- > arch/arm/mm/dma-mapping.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Can you point out exactly what drivers break because of this change? We need to find a solution that works for everyone. Reverting is only marginally useful because somebody will just end up wanting to revert the revert because a different driver is now broken. Thierry