From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjjTT-0004Zo-QC for qemu-devel@nongnu.org; Wed, 16 Jan 2019 06:35:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjjTR-0003lf-2H for qemu-devel@nongnu.org; Wed, 16 Jan 2019 06:35:09 -0500 Date: Wed, 16 Jan 2019 12:34:55 +0100 From: Gerd Hoffmann Message-ID: <20190116113455.dyl6uctl4dpaqh6v@sirius.home.kraxel.org> References: <20190111140857.4211-1-philmd@redhat.com> <20190111140857.4211-4-philmd@redhat.com> <875zuqjea7.fsf@dusky.pond.sub.org> <403ad2e4-3282-051c-1ff5-8a3a23899293@redhat.com> <87sgxtatod.fsf@dusky.pond.sub.org> <4b24723e-5a27-f25f-76c1-f2f4e94757ba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b24723e-5a27-f25f-76c1-f2f4e94757ba@redhat.com> Subject: Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Peter Maydell , Peter Crosthwaite , Xiao Guangrong , qemu-block@nongnu.org, "Michael S. Tsirkin" , Alistair Francis , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Greg Kurz , qemu-arm@nongnu.org, Igor Mammedov , Laszlo Ersek , =?utf-8?Q?C=C3=A9dric?= Le Goater Hi, > typedefs.h is useful to avoid rebuilding the world too often if a type > is used many times as a pointer, but rarely as a struct and rarely has > functions called on its instances. Related: Can also be used to keep struct content private. struct QemuConsole for example is private to ui/console.c, but pointers to QemuConsole are passed around alot in ui/* and hw/display/* code. cheers, Gerd