From: David Miller <davem@davemloft.net>
To: atul.gupta@chelsio.com
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
netdev@vger.kernel.org, dt@chelsio.com
Subject: Re: [net-next 2/3] net/tls: free ctx in sock destruct
Date: Tue, 22 Jan 2019 11:37:45 -0800 (PST) [thread overview]
Message-ID: <20190122.113745.2272490918452641096.davem@davemloft.net> (raw)
In-Reply-To: <20190118045621.2822-1-atul.gupta@chelsio.com>
From: Atul Gupta <atul.gupta@chelsio.com>
Date: Thu, 17 Jan 2019 20:56:21 -0800
> free tls context in sock destruct. close may not be the last
> call to free sock but force releasing the ctx in close
> will result in GPF when ctx referred again in tcp_done
>
> [ 515.330477] general protection fault: 0000 [#1] SMP PTI
> [ 515.330539] CPU: 5 PID: 0 Comm: swapper/5 Not tainted 4.20.0-rc7+ #10
> [ 515.330657] Hardware name: Supermicro X8ST3/X8ST3, BIOS 2.0b
> 11/07/2013
> [ 515.330844] RIP: 0010:tls_hw_unhash+0xbf/0xd0
> [
> [ 515.332220] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 515.332340] CR2: 00007fab32c55000 CR3: 000000009261e000 CR4:
> 00000000000006e0
> [ 515.332519] Call Trace:
> [ 515.332632] <IRQ>
> [ 515.332793] tcp_set_state+0x5a/0x190
> [ 515.332907] ? tcp_update_metrics+0xe3/0x350
> [ 515.333023] tcp_done+0x31/0xd0
> [ 515.333130] tcp_rcv_state_process+0xc27/0x111a
> [ 515.333242] ? __lock_is_held+0x4f/0x90
> [ 515.333350] ? tcp_v4_do_rcv+0xaf/0x1e0
> [ 515.333456] tcp_v4_do_rcv+0xaf/0x1e0
>
> Signed-off-by: Atul Gupta <atul.gupta@chelsio.com>
Applied.
prev parent reply other threads:[~2019-01-22 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 4:56 [net-next 2/3] net/tls: free ctx in sock destruct Atul Gupta
2019-01-22 19:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122.113745.2272490918452641096.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atul.gupta@chelsio.com \
--cc=dt@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.