From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9962C282C0 for ; Fri, 25 Jan 2019 09:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A96BA218DE for ; Fri, 25 Jan 2019 09:28:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Zle5Zyhf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbfAYJ2k (ORCPT ); Fri, 25 Jan 2019 04:28:40 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55503 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbfAYJ2k (ORCPT ); Fri, 25 Jan 2019 04:28:40 -0500 Received: by mail-wm1-f66.google.com with SMTP id y139so5971674wmc.5 for ; Fri, 25 Jan 2019 01:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8e7A20ggoX/AjaaxKe1O9gvfqa97UfIOQ21vaXLf+A0=; b=Zle5Zyhf2hd+lM1oE3e0cA0HumEcWmuqbqQdvJoS9CiN5f+qXhEB8prpXqjwYwPLZL iFqS2bUge185sY7LyKMgWXId97DS3u0gUYIccDsGg9p9vRMmTFodBm3RBqeVoxa9dzxj kcQzmYdEm8Tm3P6HkaRNPJWp/a3dyY20Dnh300OCaPyAFpXclrpoCfHnO5npdquCHJeK nf1kOoDx/YfmO4LK7l6mrVQbALY3/xFLfJ3U75mRBW9cCJVxApG3a/1tuhJrEh/elMI8 eyBz7bOfUWUTY9OAQVdYZfjS7r1RZqJslSaHAHN/K4D8WsGKFG9Gh5JSzSQUVP8a9tNj jWHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8e7A20ggoX/AjaaxKe1O9gvfqa97UfIOQ21vaXLf+A0=; b=gLxR7zTwQek7jRgmevm6aihe0g5D72GYWqdTFdjRs7GUeet1/i0D7KS/hvVtd1RtpN KHdTCqbXYlu95i/Sie1uNeeiPWIonjVaBBmO/bPfRTQniuQgKxKM4DRxoxXSzEVE8L93 Pok6bTiaXilv3fpqNoeM4LhjQCmdtbkW3IOsaQRZAkBbTgaDkTkFFvhVib/DQ6reFLvZ gIKGDC8MoGigckpjcV2kU6mtxt5JEPIUt1Gxq7jg3rpTL9EjxQTp2fjUgSSttV52c4R9 7yYKaozLR4LfqoxNVpBDW3sLy5Kx6q+z5rqRnpSauqgkhJsbX2ITJDjcH2PCi59OGx5Q 6YIQ== X-Gm-Message-State: AJcUukeStxHyAZnksBIzycoAygG3xW95gkOTmxwFiVexEaY58nQXOM2y n/nmGMXRp4wygmoDEx7/KDLJ/A== X-Google-Smtp-Source: ALg8bN6VtZ+6ETTFRIx4nVRV5J7n8fHm/tuQBMdVFmQIsCtE2P5DCQQc9BpGjhT07JAtivpUg73xHg== X-Received: by 2002:a1c:5892:: with SMTP id m140mr6031965wmb.60.1548408518388; Fri, 25 Jan 2019 01:28:38 -0800 (PST) Received: from localhost (ip-213-220-235-33.net.upcbroadband.cz. [213.220.235.33]) by smtp.gmail.com with ESMTPSA id e16sm182390661wrn.72.2019.01.25.01.28.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Jan 2019 01:28:37 -0800 (PST) Date: Fri, 25 Jan 2019 10:19:46 +0100 From: Jiri Pirko To: Eran Ben Elisha Cc: David Miller , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed , Moshe Shemesh Subject: Re: [PATCH net-next 0/7] Devlink health updates Message-ID: <20190125091946.GA2148@nanopsycho> References: <1548172644-30862-1-git-send-email-eranbe@mellanox.com> <20190122165821.GC2121@nanopsycho> <20190124.220846.372838862694196119.davem@davemloft.net> <8ba329b5-f550-2c3e-08d7-1094fbe4e6fb@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ba329b5-f550-2c3e-08d7-1094fbe4e6fb@mellanox.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Jan 25, 2019 at 10:16:16AM CET, eranbe@mellanox.com wrote: > > >On 1/25/2019 8:08 AM, David Miller wrote: >> From: Jiri Pirko >> Date: Tue, 22 Jan 2019 17:58:21 +0100 >> >>> Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@mellanox.com wrote: >>>> This patchset fixes some comments that were received for the devlink >>>> health series, mostly around the devlink health buffers API. >>>> >>>> It offers a new devlink<->driver API for passing health dump and diagnose info. >>>> As part of this patchset, the new API is developed and integrated into the >>>> devlink health and mlx5e TX reporter. >>>> Also, added some helpers together with the new API, which reduce the code >>>> required by the driver to fill dump and diagnose significantly. >>>> >>>> Eventually, it also deletes the old API. >>>> >>>> In addition, it includes some small fixes in the devlink and mlx5e TX reporter. >>> >>> Okay, just leaving, going to review this tomorrow. I would much rather >>> review the patchset from the beginning, not this incremental patchset. >>> It changes a lot of things, deprecating api what was just introduced. >>> Review nightmare :/ >>> >>> Could we do revert, repost? For my health sakes :) >> >> Eran are you ok with the revert? > >Dave, thanks for your consideration. > >During the review of this fixes series with Jiri yesterday, we reached >to a conclusion that it would be cleaner to revert and re-post it again. >I thought I shall submit a revert patchset, but if just remove it, it >would be better, I guess. > >Jiri, >I will probably be able to provide a new version with fixed comments >from here soon next week. Good. Thanks! > >> >> I'll do it once I have Eran's confirmation. > >Note that you will also have to revert ARM compilation fix which was >accepted on top. >https://patchwork.ozlabs.org/patch/1029047/ > >Thanks.