Re: [PATCH 02/12] bnxt: Implement ndo_get_port_parent_id()

From: kbuild test robot <lkp@intel.com>
Cc: John Hurley <john.hurley@netronome.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	Andrew Lunn <andrew@lunn.ch>,
	"open list:NETRONOME ETHERNET DRIVERS"
	<oss-drivers@netronome.com>,
	Edwin Peer <edwin.peer@netronome.com>,
	Eric Dumazet <edumazet@google.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Ivan Vecera <ivecera@redhat.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Amritha Nambiar <amritha.nambiar@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	"open list:MELLANOX MLX5 core VPI driver"
	<linux-rdma@vger.kernel.org>,
	"moderated list:ETHERNET BRIDGE"
	<bridge@lists.linux-foundation.org>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Vivien Didelot <vivien.didelot@g>
Subject: Re: [PATCH 02/12] bnxt: Implement ndo_get_port_parent_id()
Date: Tue, 5 Feb 2019 17:48:37 +0800	[thread overview]
Message-ID: <201902051733.cuh7ycPD%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190204233633.20421-3-f.fainelli@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

Hi Florian,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on v5.0-rc4 next-20190205]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-Introduce-ndo_get_port_parent_id/20190205-163356
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=sparc64 

All error/warnings (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function 'bnxt_vf_rep_get_port_parent_id':
>> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:248:50: error: 'attr' undeclared (first use in this function); did you mean 'xattr'?
     return bnxt_get_port_parent_id(vf_rep->bp->dev, attr);
                                                     ^~~~
                                                     xattr
   drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:248:50: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:249:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +248 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c

   239	
   240	static int bnxt_vf_rep_get_port_parent_id(struct net_device *dev,
   241						  struct netdev_phys_item_id *ppid)
   242	{
   243		struct bnxt_vf_rep *vf_rep = netdev_priv(dev);
   244	
   245		/* as only PORT_PARENT_ID is supported currently use common code
   246		 * between PF and VF-rep for now.
   247		 */
 > 248		return bnxt_get_port_parent_id(vf_rep->bp->dev, attr);
 > 249	}
   250	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56303 bytes --]

[-- Attachment #3: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel