From: Dan Carpenter <dan.carpenter@oracle.com>
To: lkundrak@v3.sk
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] libertas_tf: don't defer firmware loading until start()
Date: Thu, 21 Feb 2019 21:29:02 +0300 [thread overview]
Message-ID: <20190221182900.GA26432@kadam> (raw)
Hello Lubomir Rintel,
This is a semi-automatic email about new static checker warnings.
The patch baa0280f08c7: "libertas_tf: don't defer firmware loading
until start()" from Feb 20, 2019, leads to the following Smatch
complaint:
drivers/net/wireless/marvell/libertas_tf/if_usb.c:256 if_usb_disconnect()
warn: variable dereferenced before check 'priv' (see line 254)
drivers/net/wireless/marvell/libertas_tf/if_usb.c
253
254 if_usb_reset_device(priv);
^^^^^
The patch introduces a new dereference (inside the function).
255
256 if (priv)
^^^^
Old code assumes "priv" could be NULL.
257 lbtf_remove_card(priv);
258
regards,
dan carpenter
reply other threads:[~2019-02-21 18:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221182900.GA26432@kadam \
--to=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.