From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CF2C43381 for ; Sun, 24 Feb 2019 04:48:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36084206B6 for ; Sun, 24 Feb 2019 04:48:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bsVULTQG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728002AbfBXEsU (ORCPT ); Sat, 23 Feb 2019 23:48:20 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33652 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727689AbfBXEsU (ORCPT ); Sat, 23 Feb 2019 23:48:20 -0500 Received: by mail-pf1-f196.google.com with SMTP id i19so2954720pfd.0 for ; Sat, 23 Feb 2019 20:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KSg1Gn6+uNnbP4dWsL+aZfr4odDkydK6+HrjqAJUweM=; b=bsVULTQGCc0h0ODH9Wwqvvx6FfcmCPUsmVVrRrRXr6RTvos5Pf0emLrSWJLimfKITR KqM1gLYOCuAKLVzvt3MWipXyWodT30ah7id0Tq4u1EPOHmz5g1C7CbT/TjginFqUoUJy VWbxcPf/XTjZInC5JiSTLlmb8ybyH95fjKQx8pCqqMc9cSKLNZiNYBmIbE7IZQQXNEyt 8wFztB2NArPku3MWsbmcujvXgNEu8x8JjNkU2tIMDoU/RK9aGTetSz84YcgIbw+7+ByE d9s7lKTTZ6cVcNirY3Pw5JDQnazmbJ7m7GU/gGvGsIFGXASAoqFTEOl6e4Lue3XdYhAT R3Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KSg1Gn6+uNnbP4dWsL+aZfr4odDkydK6+HrjqAJUweM=; b=BnmTdax4+LbqX2hz3fzrmtqda9ojp84XObvX7xbLCIImAg/dASuoYS9zfQ5Qr85tEw TF3wW3/AoY2BjGByCx24qE1598zwz7biYYCMnTNREzyc6C3xcauuCpztq1A+6Xt1+y3g 5Fs+9sNVIo4DCrhVa0gVcx3sQyVKcjcHvmw5tGruwSCfa+WsVPU/ngrjTIElCSmqJYjM USirN2zeCCHUDHZRjXX75IWVatDYZeGotJPVttd2YYf9rK5QzgMep/e4CTlsN9vCEl2x NrZbCBa2nDHwa3V60Abg6/JoNTy+mf+nRxH/fhqtFUGOY1mzkzLWVwaFR2nSvE23Du/P pQZw== X-Gm-Message-State: AHQUAub3jSx++ObpuZKzfC6DErvEALtvV0gfFY5P0b1EOCSyspWvAerY RdXJU5EXeOk0WLRvhCbr67I= X-Google-Smtp-Source: AHgI3IbbyxsgqsSfyg96TYYKOQpjWvxHL6P8z7A927Mh2W0TmZEnRGGIZEMKgp7PI7DUfukdQpBo5Q== X-Received: by 2002:a63:6a88:: with SMTP id f130mr11515892pgc.114.1550983699427; Sat, 23 Feb 2019 20:48:19 -0800 (PST) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::1:c4e4]) by smtp.gmail.com with ESMTPSA id i2sm10605857pgl.53.2019.02.23.20.48.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Feb 2019 20:48:18 -0800 (PST) Date: Sat, 23 Feb 2019 20:48:17 -0800 From: Alexei Starovoitov To: David Ahern Cc: Eric Dumazet , brakmo , netdev , Martin Lau , Alexei Starovoitov , Daniel Borkmann , Kernel Team Subject: Re: [PATCH v2 bpf-next 0/9] bpf: Network Resource Manager (NRM) Message-ID: <20190224044815.nqfr6szce7j7g3za@ast-mbp.dhcp.thefacebook.com> References: <20190223010703.678070-1-brakmo@fb.com> <184fd1a4-451e-2585-6aad-d9b0b10fd9aa@gmail.com> <2507e7b5-2ffa-e080-698a-18a7b0ee36ac@gmail.com> <20190223204046.zjvcxh7cgzshqllm@ast-mbp.dhcp.thefacebook.com> <49fbc4c9-6e8d-5115-0860-e418427a2ce5@gmail.com> <20190223232530.qjb5z66x6amoiis4@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 23, 2019 at 09:58:57PM -0500, David Ahern wrote: > On 2/23/19 6:25 PM, Alexei Starovoitov wrote: > >>> hmm. please see our NRM presentation at LPC. > > Reference? > > We also gave a talk about a resource manager in November 2017: > > https://netdevconf.org/2.2/papers/roulin-hardwareresourcesmgmt-talk.pdf > > in this case the context is hardware resources for networking which > aligns with devlink and switchdev. > > >>> It is a networking _resource_ management for cgroups. > >>> Bandwidth enforcement is a particular example. > >>> It's not a policer either. > >>> > >> > >> Well, this definitely looks a policer to me, sorry if we disagree, this is fine. > > > > this particular example certainly does look like it. we both agree. > > It's overall direction of this work that is aiming to do > > network resource management. For example bpf prog may choose > > to react on SLA violations in one cgroup by throttling flows > > in the other cgroup. Aggregated per-cgroup bandwidth doesn't > > need to cross a threshold for bpf prog to take action. > > It could do 'work conserving' 'policer'. > > I think this set of patches represent a revolutionary approach and existing > > networking nomenclature doesn't have precise words to describe it :) > > 'NRM' describes our goals the best. > > Are you doing something beyond bandwidth usage? e.g., are you limiting > neighbor entries, fdb entries or FIB entries by cgroup? what about > router interfaces or vlans? I cannot imagine why or how you would manage > that but my point is the meaning of 'network resources'. 'network resources' also include back bone and TOR capacity and this mechanism is going to help address that as well.