From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBEC3C43381 for ; Tue, 5 Mar 2019 00:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8877020675 for ; Tue, 5 Mar 2019 00:52:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="RG5j3/jy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbfCEAwI (ORCPT ); Mon, 4 Mar 2019 19:52:08 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:34275 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfCEAwI (ORCPT ); Mon, 4 Mar 2019 19:52:08 -0500 Received: by mail-qt1-f196.google.com with SMTP id w4so7299261qtc.1 for ; Mon, 04 Mar 2019 16:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=zw4oaITtmDCSGE+cKqqTxq5ah1gP3r6yJy2zzSvOBoo=; b=RG5j3/jyU4VK5bf2AjyYTf4VgyurcAW1yeQYVzr7PxWgtFxjr4UGikgcBq1HZVQxP7 gxvlbkH2I6cEiNRgoNq3zIoQ28ZltF98ECwQwvucfZmY6o20lBEoNmR21G16MByGh35f Tz4ZBlkZ/hXQdBhYCw2Z4fx8ZdtxUPx/iIGhSRkHYbLrtg1e42rStkbPkusGIcP2xRLR jnnXKlnoaB9zVYaQ65IJckHCaDe7pADzDi/vTsE2guajjJU/8YdrRDFwzzw64hMxYKsj bYCvtNY1rk6X+vwM6QDC9KghvncYmQbgvdjBA/VPQaUQxzh40S2PNcX8CBVk4nKB7mTy V3jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=zw4oaITtmDCSGE+cKqqTxq5ah1gP3r6yJy2zzSvOBoo=; b=cHI4g+In+wMryTLOw/ir288OG/ADBYVSuvFiHUp0vK90Zzby5JeJ9U+ZSxP+RXA7MB taupr1gCYtdfZzCPy+cefAFozbRjeGDEeV+pm5d5rPG75FhvAoaGYijtsnNpYgj2wFgs KTBWjkow6TQnMBREzeBXYHXQgKbsmBONIbLAiCgZM0WICuAcBAC1JIcctscC/6derB8g OikotlGQTC82cdgoDvtXSy2U5ecu1aTwDfGsRDpY60tYWB4DLDXQRtm5Ra2j5/42M4Mc V8wBmklG574xwzGXiDmGQmDKCAMHx2qCvPKFPtpbZxFSl44wWhhnuiZzwz0tvVVWVKdG eifw== X-Gm-Message-State: APjAAAW8BnQCge8FYtSuxsRUf5v9nzNEVN1bAtZt1UDRSJ6nyGo0efCV Uy+Hoyq/m4ajcdLS7kLQB/bYUA== X-Google-Smtp-Source: APXvYqxK8C17tFGUV1VtsOwTFudl+ggsNRKDCilK+aUv2pUQejYrQxKbhUdeRGXTbfXTjONUtcq9GA== X-Received: by 2002:ac8:4748:: with SMTP id k8mr1284808qtp.262.1551747126415; Mon, 04 Mar 2019 16:52:06 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id h58sm5181906qtb.89.2019.03.04.16.52.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 16:52:06 -0800 (PST) Date: Mon, 4 Mar 2019 16:51:59 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190304165159.6a6501a2@cakuba.netronome.com> In-Reply-To: <20190304110857.GW2314@nanopsycho> References: <20190301180453.17778-1-jakub.kicinski@netronome.com> <20190301180453.17778-5-jakub.kicinski@netronome.com> <20190304110857.GW2314@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 4 Mar 2019 12:08:57 +0100, Jiri Pirko wrote: > Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicinski@netronome.com wrote: > >PCI endpoint corresponds to a PCI device, but such device > >can have one more more logical device ports associated with it. > >We need a way to distinguish those. Add a PCI subport in the > >dumps and print the info in phys_port_name appropriately. > > > >This is not equivalent to port splitting, there is no split > >group. It's just a way of representing multiple netdevs on > >a single PCI function. > > > >Note that the quality of being multiport pertains only to > >the PCI function itself. A PF having multiple netdevs does > >not mean that its VFs will also have multiple, or that VFs > >are associated with any particular port of a multiport VF. > > > >Example (bus 05 device has subports, bus 82 has only one port per > >function): > > How do you plan to added/remove these subports? I can't say I got that figured out fully, but I was wondering if we can have some form of: $ devlink partition pci/0000:82:00.0 new pci/0000:82:00.0/1001002 Which would create appropriate sub-port and port (-repr-) netdev. Plus optionally the ability to work with something like the already existing mdev infrastructure for passing to a VM. But I haven't even looked at that, yet.