From: Adrian Bunk <bunk@stusta.de>
To: Sean Nyekjaer <sean@geanix.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] asio: add PACKAGECONFIG boost
Date: Thu, 7 Mar 2019 10:53:38 +0200 [thread overview]
Message-ID: <20190307085338.GA28605@localhost> (raw)
In-Reply-To: <20190307082917.18118-1-sean@geanix.com>
On Thu, Mar 07, 2019 at 09:29:17AM +0100, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> meta-oe/recipes-support/asio/asio_1.12.2.bb | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/meta-oe/recipes-support/asio/asio_1.12.2.bb b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> index ee548fd3a..ec705c275 100644
> --- a/meta-oe/recipes-support/asio/asio_1.12.2.bb
> +++ b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> @@ -20,3 +20,7 @@ SRC_URI[md5sum] = "312e53385e2daad10f08d57f91ad3431"
> SRC_URI[sha256sum] = "4e27dcb37456ba707570334b91f4798721111ed67b69915685eac141895779aa"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/asio/${BP}.tar.bz2"
> +
> +PACKAGECONFIG ??= "boost"
> +
> +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
Adding an RDEPENDS in the PACKAGECONFIG looks wrong.
boost should also be removed from the DEPENDS above when it is disabled.
This would be on top of your patch:
-DEPENDS = "boost openssl"
+DEPENDS = "openssl"
-PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
+PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost"
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-03-07 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 8:29 [meta-oe][PATCH] asio: add PACKAGECONFIG boost Sean Nyekjaer
2019-03-07 8:53 ` Adrian Bunk [this message]
2019-03-07 9:03 ` Sean Nyekjaer
2019-03-07 10:00 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307085338.GA28605@localhost \
--to=bunk@stusta.de \
--cc=openembedded-devel@lists.openembedded.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.