From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B53BC43381 for ; Tue, 12 Mar 2019 13:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3291C214AE for ; Tue, 12 Mar 2019 13:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbfCLNNd convert rfc822-to-8bit (ORCPT ); Tue, 12 Mar 2019 09:13:33 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43343 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfCLNNc (ORCPT ); Tue, 12 Mar 2019 09:13:32 -0400 X-Originating-IP: 90.88.22.102 Received: from xps13 (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A803160014; Tue, 12 Mar 2019 13:13:28 +0000 (UTC) Date: Tue, 12 Mar 2019 14:13:27 +0100 From: Miquel Raynal To: Masahiro Yamada Cc: Boris Brezillon , Richard Weinberger , Linux Kernel Mailing List , Marek Vasut , linux-mtd , Brian Norris , David Woodhouse Subject: Re: [PATCH v3 2/9] mtd: rawnand: denali: refactor syndrome layout handling for raw access Message-ID: <20190312141327.31c6af3f@xps13> In-Reply-To: References: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> <1552380290-19951-3-git-send-email-yamada.masahiro@socionext.com> <20190312112811.1af0bb00@xps13> <20190312115425.612bcdf2@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, Masahiro Yamada wrote on Tue, 12 Mar 2019 20:07:27 +0900: > Hi Miquel, > > > On Tue, Mar 12, 2019 at 7:54 PM Miquel Raynal wrote: > > > > Hi Masahiro, > > > > Masahiro Yamada wrote on Tue, 12 Mar > > 2019 19:51:21 +0900: > > > > > On Tue, Mar 12, 2019 at 7:28 PM Miquel Raynal wrote: > > > > > > > > Hi Masahiro, > > > > > > > > Masahiro Yamada wrote on Tue, 12 Mar > > > > 2019 17:44:43 +0900: > > > > > > > > > The Denali IP adopts the syndrome page layout (payload and ECC are > > > > > interleaved). The *_page_raw() and *_oob() callbacks are complicated > > > > > because they must hide the underlying layout used by the hardware, > > > > > and always return contiguous in-band and out-of-band data. > > > > > > > > > > Currently, similar code is duplicated to reorganize the data layout. > > > > > For example, denali_read_page_raw() and denali_write_page_raw() look > > > > > almost the same. > > > > > > > > > > The idea for refactoring is to split the code into two parts: > > > > > [1] conversion of page layout > > > > > [2] what to do at every ECC chunk boundary > > > > > > > > > > For [1], I wrote denali_raw_payload_op() and denali_raw_oob_op(). > > > > > They manipulate data for the Denali controller's specific page layout > > > > > of in-band, out-of-band, respectively. > > > > > > > > > > The difference between write and read is just the operation at > > > > > ECC chunk boundaries. For example, denali_read_oob() calls > > > > > nand_change_read_column_op(), whereas denali_write_oob() calls > > > > > nand_change_write_column_op(). So, I implemented [2] as a callback > > > > > passed into [1]. > > > > > > > > > > Signed-off-by: Masahiro Yamada > > > > > --- > > > > > > > > > > > > > [...] > > > > > > > > > static int denali_read_page_raw(struct nand_chip *chip, uint8_t *buf, > > > > > int oob_required, int page) > > > > > { > > > > > + struct denali_nand_info *denali = to_denali(chip); > > > > > struct mtd_info *mtd = nand_to_mtd(chip); > > > > > - struct denali_nand_info *denali = mtd_to_denali(mtd); > > > > > - int writesize = mtd->writesize; > > > > > - int oobsize = mtd->oobsize; > > > > > - int ecc_steps = chip->ecc.steps; > > > > > - int ecc_size = chip->ecc.size; > > > > > - int ecc_bytes = chip->ecc.bytes; > > > > > void *tmp_buf = denali->buf; > > > > > - int oob_skip = denali->oob_skip_bytes; > > > > > - size_t size = writesize + oobsize; > > > > > - int ret, i, pos, len; > > > > > + size_t size = mtd->writesize + mtd->oobsize; > > > > > + int ret; > > > > > + > > > > > + if (!buf) > > > > > + return -EINVAL; > > > > > > > > > > ret = denali_data_xfer(chip, tmp_buf, size, page, 1, 0); > > > > > if (ret) > > > > > return ret; > > > > > > > > > > - /* Arrange the buffer for syndrome payload/ecc layout */ > > > > > - if (buf) { > > > > > - for (i = 0; i < ecc_steps; i++) { > > > > > - pos = i * (ecc_size + ecc_bytes); > > > > > - len = ecc_size; > > > > > - > > > > > - if (pos >= writesize) > > > > > - pos += oob_skip; > > > > > - else if (pos + len > writesize) > > > > > - len = writesize - pos; > > > > > - > > > > > - memcpy(buf, tmp_buf + pos, len); > > > > > - buf += len; > > > > > - if (len < ecc_size) { > > > > > - len = ecc_size - len; > > > > > - memcpy(buf, tmp_buf + writesize + oob_skip, > > > > > - len); > > > > > - buf += len; > > > > > - } > > > > > - } > > > > > - } > > > > > + ret = denali_raw_payload_op(chip, buf, denali_memcpy_in, tmp_buf); > > > > > > > > Honestly, I still don't like passing denali_memcpy_in/out as parameter. > > > > > > > > Besides that, once you'll have added helpers to avoid abusing the > > > > ternary operator in 4/9, the rest looks fine by me. > > > > > > > > > > > > > Do you have any suggestion? > > > > Maybe register these two helpers at probe as controller specific hooks, > > then just pass an in/out boolean to the function? > > > > Sorry, I do not understand. > > Are you suggesting to do like follows in probe ? > > denali->change_column_read_raw = denali_memcpy_in; > denali->change_column_write_raw = denali_memcpy_out; > denali->change_column_read_oob = denali_change_read_column_op; > denali->change_column_write_oob = denali_change_write_column_op; > > > All the 4 hooks are always needed > regardless of any probed features. > > > The result is just textual replacement > denali_* with denali->*. > > What's the point of copying fixed function addresses > to denali structure? > > What I don't like is the function pointer as a function parameter. You can use the functions defined statically if you prefer as long as the parameter is just a boolean for instance? Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E58C43381 for ; Tue, 12 Mar 2019 13:13:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01F75214D8 for ; Tue, 12 Mar 2019 13:13:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dN03bOdz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01F75214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kzGbXAO5WBROec9u3DWNW1Zm2dPCvwngBdi7WKB1+78=; b=dN03bOdz8g+IeD yrIE2cCAY1gX2YrmzcBCqk3OX7BG5qxgbEySw656xajoLIpW/zbLBkYzqyZBVtPHygK4elJLv/RTb D0xy0IVMBZR0MMUMSagwN04L5SzCoODjRKhHbk5Ln6idoVoPovZXx49cN2Tn3xeN3mrdIKVrAaOpd l62TLFCJASk9e/+RBV6aNuCvhgHvFWqRNO7xq97oDw5+4OmRub/I4UrqZa7KIbrzZh9yO8fd6jHR4 U9tct/r2GzitjRXLV5OxhRn4I8Crejh6JPFaSp4MsZBLQ8AlhvPv9TaBeDHdIM+O9o5jdpP/T5qQq PBz0/AXve+SNXQW3RPig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3hDz-0004xb-Vp; Tue, 12 Mar 2019 13:13:43 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3hDv-0004wn-GF for linux-mtd@lists.infradead.org; Tue, 12 Mar 2019 13:13:41 +0000 X-Originating-IP: 90.88.22.102 Received: from xps13 (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A803160014; Tue, 12 Mar 2019 13:13:28 +0000 (UTC) Date: Tue, 12 Mar 2019 14:13:27 +0100 From: Miquel Raynal To: Masahiro Yamada Subject: Re: [PATCH v3 2/9] mtd: rawnand: denali: refactor syndrome layout handling for raw access Message-ID: <20190312141327.31c6af3f@xps13> In-Reply-To: References: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> <1552380290-19951-3-git-send-email-yamada.masahiro@socionext.com> <20190312112811.1af0bb00@xps13> <20190312115425.612bcdf2@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_061339_845566_B5AFF193 X-CRM114-Status: GOOD ( 28.70 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , Linux Kernel Mailing List , Marek Vasut , linux-mtd , Brian Norris , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFzYWhpcm8sCgpNYXNhaGlybyBZYW1hZGEgPHlhbWFkYS5tYXNhaGlyb0Bzb2Npb25leHQu Y29tPiB3cm90ZSBvbiBUdWUsIDEyIE1hcgoyMDE5IDIwOjA3OjI3ICswOTAwOgoKPiBIaSBNaXF1 ZWwsCj4gCj4gCj4gT24gVHVlLCBNYXIgMTIsIDIwMTkgYXQgNzo1NCBQTSBNaXF1ZWwgUmF5bmFs IDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZToKPiA+Cj4gPiBIaSBNYXNhaGlybywK PiA+Cj4gPiBNYXNhaGlybyBZYW1hZGEgPHlhbWFkYS5tYXNhaGlyb0Bzb2Npb25leHQuY29tPiB3 cm90ZSBvbiBUdWUsIDEyIE1hcgo+ID4gMjAxOSAxOTo1MToyMSArMDkwMDoKPiA+ICAKPiA+ID4g T24gVHVlLCBNYXIgMTIsIDIwMTkgYXQgNzoyOCBQTSBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5 bmFsQGJvb3RsaW4uY29tPiB3cm90ZTogIAo+ID4gPiA+Cj4gPiA+ID4gSGkgTWFzYWhpcm8sCj4g PiA+ID4KPiA+ID4gPiBNYXNhaGlybyBZYW1hZGEgPHlhbWFkYS5tYXNhaGlyb0Bzb2Npb25leHQu Y29tPiB3cm90ZSBvbiBUdWUsIDEyIE1hcgo+ID4gPiA+IDIwMTkgMTc6NDQ6NDMgKzA5MDA6Cj4g PiA+ID4gIAo+ID4gPiA+ID4gVGhlIERlbmFsaSBJUCBhZG9wdHMgdGhlIHN5bmRyb21lIHBhZ2Ug bGF5b3V0IChwYXlsb2FkIGFuZCBFQ0MgYXJlCj4gPiA+ID4gPiBpbnRlcmxlYXZlZCkuIFRoZSAq X3BhZ2VfcmF3KCkgYW5kICpfb29iKCkgY2FsbGJhY2tzIGFyZSBjb21wbGljYXRlZAo+ID4gPiA+ ID4gYmVjYXVzZSB0aGV5IG11c3QgaGlkZSB0aGUgdW5kZXJseWluZyBsYXlvdXQgdXNlZCBieSB0 aGUgaGFyZHdhcmUsCj4gPiA+ID4gPiBhbmQgYWx3YXlzIHJldHVybiBjb250aWd1b3VzIGluLWJh bmQgYW5kIG91dC1vZi1iYW5kIGRhdGEuCj4gPiA+ID4gPgo+ID4gPiA+ID4gQ3VycmVudGx5LCBz aW1pbGFyIGNvZGUgaXMgZHVwbGljYXRlZCB0byByZW9yZ2FuaXplIHRoZSBkYXRhIGxheW91dC4K PiA+ID4gPiA+IEZvciBleGFtcGxlLCBkZW5hbGlfcmVhZF9wYWdlX3JhdygpIGFuZCBkZW5hbGlf d3JpdGVfcGFnZV9yYXcoKSBsb29rCj4gPiA+ID4gPiBhbG1vc3QgdGhlIHNhbWUuCj4gPiA+ID4g Pgo+ID4gPiA+ID4gVGhlIGlkZWEgZm9yIHJlZmFjdG9yaW5nIGlzIHRvIHNwbGl0IHRoZSBjb2Rl IGludG8gdHdvIHBhcnRzOgo+ID4gPiA+ID4gICBbMV0gY29udmVyc2lvbiBvZiBwYWdlIGxheW91 dAo+ID4gPiA+ID4gICBbMl0gd2hhdCB0byBkbyBhdCBldmVyeSBFQ0MgY2h1bmsgYm91bmRhcnkK PiA+ID4gPiA+Cj4gPiA+ID4gPiBGb3IgWzFdLCBJIHdyb3RlIGRlbmFsaV9yYXdfcGF5bG9hZF9v cCgpIGFuZCBkZW5hbGlfcmF3X29vYl9vcCgpLgo+ID4gPiA+ID4gVGhleSBtYW5pcHVsYXRlIGRh dGEgZm9yIHRoZSBEZW5hbGkgY29udHJvbGxlcidzIHNwZWNpZmljIHBhZ2UgbGF5b3V0Cj4gPiA+ ID4gPiBvZiBpbi1iYW5kLCBvdXQtb2YtYmFuZCwgcmVzcGVjdGl2ZWx5Lgo+ID4gPiA+ID4KPiA+ ID4gPiA+IFRoZSBkaWZmZXJlbmNlIGJldHdlZW4gd3JpdGUgYW5kIHJlYWQgaXMganVzdCB0aGUg b3BlcmF0aW9uIGF0Cj4gPiA+ID4gPiBFQ0MgY2h1bmsgYm91bmRhcmllcy4gRm9yIGV4YW1wbGUs IGRlbmFsaV9yZWFkX29vYigpIGNhbGxzCj4gPiA+ID4gPiBuYW5kX2NoYW5nZV9yZWFkX2NvbHVt bl9vcCgpLCB3aGVyZWFzIGRlbmFsaV93cml0ZV9vb2IoKSBjYWxscwo+ID4gPiA+ID4gbmFuZF9j aGFuZ2Vfd3JpdGVfY29sdW1uX29wKCkuIFNvLCBJIGltcGxlbWVudGVkIFsyXSBhcyBhIGNhbGxi YWNrCj4gPiA+ID4gPiBwYXNzZWQgaW50byBbMV0uCj4gPiA+ID4gPgo+ID4gPiA+ID4gU2lnbmVk LW9mZi1ieTogTWFzYWhpcm8gWWFtYWRhIDx5YW1hZGEubWFzYWhpcm9Ac29jaW9uZXh0LmNvbT4K PiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIAo+ID4gPiA+Cj4gPiA+ID4gWy4uLl0KPiA+ID4gPiAg Cj4gPiA+ID4gPiAgc3RhdGljIGludCBkZW5hbGlfcmVhZF9wYWdlX3JhdyhzdHJ1Y3QgbmFuZF9j aGlwICpjaGlwLCB1aW50OF90ICpidWYsCj4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpbnQgb29iX3JlcXVpcmVkLCBpbnQgcGFnZSkKPiA+ID4gPiA+ICB7Cj4gPiA+ID4g PiArICAgICBzdHJ1Y3QgZGVuYWxpX25hbmRfaW5mbyAqZGVuYWxpID0gdG9fZGVuYWxpKGNoaXAp Owo+ID4gPiA+ID4gICAgICAgc3RydWN0IG10ZF9pbmZvICptdGQgPSBuYW5kX3RvX210ZChjaGlw KTsKPiA+ID4gPiA+IC0gICAgIHN0cnVjdCBkZW5hbGlfbmFuZF9pbmZvICpkZW5hbGkgPSBtdGRf dG9fZGVuYWxpKG10ZCk7Cj4gPiA+ID4gPiAtICAgICBpbnQgd3JpdGVzaXplID0gbXRkLT53cml0 ZXNpemU7Cj4gPiA+ID4gPiAtICAgICBpbnQgb29ic2l6ZSA9IG10ZC0+b29ic2l6ZTsKPiA+ID4g PiA+IC0gICAgIGludCBlY2Nfc3RlcHMgPSBjaGlwLT5lY2Muc3RlcHM7Cj4gPiA+ID4gPiAtICAg ICBpbnQgZWNjX3NpemUgPSBjaGlwLT5lY2Muc2l6ZTsKPiA+ID4gPiA+IC0gICAgIGludCBlY2Nf Ynl0ZXMgPSBjaGlwLT5lY2MuYnl0ZXM7Cj4gPiA+ID4gPiAgICAgICB2b2lkICp0bXBfYnVmID0g ZGVuYWxpLT5idWY7Cj4gPiA+ID4gPiAtICAgICBpbnQgb29iX3NraXAgPSBkZW5hbGktPm9vYl9z a2lwX2J5dGVzOwo+ID4gPiA+ID4gLSAgICAgc2l6ZV90IHNpemUgPSB3cml0ZXNpemUgKyBvb2Jz aXplOwo+ID4gPiA+ID4gLSAgICAgaW50IHJldCwgaSwgcG9zLCBsZW47Cj4gPiA+ID4gPiArICAg ICBzaXplX3Qgc2l6ZSA9IG10ZC0+d3JpdGVzaXplICsgbXRkLT5vb2JzaXplOwo+ID4gPiA+ID4g KyAgICAgaW50IHJldDsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsgICAgIGlmICghYnVmKQo+ID4g PiA+ID4gKyAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ID4gPiA+Cj4gPiA+ID4gPiAg ICAgICByZXQgPSBkZW5hbGlfZGF0YV94ZmVyKGNoaXAsIHRtcF9idWYsIHNpemUsIHBhZ2UsIDEs IDApOwo+ID4gPiA+ID4gICAgICAgaWYgKHJldCkKPiA+ID4gPiA+ICAgICAgICAgICAgICAgcmV0 dXJuIHJldDsKPiA+ID4gPiA+Cj4gPiA+ID4gPiAtICAgICAvKiBBcnJhbmdlIHRoZSBidWZmZXIg Zm9yIHN5bmRyb21lIHBheWxvYWQvZWNjIGxheW91dCAqLwo+ID4gPiA+ID4gLSAgICAgaWYgKGJ1 Zikgewo+ID4gPiA+ID4gLSAgICAgICAgICAgICBmb3IgKGkgPSAwOyBpIDwgZWNjX3N0ZXBzOyBp KyspIHsKPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICBwb3MgPSBpICogKGVjY19zaXpl ICsgZWNjX2J5dGVzKTsKPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICBsZW4gPSBlY2Nf c2l6ZTsKPiA+ID4gPiA+IC0KPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICBpZiAocG9z ID49IHdyaXRlc2l6ZSkKPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBv cyArPSBvb2Jfc2tpcDsKPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICBlbHNlIGlmIChw b3MgKyBsZW4gPiB3cml0ZXNpemUpCj4gPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBsZW4gPSB3cml0ZXNpemUgLSBwb3M7Cj4gPiA+ID4gPiAtCj4gPiA+ID4gPiAtICAgICAg ICAgICAgICAgICAgICAgbWVtY3B5KGJ1ZiwgdG1wX2J1ZiArIHBvcywgbGVuKTsKPiA+ID4gPiA+ IC0gICAgICAgICAgICAgICAgICAgICBidWYgKz0gbGVuOwo+ID4gPiA+ID4gLSAgICAgICAgICAg ICAgICAgICAgIGlmIChsZW4gPCBlY2Nfc2l6ZSkgewo+ID4gPiA+ID4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbGVuID0gZWNjX3NpemUgLSBsZW47Cj4gPiA+ID4gPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBtZW1jcHkoYnVmLCB0bXBfYnVmICsgd3JpdGVzaXplICsgb29i X3NraXAsCj4gPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGVu KTsKPiA+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1ZiArPSBsZW47Cj4g PiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgfQo+ID4gPiA+ID4gLSAgICAgICAgICAgICB9 Cj4gPiA+ID4gPiAtICAgICB9Cj4gPiA+ID4gPiArICAgICByZXQgPSBkZW5hbGlfcmF3X3BheWxv YWRfb3AoY2hpcCwgYnVmLCBkZW5hbGlfbWVtY3B5X2luLCB0bXBfYnVmKTsgIAo+ID4gPiA+Cj4g PiA+ID4gSG9uZXN0bHksIEkgc3RpbGwgZG9uJ3QgbGlrZSBwYXNzaW5nIGRlbmFsaV9tZW1jcHlf aW4vb3V0IGFzIHBhcmFtZXRlci4KPiA+ID4gPgo+ID4gPiA+IEJlc2lkZXMgdGhhdCwgb25jZSB5 b3UnbGwgaGF2ZSBhZGRlZCBoZWxwZXJzIHRvIGF2b2lkIGFidXNpbmcgdGhlCj4gPiA+ID4gdGVy bmFyeSBvcGVyYXRvciBpbiA0LzksIHRoZSByZXN0IGxvb2tzIGZpbmUgYnkgbWUuCj4gPiA+ID4g IAo+ID4gPgo+ID4gPgo+ID4gPiBEbyB5b3UgaGF2ZSBhbnkgc3VnZ2VzdGlvbj8gIAo+ID4KPiA+ IE1heWJlIHJlZ2lzdGVyIHRoZXNlIHR3byBoZWxwZXJzIGF0IHByb2JlIGFzIGNvbnRyb2xsZXIg c3BlY2lmaWMgaG9va3MsCj4gPiB0aGVuIGp1c3QgcGFzcyBhbiBpbi9vdXQgYm9vbGVhbiB0byB0 aGUgZnVuY3Rpb24/Cj4gPiAgCj4gCj4gU29ycnksIEkgZG8gbm90IHVuZGVyc3RhbmQuCj4gCj4g QXJlIHlvdSBzdWdnZXN0aW5nIHRvIGRvIGxpa2UgZm9sbG93cyBpbiBwcm9iZSA/Cj4gCj4gZGVu YWxpLT5jaGFuZ2VfY29sdW1uX3JlYWRfcmF3ID0gZGVuYWxpX21lbWNweV9pbjsKPiBkZW5hbGkt PmNoYW5nZV9jb2x1bW5fd3JpdGVfcmF3ID0gZGVuYWxpX21lbWNweV9vdXQ7Cj4gZGVuYWxpLT5j aGFuZ2VfY29sdW1uX3JlYWRfb29iID0gZGVuYWxpX2NoYW5nZV9yZWFkX2NvbHVtbl9vcDsKPiBk ZW5hbGktPmNoYW5nZV9jb2x1bW5fd3JpdGVfb29iID0gZGVuYWxpX2NoYW5nZV93cml0ZV9jb2x1 bW5fb3A7Cj4gCj4gCj4gQWxsIHRoZSA0IGhvb2tzIGFyZSBhbHdheXMgbmVlZGVkCj4gcmVnYXJk bGVzcyBvZiBhbnkgcHJvYmVkIGZlYXR1cmVzLgo+IAo+IAo+IFRoZSByZXN1bHQgaXMganVzdCB0 ZXh0dWFsIHJlcGxhY2VtZW50Cj4gZGVuYWxpXyogd2l0aCBkZW5hbGktPiouCj4gCj4gV2hhdCdz IHRoZSBwb2ludCBvZiBjb3B5aW5nIGZpeGVkIGZ1bmN0aW9uIGFkZHJlc3Nlcwo+IHRvIGRlbmFs aSBzdHJ1Y3R1cmU/Cj4gCj4gCgpXaGF0IEkgZG9uJ3QgbGlrZSBpcyB0aGUgZnVuY3Rpb24gcG9p bnRlciBhcyBhIGZ1bmN0aW9uIHBhcmFtZXRlci4gWW91CmNhbiB1c2UgdGhlIGZ1bmN0aW9ucyBk ZWZpbmVkIHN0YXRpY2FsbHkgaWYgeW91IHByZWZlciBhcyBsb25nIGFzIHRoZQpwYXJhbWV0ZXIg aXMganVzdCBhIGJvb2xlYW4gZm9yIGluc3RhbmNlPwoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVRE IGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtbXRkLwo=