From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4D4C43381 for ; Fri, 15 Mar 2019 18:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CFB4218D0 for ; Fri, 15 Mar 2019 18:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbfCOSCd (ORCPT ); Fri, 15 Mar 2019 14:02:33 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59860 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727002AbfCOSCc (ORCPT ); Fri, 15 Mar 2019 14:02:32 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D1456148DD3C2; Fri, 15 Mar 2019 11:02:31 -0700 (PDT) Date: Fri, 15 Mar 2019 11:02:29 -0700 (PDT) Message-Id: <20190315.110229.1479393342133382636.davem@davemloft.net> To: sbrivio@redhat.com Cc: liuzhiqiang26@huawei.com, petrm@mellanox.com, idosch@mellanox.com, sd@queasysnail.net, mousuanming@huawei.com, netdev@vger.kernel.org, mingfangsen@huawei.com, zhoukang7@huawei.com, wangxiaogang3@huawei.com, eric.dumazet@gmail.com Subject: Re: [PATCH v2] vxlan: remove the redundant gro_cells_destroy() calling. From: David Miller In-Reply-To: <20190315162824.732b18ac@elisabeth> References: <2276c137-d5c0-bdbe-f5c7-5985ffc497ce@huawei.com> <20190315162824.732b18ac@elisabeth> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Mar 2019 11:02:32 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stefano Brivio Date: Fri, 15 Mar 2019 16:28:24 +0100 > On Fri, 15 Mar 2019 23:18:52 +0800 > Zhiqiang Liu wrote: > >> In vxlan_destroy_tunnels func, unregister_netdevice_queue is called after >> gro_cells_destroy func. However, in unregister_netdevice_queue func, the >> gro_cells_destroy func will also call the gro_cells_destroy func as the >> following routine: >> unregister_netdevice_many() -> rollback_registered_many() >> -> ndo_uninit() -> gro_cells_destroy() >> >> Signed-off-by: Suanming.Mou >> Reviewed-by: Zhiqiang Liu >> Reviewed-by: Stefano Brivio > > NACK, please read my and Eric's comments to v1 -- giving me more than 23 > minutes to answer would have been a nice touch as well :) Also the net-next tree is CLOSED.