From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=pZ4W=RV=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DC73AC43381
	for <netdev@archiver.kernel.org>; Mon, 18 Mar 2019 23:54:04 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B2B752173C
	for <netdev@archiver.kernel.org>; Mon, 18 Mar 2019 23:54:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726936AbfCRXyD (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 18 Mar 2019 19:54:03 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:40576 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726487AbfCRXyD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 18 Mar 2019 19:54:03 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 8DD991411CCFE;
        Mon, 18 Mar 2019 16:54:02 -0700 (PDT)
Date:   Mon, 18 Mar 2019 16:53:59 -0700 (PDT)
Message-Id: <20190318.165359.1331225821043608638.davem@davemloft.net>
To:     edumazet@google.com
Cc:     netdev@vger.kernel.org, eric.dumazet@gmail.com,
        syzkaller@googlegroups.com
Subject: Re: [PATCH net] net: rose: fix a possible stack overflow
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190315174114.194944-1-edumazet@google.com>
References: <20190315174114.194944-1-edumazet@google.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Mar 2019 16:54:02 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Eric Dumazet <edumazet@google.com>
Date: Fri, 15 Mar 2019 10:41:14 -0700

> rose_write_internal() uses a temp buffer of 100 bytes, but a manual
> inspection showed that given arbitrary input, rose_create_facilities()
> can fill up to 110 bytes.
> 
> Lets use a tailroom of 256 bytes for peace of mind, and remove
> the bounce buffer : we can simply allocate a big enough skb
> and adjust its length as needed.
> 
> syzbot report :
 ...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>

Applied, thanks Eric.