From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49727C43381 for ; Mon, 18 Mar 2019 21:29:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F27D220872 for ; Mon, 18 Mar 2019 21:29:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="YdNfRZ7u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbfCRV34 (ORCPT ); Mon, 18 Mar 2019 17:29:56 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:34192 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726832AbfCRV34 (ORCPT ); Mon, 18 Mar 2019 17:29:56 -0400 Received: by mail-qk1-f196.google.com with SMTP id n6so10596036qkf.1 for ; Mon, 18 Mar 2019 14:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=Gro5IpMpbjKVcq35MWkHnkgs3lxS7/zvH/k/mozYuLY=; b=YdNfRZ7uBvP+wZWPk7iNXXgjII5bQJ8sU8qHrdhWxNhweUwtGUMISXKQ3Xztd3aGr/ 438RFRW6tmpd16e8LTGBf8N+lZ2BxgrpqQ2fWxGcaZiIaOJ/FaJlnYvUs3oE+Liixt1H gMFYTW6LZffDPU9xGCdP4CD8/d5QurbqXJaZenCEYYzDZAn7J5OIjBz+J50pwTCC4l3m CswDGkCWy2xXW1PJpwNOPL+/+SnoUpbJ5JbKTG1+xOabAvnsq4xMb/sqExr4Tb9ezart ptY7+IJUg+0j9/nwT2tsNhUUy3E38ORGNfNc+vlnutK5qAHMXc0IYChc/51iOp4G0uBK weEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=Gro5IpMpbjKVcq35MWkHnkgs3lxS7/zvH/k/mozYuLY=; b=OhU14pwUPTXfemXpjQDR5YzL5+0mKgmzsxrFhP7wML824D7hA0cMZFNZtrxd7QWib/ ZejMlSdr43vVoeAfWwO7SsLIezGHzsVA7hmB7cnYNb/tinS91BFn1NWq8vGYpBMhEnpP 9Q7dcjau/Ixbc7qA5HZun3mGP1Wc2emGY5m31hdgQUnrGbEzeGaSTd2uBL5b0NItUj/B nonTGTKNIrO/2nBL1fhIxkt6wO/7pyNduqzUWRgGQFMHugbXcQncq/HlesQzcHAdpbja Fo3oU0ZmkvmHrl0sK9Mtuj28j8u5cqP6XR6QTmZfGD+hWapNtZDqbFinmupPDliCrq6w wM9g== X-Gm-Message-State: APjAAAWJe4jWxXxYrvDDV9jiRXrx4cUkUTiNsz2i4WSbvI0kJQG9T3Xk upuRRSfI99QvrEN8E7CQA9TE8A== X-Google-Smtp-Source: APXvYqyjn0yELMLXShPZNLmFwBOWSARDG3Y3VygWfxDWRKux/EjI6/LJkAk1Uh9AphAsT1IAkNWY6Q== X-Received: by 2002:a37:69c6:: with SMTP id e189mr14385962qkc.186.1552944594771; Mon, 18 Mar 2019 14:29:54 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id p189sm6262573qkf.20.2019.03.18.14.29.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 14:29:54 -0700 (PDT) Date: Mon, 18 Mar 2019 14:29:49 -0700 From: Jakub Kicinski To: Parav Pandit Cc: Jiri Pirko , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190318142949.36f18af4@cakuba.netronome.com> In-Reply-To: References: <20190314150945.031d1b08@cakuba.netronome.com> <4436da3d-4b99-f792-8e77-695d5958794d@intel.com> <20190315200814.GD2305@nanopsycho> <20190318122105.GH2270@nanopsycho> <20190318123634.6e90c043@cakuba.netronome.com> <20190318125935.580c8fbe@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 18 Mar 2019 20:35:02 +0000, Parav Pandit wrote: > > > > > physical and pf has some overlapping definitions. > > > > > > > > What "overlapping definitions" do physical and PF have? > > > PF has physically user facing port. > > > > PF doesn't "have a user facing port" in switchdev mode. > > Physical port described in include/uapi/linux/devlink.h as > DEVLINK_PORT_FLAVOUR_PHYSICAL is not related to switchdev or legacy > mode. I said "PF doesn't ...", you're now talking about physical? > As the comment block describe it is 'any kind of port physical > facing user'. Are you saying PCI function is physical? Just because PF stands for Physical Function? Physical port in devlink means a port in the front panel where networking cable goes. > Current mlx5 driver doesn't expose ports as physical regardless of > switchdev/legacy mode. Today mlx5 doesn't expose devlink ports at all. > > It's a limitation of Mellanox HW that you have some strong > > association there. > Not sure why you keep saying that. Any code reference that I should > look at? Or maybe you can explain what is that limitation, because I > am not aware of any. NIC designs originating from traditional NICs were build as pipelines from PCI to wire or from wire to PCI. Reportedly it makes it hard to completely divorce the PCI PF from the wire port (physical port). Which is why you may think that "PF has physically user facing port". > > > And physical port in include/uapi/linux/devlink.h also describe > > > that. > > > > By "that" you must mean that the physical is a user facing port. > > Can you please describe the difference between 'PF port' and > 'physical port of include/uapi/linux/devlink.h'? I must have missed > this crisp definition in discussion between you and Jiri. I am in > meantime checking the thread. Perhaps start with the cover letter which includes an ASCII drawing? Using Mellanox nomenclature - PF port is a "representor" for the PF which may be on another Host (SmartNIC or multihost). It's pretty much the same thing as a VF port/"representor". Physical port is the hole on the panel of the adapter where cable goes.