All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/2] staging: pi433: fix line over 80 characters
Date: Thu, 21 Mar 2019 08:21:28 +0100	[thread overview]
Message-ID: <20190321072128.GF28171@kroah.com> (raw)
In-Reply-To: <20190320230048.6340-2-jbi.octave@gmail.com>

On Wed, Mar 20, 2019 at 11:00:48PM +0000, Jules Irenge wrote:
>  Fix coding style issues which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

You sent 2 patches that did different things, yet had the same subject
line :(

Please look at how other patch series are named and resend.

> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index f537722395c6..10245719b5cb 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -45,10 +45,10 @@
>  #include "pi433_if.h"
>  #include "rf69.h"
>  
> -#define N_PI433_MINORS			BIT(MINORBITS) /*32*/	/* ... up to 256 */
> -#define MAX_MSG_SIZE			900	/* min: FIFO_SIZE! */
> -#define MSG_FIFO_SIZE			65536   /* 65536 = 2^16  */
> -#define NUM_DIO				2
> +#define N_PI433_MINORS		BIT(MINORBITS) /*32*/	/* ... up to 256 */
> +#define MAX_MSG_SIZE		900	/* min: FIFO_SIZE! */
> +#define MSG_FIFO_SIZE		65536   /* 65536 = 2^16  */
> +#define NUM_DIO			2
>  
>  static dev_t pi433_dev;
>  static DEFINE_IDR(pi433_idr);
> @@ -672,7 +672,8 @@ pi433_tx_thread(void *data)
>  		if (retval < 0)
>  			return retval;
>  		if (tx_cfg.enable_length_byte == OPTION_ON) {
> -			retval = rf69_set_payload_length(spi, size * tx_cfg.repetitions);
> +			retval = rf69_set_payload_length(spi, size *
> +							 tx_cfg.repetitions);

This should be broken at the , which makes it easier to understand.

thanks,

greg k-h


      reply	other threads:[~2019-03-21  7:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 23:00 [PATCH 1/2] staging: pi433: fix line over 80 characters Jules Irenge
2019-03-20 23:00 ` [PATCH 2/2] " Jules Irenge
2019-03-21  7:21   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321072128.GF28171@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.