From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10C04C43381 for ; Fri, 22 Mar 2019 16:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6A4021900 for ; Fri, 22 Mar 2019 16:38:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="frhmzlOk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbfCVQiT (ORCPT ); Fri, 22 Mar 2019 12:38:19 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37770 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbfCVQiT (ORCPT ); Fri, 22 Mar 2019 12:38:19 -0400 Received: by mail-wr1-f68.google.com with SMTP id w10so3076187wrm.4 for ; Fri, 22 Mar 2019 09:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ouK6LcyDihFki4bTFw9VWpV7Vo35GgzyZQmd0WcP4C0=; b=frhmzlOkuQyXs1qS1JwCHltfWhusrvmPOeDgZVNN64Lxh86Th9gyqJ/Ng71/KfU7Xx YoEZQyO/ncA1GPRSnAMnWOkZa0Zseo2hVpep0UVL58aSIMBO+/gE0FPkCcjXTrPdqQsO n15YbTDFjBl7FU6l4N0oL4Jfe32CoRTLXiQXJ/uxLAsxy394YUplM6vtcBfvis+lmBLS JLZadfZuW3eNSkf5fyM6kbdDOXzZXmROiHkKQJFwVIQrw54+eNbI+hB4BSDJZIJagGHN jVvaBlGHKOnFO7jkwjO3dUBWlEE0Zq8FV2P4cdu2amSvtBH4K4PhClnxIFrV4Ff1ZiwB cntQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ouK6LcyDihFki4bTFw9VWpV7Vo35GgzyZQmd0WcP4C0=; b=UH/JmDqfocCVByH1h7otoL/eOhkS3NWUMbbRtvMXJcmTPYtzPdWxiY64IKeD65Q0fN VCQwa/arHGmVrkbXVSC0+5iDECBWMu4K1Tjj3EgshhBRf/3HCdETLpgw6dqANYjvxfbN rKbKK5LRvszfe8GF1t0NkPg1syZAct+xxVh2ooea7wHe0m3JRyvBGf+J2Q0t48ywyW/n 11EahXKdCzcbAh8YDg3S/8wg/C35BzrK22hr9t7CbkTG6VmOa/zIy9JiOSSCsfYXqEfO FYHWJyN4bwf3uQwQJWO/ehAZwtHAWUMm2O8/gX5M7cxDhBHl08pVO8kKLLNZ1u4K6ZoL NAtA== X-Gm-Message-State: APjAAAXIIDfdTlb4TS91gKG/BVqQYE4tjCXzNISp+5rllC5G99LiXe8V y9GX4Z0QPd8PytYnE/pof1Vj+A== X-Google-Smtp-Source: APXvYqxRohphlwr4OFJHlRQLEJrQnxofUZ3vtxMhjwlbIWDZXQJoc3VsvpuR/6sfW+dGpbbujZeHrA== X-Received: by 2002:adf:f488:: with SMTP id l8mr6977826wro.213.1553272697088; Fri, 22 Mar 2019 09:38:17 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id v14sm11618609wrr.20.2019.03.22.09.38.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 09:38:16 -0700 (PDT) Date: Fri, 22 Mar 2019 17:27:36 +0100 From: Jiri Pirko To: Parav Pandit Cc: Jakub Kicinski , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190322162736.GE2211@nanopsycho> References: <20190315200814.GD2305@nanopsycho> <20190315134454.581f47ca@cakuba.netronome.com> <20190318121154.GG2270@nanopsycho> <20190318121642.74a56b7e@cakuba.netronome.com> <20190321084526.GA2087@nanopsycho> <20190321161421.GR2087@nanopsycho> <20190321172034.GW2087@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 21, 2019 at 06:34:22PM CET, parav@mellanox.com wrote: > > >> -----Original Message----- >> From: Jiri Pirko >> Sent: Thursday, March 21, 2019 12:21 PM >> To: Parav Pandit >> Cc: Jakub Kicinski ; Samudrala, Sridhar >> ; davem@davemloft.net; >> netdev@vger.kernel.org; oss-drivers@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Thu, Mar 21, 2019 at 05:52:09PM CET, parav@mellanox.com wrote: >> > >> > >> >> -----Original Message----- >> >> From: Jiri Pirko >> >> Sent: Thursday, March 21, 2019 11:14 AM >> >> To: Parav Pandit >> >> Cc: Jakub Kicinski ; Samudrala, Sridhar >> >> ; davem@davemloft.net; >> >> netdev@vger.kernel.org; oss-drivers@netronome.com >> >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on >> >> devlink PCI ports >> >> >> >> Thu, Mar 21, 2019 at 04:14:53PM CET, parav@mellanox.com wrote: >> >> > >> >> > >> >> >> -----Original Message----- >> >> >> From: Jiri Pirko >> >> >> Sent: Thursday, March 21, 2019 3:45 AM >> >> >> To: Jakub Kicinski >> >> >> Cc: Parav Pandit ; Samudrala, Sridhar >> >> >> ; davem@davemloft.net; >> >> >> netdev@vger.kernel.org; oss-drivers@netronome.com >> >> >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on >> >> >> devlink PCI ports >> >> >> >> >> >> Mon, Mar 18, 2019 at 08:16:42PM CET, jakub.kicinski@netronome.com >> >> >> wrote: >> >> >> >On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote: >> >> >> >> >> >2. flavour should not be vf/pf, flavour should be hostport, >> >> switchport. >> >> >> >> >> >Because switch is flat and agnostic of pf/vf/mdev. >> >> >> >> >> >> >> >> >> >> Not sure. It's good to have this kind of visibility. >> >> >> >> > >> >> >> >> >Yes, this subthread honestly makes me go from 60% sure to 95% >> >> >> >> >sure we shouldn't do the dual object thing :( Seems like >> >> >> >> >Parav is already confused by it and suggests host port can >> >> >> >> >exist without switch port :( >> >> >> >> >> >> >> >> Although I understand your hesitation, the host ports are also >> >> >> >> associated with the asic and should be under the devlink instance. >> >> >> >> It is just a matter of proper documentation and clear code to >> >> >> >> avoid confusions. >> >> >> > >> >> >> >They are certainly a part and belong to the ASIC, the question in >> >> >> >my mind is more along the lines of do we want "one pipe/one port" >> >> >> >or is it okay to have multiple software objects of the same kind >> >> >> >for those objects. >> >> >> > >> >> >> >To put it differently - do want a port object for each port of >> >> >> >the ASIC or do we want a port object for each netdev.. >> >> >> >> >> >> Perhaps "port" name of the object is misleading. From the >> >> >> beginning, I ment to have it for both switch ports and host ports. >> >> >> I admit that "host port" is a bit misleading, as it is not really >> >> >> a port of eswitch, but the counter part. But if we introduce >> >> >> another object for that purpose in devlink (like "partititon"), it >> >> >> would be a lot of duplication >> >> I think. >> >> >> >> >> >> Question is, do we need the "host port"? Can't we just put a >> >> >> relation to host netdev in the eswitch port. >> >> >> >> >> >Can you please explain how does it work for rdma for non sriov use >> case? >> >> >Do we have to create a fake eswitch object? >> >> >> >> Could you please provide details on "rdma for non sriov use case"? >> >> >> >There are multiple mdevs on PFs that happen to have link layer as IB and >> those devlink instances have port that deserved to be configured same way >> as that of Eth. >> >> Could you please describe it a bit more. There is still an eswitch through >> which the traffic is going, isn't it? >Yes, there is an eswitch but it doesn't have switch side of vports. Why? They should have. >It is equivalent to legacy mode. >I hope you are not thinking to create fake eswitch vports. :-)