All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vatsala Narang <vatsalanarang@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: rtl8723bs: include: Fix identation issue
Date: Fri, 29 Mar 2019 17:13:46 +0100	[thread overview]
Message-ID: <20190329161346.GB540@kroah.com> (raw)
In-Reply-To: <20190328184523.4480-1-vatsalanarang@gmail.com>

On Fri, Mar 29, 2019 at 12:15:23AM +0530, Vatsala Narang wrote:
> Corrected the identation of switch case to get rid of checkpatch error
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/wifi.h | 72 ++++++++++++------------
>  1 file changed, 36 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
> index 559bf2606fb7..ee1994ecbf18 100644
> --- a/drivers/staging/rtl8723bs/include/wifi.h
> +++ b/drivers/staging/rtl8723bs/include/wifi.h
> @@ -374,18 +374,18 @@ __inline static unsigned char * get_da(unsigned char *pframe)
>  	unsigned int	to_fr_ds	= (GetToDs(pframe) << 1) | GetFrDs(pframe);
>  
>  	switch (to_fr_ds) {
> -		case 0x00:	/*  ToDs = 0, FromDs = 0 */
> -			da = GetAddr1Ptr(pframe);
> -			break;
> -		case 0x01:	/*  ToDs = 0, FromDs = 1 */
> -			da = GetAddr1Ptr(pframe);
> -			break;
> -		case 0x02:	/*  ToDs = 1, FromDs = 0 */
> -			da = GetAddr3Ptr(pframe);
> -			break;
> -		default:	/*  ToDs = 1, FromDs = 1 */
> -			da = GetAddr3Ptr(pframe);
> -			break;
> +	case 0x00:	/*  ToDs = 0, FromDs = 0 */
> +		da = GetAddr1Ptr(pframe);
> +		break;
> +	case 0x01:	/*  ToDs = 0, FromDs = 1 */
> +		da = GetAddr1Ptr(pframe);
> +		break;
> +	case 0x02:	/*  ToDs = 1, FromDs = 0 */
> +		da = GetAddr3Ptr(pframe);
> +		break;
> +	default:	/*  ToDs = 1, FromDs = 1 */
> +		da = GetAddr3Ptr(pframe);
> +		break;
>  	}
>  
>  	return da;
> @@ -398,18 +398,18 @@ __inline static unsigned char * get_sa(unsigned char *pframe)
>  	unsigned int	to_fr_ds	= (GetToDs(pframe) << 1) | GetFrDs(pframe);
>  
>  	switch (to_fr_ds) {
> -		case 0x00:	/*  ToDs = 0, FromDs = 0 */
> -			sa = GetAddr2Ptr(pframe);
> -			break;
> -		case 0x01:	/*  ToDs = 0, FromDs = 1 */
> -			sa = GetAddr3Ptr(pframe);
> -			break;
> -		case 0x02:	/*  ToDs = 1, FromDs = 0 */
> -			sa = GetAddr2Ptr(pframe);
> -			break;
> -		default:	/*  ToDs = 1, FromDs = 1 */
> -			sa = GetAddr4Ptr(pframe);
> -			break;
> +	case 0x00:	/*  ToDs = 0, FromDs = 0 */
> +		sa = GetAddr2Ptr(pframe);
> +		break;
> +	case 0x01:	/*  ToDs = 0, FromDs = 1 */
> +		sa = GetAddr3Ptr(pframe);
> +		break;
> +	case 0x02:	/*  ToDs = 1, FromDs = 0 */
> +		sa = GetAddr2Ptr(pframe);
> +		break;
> +	default:	/*  ToDs = 1, FromDs = 1 */
> +		sa = GetAddr4Ptr(pframe);
> +		break;
>  	}
>  
>  	return sa;
> @@ -421,18 +421,18 @@ __inline static unsigned char * get_hdr_bssid(unsigned char *pframe)
>  	unsigned int	to_fr_ds	= (GetToDs(pframe) << 1) | GetFrDs(pframe);
>  
>  	switch (to_fr_ds) {
> -		case 0x00:	/*  ToDs = 0, FromDs = 0 */
> -			sa = GetAddr3Ptr(pframe);
> -			break;
> -		case 0x01:	/*  ToDs = 0, FromDs = 1 */
> -			sa = GetAddr2Ptr(pframe);
> -			break;
> -		case 0x02:	/*  ToDs = 1, FromDs = 0 */
> -			sa = GetAddr1Ptr(pframe);
> -			break;
> -		case 0x03:	/*  ToDs = 1, FromDs = 1 */
> -			sa = GetAddr1Ptr(pframe);
> -			break;
> +	case 0x00:	/*  ToDs = 0, FromDs = 0 */
> +		sa = GetAddr3Ptr(pframe);
> +		break;
> +	case 0x01:	/*  ToDs = 0, FromDs = 1 */
> +		sa = GetAddr2Ptr(pframe);
> +		break;
> +	case 0x02:	/*  ToDs = 1, FromDs = 0 */
> +		sa = GetAddr1Ptr(pframe);
> +		break;
> +	case 0x03:	/*  ToDs = 1, FromDs = 1 */
> +		sa = GetAddr1Ptr(pframe);
> +		break;
>  	}
>  
>  	return sa;
> -- 
> 2.17.1
> 

Patch does not apply to my staging-next branch.  Please rebase and
resend.

thanks,

greg k-h


  reply	other threads:[~2019-03-29 16:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 18:45 [PATCH] staging: rtl8723bs: include: Fix identation issue Vatsala Narang
2019-03-29 16:13 ` Greg KH [this message]
2019-03-29 16:17   ` Vatsala Narang
  -- strict thread matches above, loose matches on Subject: below --
2019-03-23 22:09 Vatsala Narang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329161346.GB540@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=vatsalanarang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.