From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Cc: Paul Zimmerman <pauldzim@gmail.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)
Date: Tue, 9 Apr 2019 16:41:41 +0300 [thread overview]
Message-ID: <20190409134141.GB9759@linux.intel.com> (raw)
In-Reply-To: <31f75727-d2c3-1afa-ab14-1dbc62a6315b@ginzinger.com>
On Mon, Apr 08, 2019 at 07:53:34AM +0200, Martin Kepplinger wrote:
> On 21.03.19 14:41, Jarkko Sakkinen wrote:
> > On Tue, Mar 19, 2019 at 04:03:37PM -0700, Paul Zimmerman wrote:
> >> So I bisected this down to:
> >>
> >> # first bad commit: [a3fbfae82b4cb3ff9928e29f34c64d0507cad874] tpm:
> >> take TPM chip power gating out of tpm_transmit()
> >>
> >> but this doesn't revert cleanly on Linus' HEAD. Anyone have an idea what
> >> could be wrong here?
> >
> > Sorry I've been in flu for the early week. I spotted the bug
> > immediately. When I did these patches I did not have TPM 1.x at my
> > hand. I used fTPM 2.0 and dTPM 2.0. Stefan did TPM 1.x testing but I
> > probably forgot to ask him to try out suspend.
> >
> > Anyway, the bug is obvious and I'll send you a patch to try out.
> > Thanks a lot for bisecting this!
> >
> > /Jarkko
> >
>
>
> Hi,
>
> Any news on this? It seems not to be fixed in -rc4. I'd happily test a
> patch too.
>
> thanks a lot,
>
> martin
I sent a PR to James last week with the fix. Probably has not landed
yet.
https://lore.kernel.org/linux-integrity/20190329115544.GA27351@linux.intel.com/
/Jarkko
prev parent reply other threads:[~2019-04-09 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 21:39 Regression in suspend-to-ram (TPM related) with 5.1-rc1 Paul Zimmerman
2019-03-18 22:11 ` Paul Zimmerman
2019-03-19 1:08 ` Paul Zimmerman
2019-03-19 23:03 ` Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED) Paul Zimmerman
2019-03-21 13:41 ` Jarkko Sakkinen
2019-04-08 5:53 ` Martin Kepplinger
2019-04-08 5:53 ` Martin Kepplinger
2019-04-08 6:59 ` Paul Zimmerman
2019-04-08 9:04 ` Martin Kepplinger
2019-04-09 13:42 ` Jarkko Sakkinen
2019-04-09 13:41 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409134141.GB9759@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@ginzinger.com \
--cc=pauldzim@gmail.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.