From: Stephen Checkoway <stephen.checkoway@oberlin.edu>
To: "QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"Stephen Checkoway" <stephen.checkoway@oberlin.edu>,
"Markus Armbruster" <armbru@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v3 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality
Date: Wed, 17 Apr 2019 18:01:37 -0400 [thread overview]
Message-ID: <20190417220147.67648-1-stephen.checkoway@oberlin.edu> (raw)
The goal of this patch series implement the following AMD command-set parallel
flash functionality:
- flash interleaving;
- nonuniform sector sizes;
- erase suspend/resume commands; and
- multi-sector erase.
During refactoring and implementation, I discovered several bugs that are
fixed here as well:
- flash commands use only 11-bits of the address in most cases, but the
current code uses all of them [1];
- entering CFI mode from autoselect mode and then exiting CFI mode should
return the chip to autoselect mode, but the current code returns to read
array mode; and
- reset command should be ignored during sector/chip erase, but the current
code performs the reset.
The first patch in the series adds a test for the existing behavior. Tests for
additional behavior/bug fixes are added in the relevant patch.
1. I found firmware in the wild that relies on the 11-bit address behavior,
probably due to a bug in the firmware itself.
Changes from v1:
- Fix missing spaces around *, -, and ?;
- Fix missing Signed-off-by line on patch 7; and
- Replace use of errc with g_printerr and exit.
Changes from v2:
- Remove global_qtest from tests; and
- Test the CFI table changes.
Stephen Checkoway (10):
block/pflash_cfi02: Add test for supported commands
block/pflash_cfi02: Refactor, NFC intended
block/pflash_cfi02: Fix command address comparison
block/pflash_cfi02: Implement intereleaved flash devices
block/pflash_cfi02: Implement nonuniform sector sizes
block/pflash_cfi02: Fix CFI in autoselect mode
block/pflash_cfi02: Fix reset command not ignored during erase
block/pflash_cfi02: Implement multi-sector erase
block/pflash_cfi02: Implement erase suspend/resume
block/pflash_cfi02: Use the chip erase time specified in the CFI table
hw/block/pflash_cfi02.c | 843 +++++++++++++++++++++++++++-----------
tests/Makefile.include | 2 +
tests/pflash-cfi02-test.c | 815 ++++++++++++++++++++++++++++++++++++
3 files changed, 1423 insertions(+), 237 deletions(-)
create mode 100644 tests/pflash-cfi02-test.c
--
2.20.1 (Apple Git-117)
next reply other threads:[~2019-04-17 22:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 22:01 Stephen Checkoway [this message]
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 01/10] block/pflash_cfi02: Add test for supported commands Stephen Checkoway
2019-04-18 4:47 ` Thomas Huth
2019-04-18 20:43 ` Stephen Checkoway
2019-04-18 20:43 ` Stephen Checkoway
2019-04-19 5:57 ` Thomas Huth
2019-04-19 5:57 ` Thomas Huth
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 02/10] block/pflash_cfi02: Refactor, NFC intended Stephen Checkoway
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 03/10] block/pflash_cfi02: Fix command address comparison Stephen Checkoway
2019-04-18 4:22 ` Thomas Huth
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 04/10] block/pflash_cfi02: Implement intereleaved flash devices Stephen Checkoway
2019-04-18 4:23 ` Thomas Huth
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 05/10] block/pflash_cfi02: Implement nonuniform sector sizes Stephen Checkoway
2019-04-18 4:25 ` Thomas Huth
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 06/10] block/pflash_cfi02: Fix CFI in autoselect mode Stephen Checkoway
2019-04-18 4:28 ` Thomas Huth
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 07/10] block/pflash_cfi02: Fix reset command not ignored during erase Stephen Checkoway
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 08/10] block/pflash_cfi02: Implement multi-sector erase Stephen Checkoway
2019-04-18 4:52 ` Thomas Huth
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 09/10] block/pflash_cfi02: Implement erase suspend/resume Stephen Checkoway
2019-04-18 4:54 ` Thomas Huth
2019-04-17 22:01 ` [Qemu-devel] [PATCH v3 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table Stephen Checkoway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417220147.67648-1-stephen.checkoway@oberlin.edu \
--to=stephen.checkoway@oberlin.edu \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.