All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
	netdev@vger.kernel.org, Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric
Date: Mon, 20 May 2019 10:03:22 -0700	[thread overview]
Message-ID: <20190520100322.2276a76d@hermes.lan> (raw)
In-Reply-To: <4e2e8ba7-7c80-4d35-9255-c6dac47df4e7@gmail.com>

On Mon, 20 May 2019 09:18:08 -0600
David Ahern <dsahern@gmail.com> wrote:

> On 5/20/19 1:56 AM, Hangbin Liu wrote:
> > When calles rtnl_dsfield_n2a(), we get the dsfield name from
> > /etc/iproute2/rt_dsfield. But different distribution may have
> > different names. So add a new parameter '-Numeric' to only show
> > the dsfield number.
> > 
> > This parameter is only used for tos value at present. We could enable
> > this for other fields if needed in the future.
> > 
> 
> It does not make sense to add this flag just for 1 field.
> 
> 3 years ago I started a patch to apply this across the board. never
> finished it. see attached. The numeric variable should be moved to
> lib/rt_names.c. It handles all of the conversions in that file - at
> least as of May 2016.


Agree, if you are going to do it, go all in.
Handle all types and in same manner for ip, tc, bridge, and devlink.
ss already has -numeric option.

Wish that -n wasn't used for netns, should have been -N...

  reply	other threads:[~2019-05-20 17:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  7:56 [PATCH iproute2 net-next] ip: add a new parameter -Numeric Hangbin Liu
2019-05-20 10:24 ` Phil Sutter
2019-05-20 15:18 ` David Ahern
2019-05-20 17:03   ` Stephen Hemminger [this message]
2019-05-21 12:13     ` Hangbin Liu
2019-05-21 21:20       ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520100322.2276a76d@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dsahern@gmail.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.