From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18757C282E1 for ; Thu, 23 May 2019 10:28:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E56CD21019 for ; Thu, 23 May 2019 10:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730406AbfEWK2V (ORCPT ); Thu, 23 May 2019 06:28:21 -0400 Received: from foss.arm.com ([217.140.101.70]:42882 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729972AbfEWK2U (ORCPT ); Thu, 23 May 2019 06:28:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A688341; Thu, 23 May 2019 03:28:20 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1AA03F718; Thu, 23 May 2019 03:28:15 -0700 (PDT) Date: Thu, 23 May 2019 11:28:13 +0100 From: Mark Rutland To: Arnd Bergmann Cc: Linux Kernel Mailing List , Peter Zijlstra , Will Deacon , Albert Ou , Borislav Petkov , Catalin Marinas , David Miller , Fenghua Yu , Heiko Carstens , Herbert Xu , Ivan Kokshaysky , James Hogan , Russell King - ARM Linux , Matt Turner , Ingo Molnar , Michael Ellerman , Palmer Dabbelt , Paul Burton , Paul Mackerras , Ralf Baechle , Richard Henderson , "# 3.4.x" , Thomas Gleixner , Tony Luck , Vineet Gupta Subject: Re: [PATCH 00/18] locking/atomic: atomic64 type cleanup Message-ID: <20190523102813.GC3370@lakrids.cambridge.arm.com> References: <20190522132250.26499-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 11:18:59PM +0200, Arnd Bergmann wrote: > On Wed, May 22, 2019 at 3:23 PM Mark Rutland wrote: > > > > Currently architectures return inconsistent types for atomic64 ops. Some return > > long (e..g. powerpc), some return long long (e.g. arc), and some return s64 > > (e.g. x86). > > > > This is a bit messy, and causes unnecessary pain (e.g. as values must be cast > > before they can be printed [1]). > > > > This series reworks all the atomic64 implementations to use s64 as the base > > type for atomic64_t (as discussed [2]), and to ensure that this type is > > consistently used for parameters and return values in the API, avoiding further > > problems in this area. > > > > This series (based on v5.1-rc1) can also be found in my atomics/type-cleanup > > branch [3] on kernel.org. > > Nice cleanup! > > I've provided an explicit Ack for the asm-generic patch if someone wants > to pick up the entire series, but I can also put it all into my asm-generic > tree if you want, after more people have had a chance to take a look. Thanks! I had assumed that this would go through the tip tree, as previous atomic rework had, but I have no preference as to how this gets merged. I'm not sure what the policy is, so I'll leave it to Peter and Will to say. Mark.