From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F1EC04AB6 for ; Tue, 28 May 2019 09:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4834F208CB for ; Tue, 28 May 2019 09:06:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="frw58n0p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbfE1JDd (ORCPT ); Tue, 28 May 2019 05:03:33 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:47052 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727014AbfE1JDb (ORCPT ); Tue, 28 May 2019 05:03:31 -0400 Received: by mail-ed1-f68.google.com with SMTP id f37so30562065edb.13 for ; Tue, 28 May 2019 02:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uqvjuHP1JlltKsAAI+cqqXVrkqUOcJ7eWhpcU6m4g1c=; b=frw58n0pRHAXNDbcXB+xAqYIkvLZxek+SzpkxuUVcIcCgtAz4ksuilklcx2AQ4saSF 4whTeD2QhLuWUQBHUNchNxxkkb8QdQNnYaTwPxS9iD+InQMnlwn6A6Hx4kcb2+t8RIKl C4tVxDn3n3c+Eq+/pdndHPl8PbLYZ9uoeajEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uqvjuHP1JlltKsAAI+cqqXVrkqUOcJ7eWhpcU6m4g1c=; b=dkHH+vfGhQJUOXxiDXE3gbU7q2XoO8PYrNyOr33XcD0DT4zrX4Wwzw8FN8HqHJWWib lQoehzyV9evwn6Hf8EHMRhgaEqdgcY71MNdOpKJEFNVZCvo21B1TLEY2TWP1Cc95U6SU ObcFkYvJJLnDhQhU7TQ+z/u5o7kK+LaUWL1IHVQq6abjyi72LqdX6BmeqaTe++ZPGXej ms/0UORce871BzSeE38EkI6t/FkVesiCSkevbkQRAllqHcVaMBJOWQdUiTIs3NW+CrWa ckmq0FW7I9vxlCabHdrJQAlTINP/ljv6bm2dblswJKUQ4ezXRlei/5bJT2h2MrnAH9Yc 7a1A== X-Gm-Message-State: APjAAAU/nMc2C3HLM+R96NdDylJ9PYymJgP0T9aXPYcF7AIQ1mttp6lC WDdNc+1LAnFn2z5If/nZ/6dRuKnSG1E= X-Google-Smtp-Source: APXvYqxkR8uRPfRQx/cEMiLS4f+zqTikJ6iJyG5emvQCsp3aU+7WOuJdm2C2xsdHOcVuFOgNa2Uw0Q== X-Received: by 2002:a50:a4f7:: with SMTP id x52mr128120101edb.86.1559034209379; Tue, 28 May 2019 02:03:29 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id x49sm4072656edm.25.2019.05.28.02.03.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 02:03:28 -0700 (PDT) From: Daniel Vetter To: LKML Cc: DRI Development , Intel Graphics Development , linux-fbdev@vger.kernel.org, Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , Sam Ravnborg , Maarten Lankhorst Subject: [PATCH 12/33] fbdev/omap: sysfs files can't disappear before the device is gone Date: Tue, 28 May 2019 11:02:43 +0200 Message-Id: <20190528090304.9388-13-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190528090304.9388-1-daniel.vetter@ffwll.ch> References: <20190528090304.9388-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Which means lock_fb_info can never fail. Remove the error handling. Signed-off-by: Daniel Vetter Reviewed-by: Sam Ravnborg Reviewed-by: Maarten Lankhorst Cc: Daniel Vetter --- .../video/fbdev/omap2/omapfb/omapfb-sysfs.c | 21 +++++++------------ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c index 8087a009c54f..bd0d20283372 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c @@ -60,8 +60,7 @@ static ssize_t store_rotate_type(struct device *dev, if (rot_type != OMAP_DSS_ROT_DMA && rot_type != OMAP_DSS_ROT_VRFB) return -EINVAL; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); r = 0; if (rot_type == ofbi->rotation_type) @@ -112,8 +111,7 @@ static ssize_t store_mirror(struct device *dev, if (r) return r; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); ofbi->mirror = mirror; @@ -149,8 +147,7 @@ static ssize_t show_overlays(struct device *dev, ssize_t l = 0; int t; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); omapfb_lock(fbdev); for (t = 0; t < ofbi->num_overlays; t++) { @@ -208,8 +205,7 @@ static ssize_t store_overlays(struct device *dev, struct device_attribute *attr, if (buf[len - 1] == '\n') len = len - 1; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); omapfb_lock(fbdev); if (len > 0) { @@ -340,8 +336,7 @@ static ssize_t show_overlays_rotate(struct device *dev, ssize_t l = 0; int t; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); for (t = 0; t < ofbi->num_overlays; t++) { l += snprintf(buf + l, PAGE_SIZE - l, "%s%d", @@ -369,8 +364,7 @@ static ssize_t store_overlays_rotate(struct device *dev, if (buf[len - 1] == '\n') len = len - 1; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); if (len > 0) { char *p = (char *)buf; @@ -453,8 +447,7 @@ static ssize_t store_size(struct device *dev, struct device_attribute *attr, size = PAGE_ALIGN(size); - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); if (display && display->driver->sync) display->driver->sync(display); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Tue, 28 May 2019 09:02:43 +0000 Subject: [PATCH 12/33] fbdev/omap: sysfs files can't disappear before the device is gone Message-Id: <20190528090304.9388-13-daniel.vetter@ffwll.ch> List-Id: References: <20190528090304.9388-1-daniel.vetter@ffwll.ch> In-Reply-To: <20190528090304.9388-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: LKML Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , Intel Graphics Development , linux-fbdev@vger.kernel.org, DRI Development , Sam Ravnborg Which means lock_fb_info can never fail. Remove the error handling. Signed-off-by: Daniel Vetter Reviewed-by: Sam Ravnborg Reviewed-by: Maarten Lankhorst Cc: Daniel Vetter --- .../video/fbdev/omap2/omapfb/omapfb-sysfs.c | 21 +++++++------------ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c index 8087a009c54f..bd0d20283372 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c @@ -60,8 +60,7 @@ static ssize_t store_rotate_type(struct device *dev, if (rot_type != OMAP_DSS_ROT_DMA && rot_type != OMAP_DSS_ROT_VRFB) return -EINVAL; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); r = 0; if (rot_type = ofbi->rotation_type) @@ -112,8 +111,7 @@ static ssize_t store_mirror(struct device *dev, if (r) return r; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); ofbi->mirror = mirror; @@ -149,8 +147,7 @@ static ssize_t show_overlays(struct device *dev, ssize_t l = 0; int t; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); omapfb_lock(fbdev); for (t = 0; t < ofbi->num_overlays; t++) { @@ -208,8 +205,7 @@ static ssize_t store_overlays(struct device *dev, struct device_attribute *attr, if (buf[len - 1] = '\n') len = len - 1; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); omapfb_lock(fbdev); if (len > 0) { @@ -340,8 +336,7 @@ static ssize_t show_overlays_rotate(struct device *dev, ssize_t l = 0; int t; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); for (t = 0; t < ofbi->num_overlays; t++) { l += snprintf(buf + l, PAGE_SIZE - l, "%s%d", @@ -369,8 +364,7 @@ static ssize_t store_overlays_rotate(struct device *dev, if (buf[len - 1] = '\n') len = len - 1; - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); if (len > 0) { char *p = (char *)buf; @@ -453,8 +447,7 @@ static ssize_t store_size(struct device *dev, struct device_attribute *attr, size = PAGE_ALIGN(size); - if (!lock_fb_info(fbi)) - return -ENODEV; + lock_fb_info(fbi); if (display && display->driver->sync) display->driver->sync(display); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: [PATCH 12/33] fbdev/omap: sysfs files can't disappear before the device is gone Date: Tue, 28 May 2019 11:02:43 +0200 Message-ID: <20190528090304.9388-13-daniel.vetter@ffwll.ch> References: <20190528090304.9388-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 132CF89E14 for ; Tue, 28 May 2019 09:03:31 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id w37so30609235edw.4 for ; Tue, 28 May 2019 02:03:31 -0700 (PDT) In-Reply-To: <20190528090304.9388-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: LKML Cc: Daniel Thompson , Bartlomiej Zolnierkiewicz , Daniel Vetter , Intel Graphics Development , linux-fbdev@vger.kernel.org, DRI Development , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org V2hpY2ggbWVhbnMgbG9ja19mYl9pbmZvIGNhbiBuZXZlciBmYWlsLiBSZW1vdmUgdGhlIGVycm9y IGhhbmRsaW5nLgoKU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KUmV2aWV3ZWQtYnk6IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4KUmV2 aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl bC5jb20+CkNjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgotLS0KIC4u Li92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvb21hcGZiLXN5c2ZzLmMgICB8IDIxICsrKysrKyst LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL29tYXBm Yi1zeXNmcy5jIGIvZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvb21hcGZiLXN5c2Zz LmMKaW5kZXggODA4N2EwMDljNTRmLi5iZDBkMjAyODMzNzIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv dmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL29tYXBmYi1zeXNmcy5jCisrKyBiL2RyaXZlcnMvdmlk ZW8vZmJkZXYvb21hcDIvb21hcGZiL29tYXBmYi1zeXNmcy5jCkBAIC02MCw4ICs2MCw3IEBAIHN0 YXRpYyBzc2l6ZV90IHN0b3JlX3JvdGF0ZV90eXBlKHN0cnVjdCBkZXZpY2UgKmRldiwKIAlpZiAo cm90X3R5cGUgIT0gT01BUF9EU1NfUk9UX0RNQSAmJiByb3RfdHlwZSAhPSBPTUFQX0RTU19ST1Rf VlJGQikKIAkJcmV0dXJuIC1FSU5WQUw7CiAKLQlpZiAoIWxvY2tfZmJfaW5mbyhmYmkpKQotCQly ZXR1cm4gLUVOT0RFVjsKKwlsb2NrX2ZiX2luZm8oZmJpKTsKIAogCXIgPSAwOwogCWlmIChyb3Rf dHlwZSA9PSBvZmJpLT5yb3RhdGlvbl90eXBlKQpAQCAtMTEyLDggKzExMSw3IEBAIHN0YXRpYyBz c2l6ZV90IHN0b3JlX21pcnJvcihzdHJ1Y3QgZGV2aWNlICpkZXYsCiAJaWYgKHIpCiAJCXJldHVy biByOwogCi0JaWYgKCFsb2NrX2ZiX2luZm8oZmJpKSkKLQkJcmV0dXJuIC1FTk9ERVY7CisJbG9j a19mYl9pbmZvKGZiaSk7CiAKIAlvZmJpLT5taXJyb3IgPSBtaXJyb3I7CiAKQEAgLTE0OSw4ICsx NDcsNyBAQCBzdGF0aWMgc3NpemVfdCBzaG93X292ZXJsYXlzKHN0cnVjdCBkZXZpY2UgKmRldiwK IAlzc2l6ZV90IGwgPSAwOwogCWludCB0OwogCi0JaWYgKCFsb2NrX2ZiX2luZm8oZmJpKSkKLQkJ cmV0dXJuIC1FTk9ERVY7CisJbG9ja19mYl9pbmZvKGZiaSk7CiAJb21hcGZiX2xvY2soZmJkZXYp OwogCiAJZm9yICh0ID0gMDsgdCA8IG9mYmktPm51bV9vdmVybGF5czsgdCsrKSB7CkBAIC0yMDgs OCArMjA1LDcgQEAgc3RhdGljIHNzaXplX3Qgc3RvcmVfb3ZlcmxheXMoc3RydWN0IGRldmljZSAq ZGV2LCBzdHJ1Y3QgZGV2aWNlX2F0dHJpYnV0ZSAqYXR0ciwKIAlpZiAoYnVmW2xlbiAtIDFdID09 ICdcbicpCiAJCWxlbiA9IGxlbiAtIDE7CiAKLQlpZiAoIWxvY2tfZmJfaW5mbyhmYmkpKQotCQly ZXR1cm4gLUVOT0RFVjsKKwlsb2NrX2ZiX2luZm8oZmJpKTsKIAlvbWFwZmJfbG9jayhmYmRldik7 CiAKIAlpZiAobGVuID4gMCkgewpAQCAtMzQwLDggKzMzNiw3IEBAIHN0YXRpYyBzc2l6ZV90IHNo b3dfb3ZlcmxheXNfcm90YXRlKHN0cnVjdCBkZXZpY2UgKmRldiwKIAlzc2l6ZV90IGwgPSAwOwog CWludCB0OwogCi0JaWYgKCFsb2NrX2ZiX2luZm8oZmJpKSkKLQkJcmV0dXJuIC1FTk9ERVY7CisJ bG9ja19mYl9pbmZvKGZiaSk7CiAKIAlmb3IgKHQgPSAwOyB0IDwgb2ZiaS0+bnVtX292ZXJsYXlz OyB0KyspIHsKIAkJbCArPSBzbnByaW50ZihidWYgKyBsLCBQQUdFX1NJWkUgLSBsLCAiJXMlZCIs CkBAIC0zNjksOCArMzY0LDcgQEAgc3RhdGljIHNzaXplX3Qgc3RvcmVfb3ZlcmxheXNfcm90YXRl KHN0cnVjdCBkZXZpY2UgKmRldiwKIAlpZiAoYnVmW2xlbiAtIDFdID09ICdcbicpCiAJCWxlbiA9 IGxlbiAtIDE7CiAKLQlpZiAoIWxvY2tfZmJfaW5mbyhmYmkpKQotCQlyZXR1cm4gLUVOT0RFVjsK Kwlsb2NrX2ZiX2luZm8oZmJpKTsKIAogCWlmIChsZW4gPiAwKSB7CiAJCWNoYXIgKnAgPSAoY2hh ciAqKWJ1ZjsKQEAgLTQ1Myw4ICs0NDcsNyBAQCBzdGF0aWMgc3NpemVfdCBzdG9yZV9zaXplKHN0 cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0dHIsCiAKIAlzaXpl ID0gUEFHRV9BTElHTihzaXplKTsKIAotCWlmICghbG9ja19mYl9pbmZvKGZiaSkpCi0JCXJldHVy biAtRU5PREVWOworCWxvY2tfZmJfaW5mbyhmYmkpOwogCiAJaWYgKGRpc3BsYXkgJiYgZGlzcGxh eS0+ZHJpdmVyLT5zeW5jKQogCQlkaXNwbGF5LT5kcml2ZXItPnN5bmMoZGlzcGxheSk7Ci0tIAoy LjIwLjEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==