From: YueHaibing <yuehaibing@huawei.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next] crypto: atmel-i2c - Fix build error while CRC16 set to m
Date: Fri, 31 May 2019 17:49:00 +0800 [thread overview]
Message-ID: <20190531094900.12708-1-yuehaibing@huawei.com> (raw)
If CRYPTO_DEV_ATMEL_ECC is set m, which select CRC16 to m,
while CRYPTO_DEV_ATMEL_SHA204A is set to y, building fails.
drivers/crypto/atmel-i2c.o: In function `atmel_i2c_checksum':
atmel-i2c.c:(.text+0x16): undefined reference to `crc16'
Add CRC16 dependency to CRYPTO_DEV_ATMEL_SHA204A, and also make
CRYPTO_DEV_ATMEL_ECC depends on CRC16.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: da001fb651b0 ("crypto: atmel-i2c - add support for SHA204A random number generator")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/crypto/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index fe01a99..7aebff8 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -528,7 +528,7 @@ config CRYPTO_DEV_ATMEL_ECC
depends on I2C
select CRYPTO_DEV_ATMEL_I2C
select CRYPTO_ECDH
- select CRC16
+ depends on CRC16
help
Microhip / Atmel ECC hw accelerator.
Select this if you want to use the Microchip / Atmel module for
@@ -540,6 +540,7 @@ config CRYPTO_DEV_ATMEL_ECC
config CRYPTO_DEV_ATMEL_SHA204A
tristate "Support for Microchip / Atmel SHA accelerator and RNG"
depends on I2C
+ depends on CRC16
select CRYPTO_DEV_ATMEL_I2C
select HW_RANDOM
help
--
2.7.4
next reply other threads:[~2019-05-31 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 9:49 YueHaibing [this message]
2019-05-31 9:53 ` [PATCH -next] crypto: atmel-i2c - Fix build error while CRC16 set to m Ard Biesheuvel
2019-05-31 12:17 ` [PATCH v2 " YueHaibing
2019-06-06 6:58 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531094900.12708-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.