From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85116C282CE for ; Tue, 4 Jun 2019 14:59:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6457424AB7 for ; Tue, 4 Jun 2019 14:59:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728002AbfFDO7T (ORCPT ); Tue, 4 Jun 2019 10:59:19 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43577 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727921AbfFDO7Q (ORCPT ); Tue, 4 Jun 2019 10:59:16 -0400 X-Originating-IP: 90.88.144.139 Received: from localhost (aaubervilliers-681-1-24-139.w90-88.abo.wanadoo.fr [90.88.144.139]) (Authenticated sender: maxime.ripard@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E4BFE6000C; Tue, 4 Jun 2019 14:59:07 +0000 (UTC) Date: Tue, 4 Jun 2019 16:59:07 +0200 From: Maxime Ripard To: Luca Weiss Cc: Hans de Goede , Dmitry Torokhov , Rob Herring , Mark Rutland , Chen-Yu Tsai , "open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Allwinner sunXi SoC support" , open list Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Message-ID: <20190604145907.j3fp52gxupd3bkih@flea> References: <20190604144252.26965-1-luca@z3ntu.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zeywvuntmrvlmigf" Content-Disposition: inline In-Reply-To: <20190604144252.26965-1-luca@z3ntu.xyz> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zeywvuntmrvlmigf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = ; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zeywvuntmrvlmigf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXPaHOwAKCRDj7w1vZxhR xSCVAP9HifWQjLo0644GCGN5e5COuSQdxy0ZI0cNk9VMK0ez6wEAsx9jt6NTjM24 Trk40SgSkATAuyASrgr34Yguf/iQbQk= =yHyP -----END PGP SIGNATURE----- --zeywvuntmrvlmigf-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Tue, 4 Jun 2019 16:59:07 +0200 Message-ID: <20190604145907.j3fp52gxupd3bkih@flea> References: <20190604144252.26965-1-luca@z3ntu.xyz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zeywvuntmrvlmigf" Return-path: Content-Disposition: inline In-Reply-To: <20190604144252.26965-1-luca@z3ntu.xyz> Sender: linux-kernel-owner@vger.kernel.org To: Luca Weiss Cc: Hans de Goede , Dmitry Torokhov , Rob Herring , Mark Rutland , Chen-Yu Tsai , "open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Allwinner sunXi SoC support" , open list List-Id: devicetree@vger.kernel.org --zeywvuntmrvlmigf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = ; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zeywvuntmrvlmigf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXPaHOwAKCRDj7w1vZxhR xSCVAP9HifWQjLo0644GCGN5e5COuSQdxy0ZI0cNk9VMK0ez6wEAsx9jt6NTjM24 Trk40SgSkATAuyASrgr34Yguf/iQbQk= =yHyP -----END PGP SIGNATURE----- --zeywvuntmrvlmigf-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA10C282CE for ; Tue, 4 Jun 2019 14:59:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE5C624AB7 for ; Tue, 4 Jun 2019 14:59:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rEFlWEPC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE5C624AB7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K4UzNTaMXJIQpqtx6PdZtw7dPnazwu4h+qPM1vhr4Zo=; b=rEFlWEPC4aF09oWsOg7Pb8LCg KmlVdzrnvg47YsXQOdT+witdBlWzeVc8vJK0ZPF4t1cDmQD6hV7KceFfbWKRHTGxYlk9XaQ354TGR YRzD9kndbMjWXqBONsBMz5j69xROlwadLecK+LFulg5pCD3ykvRKNWpNJvSD8cP8Pig9QgWSEd4jx ZLqHpn4oqo8JVq6Qm2g55wzo2CPKeaHoWw7TgEEIETxmMf4cNnwbSUfaxdn5qrvPqZ8XrKt07oc2s olN8cOzYmB8KAUrgYGdHmUAyoI9i/qxftTjPqtHV904kKhstAej9S+I+ElPaw+YF1pquu2E0Vtjnc 6z+Mqgwkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYAuk-0007xC-Tn; Tue, 04 Jun 2019 14:59:50 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYAuJ-0007KP-IO for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2019 14:59:28 +0000 X-Originating-IP: 90.88.144.139 Received: from localhost (aaubervilliers-681-1-24-139.w90-88.abo.wanadoo.fr [90.88.144.139]) (Authenticated sender: maxime.ripard@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E4BFE6000C; Tue, 4 Jun 2019 14:59:07 +0000 (UTC) Date: Tue, 4 Jun 2019 16:59:07 +0200 From: Maxime Ripard To: Luca Weiss Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Message-ID: <20190604145907.j3fp52gxupd3bkih@flea> References: <20190604144252.26965-1-luca@z3ntu.xyz> MIME-Version: 1.0 In-Reply-To: <20190604144252.26965-1-luca@z3ntu.xyz> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_075924_186716_85C10579 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Dmitry Torokhov , open list , Hans de Goede , Chen-Yu Tsai , Rob Herring , "open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER" , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: multipart/mixed; boundary="===============6448138612327714043==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6448138612327714043== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zeywvuntmrvlmigf" Content-Disposition: inline --zeywvuntmrvlmigf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = ; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zeywvuntmrvlmigf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXPaHOwAKCRDj7w1vZxhR xSCVAP9HifWQjLo0644GCGN5e5COuSQdxy0ZI0cNk9VMK0ez6wEAsx9jt6NTjM24 Trk40SgSkATAuyASrgr34Yguf/iQbQk= =yHyP -----END PGP SIGNATURE----- --zeywvuntmrvlmigf-- --===============6448138612327714043== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6448138612327714043==--