From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77945C4321A for ; Tue, 11 Jun 2019 14:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C19C2145D for ; Tue, 11 Jun 2019 14:11:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PG0OjEu1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388906AbfFKOLa (ORCPT ); Tue, 11 Jun 2019 10:11:30 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40353 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387730AbfFKOL3 (ORCPT ); Tue, 11 Jun 2019 10:11:29 -0400 Received: by mail-wm1-f68.google.com with SMTP id v19so3098303wmj.5 for ; Tue, 11 Jun 2019 07:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qc5EFkVTKGr6dYAxoaP7PbGa9RFFb0Yu3NvNTqCuC7g=; b=PG0OjEu1w3GysO55d1AWF1JxGrKq//m5h/+lqkdUO4kaTlmGHYQkTZfi5j2mYvLMxF voKWf4tqIhrTsY9L4GnOTVRdkcQTdMek5MfrPc3nxSNFAMB3Up8vAf2wnBjiv6jDA/f1 PXrO1HfQn7++uNe2BSjhTwc05BzyqrvgZYUJZrcxBZ4teyFkmmgaBSL5H4Q69nG+PSxm z4Fi1g0EI5qm6iG+Yf7J1mEU0kEWIIWJ1YP4tBPqfVzEDWxR65a+AT9PBvZtJLCYK14b 1bvjtCf/Nug5Zf8GiWEBE8FXdY5lS1vOSZv05gmHphpBN6t40O6TpdSG1ZF0jiWNOJh8 7NKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Qc5EFkVTKGr6dYAxoaP7PbGa9RFFb0Yu3NvNTqCuC7g=; b=gw3CDHxLgvhcXjprYMRRnGS0pC1dv2MtJ8dBwba43uxS/beU6n5KaxiaX9V1CJb7s9 z2jkjQISLU9qX9WzzUgaveLe51SkWztPB8HsPzr84IBKTFha5hQqxPEc0hEZfyNBrjx4 Q3TgfhtAswhxDz3dtCF8ahYeBIWxigvIj6KcxKbH3AYWqyBdmppDQFTY3gcrsHYEBVmJ iC8pd0pnv9Y0oaJ1IWAfVhodAevF3KyJpNXl09aRZEg45e/DlPhE3Q2Hpqzb594docO9 w2kixH5jzrBqFtlDX3GdSNYRUyZ4vHWFVdOowolrc7YM6JDCNmoMjijaYtuCsygHhsOS mP/w== X-Gm-Message-State: APjAAAUN+zaGzU4KWCcwMDiuEadjItvEu+MY2hVMJzeO4rJdi8N/DwdP 6BXYutxoqsx0lMoORi/wHFgSCQ== X-Google-Smtp-Source: APXvYqxCrGFZDkB6E92/L2zQkhPrLCT80Z0/I9uddbexDlRQYg1pdUdK2tzvVwqbMxgtCW6DRYNgYQ== X-Received: by 2002:a7b:c081:: with SMTP id r1mr4133085wmh.76.1560262287645; Tue, 11 Jun 2019 07:11:27 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id u23sm2501379wmj.33.2019.06.11.07.11.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 07:11:27 -0700 (PDT) Date: Tue, 11 Jun 2019 15:11:25 +0100 From: Daniel Thompson To: Daniel Vetter Cc: LKML , DRI Development , Intel Graphics Development , linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Daniel Vetter , Sam Ravnborg , Maarten Lankhorst , Lee Jones , Jingoo Han Subject: Re: [PATCH 33/33] backlight: simplify lcd notifier Message-ID: <20190611141125.w6vhytsue7toif3g@holly.lan> References: <20190528090304.9388-1-daniel.vetter@ffwll.ch> <20190528090304.9388-34-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190528090304.9388-34-daniel.vetter@ffwll.ch> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 28, 2019 at 11:03:04AM +0200, Daniel Vetter wrote: > With all the work I've done on replacing fb notifier calls with direct > calls into fbcon the backlight/lcd notifier is the only user left. > > It will only receive events now that it cares about, hence we can > remove this check. > > Signed-off-by: Daniel Vetter > Reviewed-by: Sam Ravnborg > Reviewed-by: Maarten Lankhorst > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Acked-by: Daniel Thompson > --- > drivers/video/backlight/lcd.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c > index ecdda06989d0..d6b653aa4ee9 100644 > --- a/drivers/video/backlight/lcd.c > +++ b/drivers/video/backlight/lcd.c > @@ -30,17 +30,6 @@ static int fb_notifier_callback(struct notifier_block *self, > struct lcd_device *ld; > struct fb_event *evdata = data; > > - /* If we aren't interested in this event, skip it immediately ... */ > - switch (event) { > - case FB_EVENT_BLANK: > - case FB_EVENT_MODE_CHANGE: > - case FB_EARLY_EVENT_BLANK: > - case FB_R_EARLY_EVENT_BLANK: > - break; > - default: > - return 0; > - } > - > ld = container_of(self, struct lcd_device, fb_notif); > if (!ld->ops) > return 0; > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Tue, 11 Jun 2019 14:11:25 +0000 Subject: Re: [PATCH 33/33] backlight: simplify lcd notifier Message-Id: <20190611141125.w6vhytsue7toif3g@holly.lan> List-Id: References: <20190528090304.9388-1-daniel.vetter@ffwll.ch> <20190528090304.9388-34-daniel.vetter@ffwll.ch> In-Reply-To: <20190528090304.9388-34-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Lee Jones , Intel Graphics Development , LKML , DRI Development , Jingoo Han , Daniel Vetter , Sam Ravnborg On Tue, May 28, 2019 at 11:03:04AM +0200, Daniel Vetter wrote: > With all the work I've done on replacing fb notifier calls with direct > calls into fbcon the backlight/lcd notifier is the only user left. > > It will only receive events now that it cares about, hence we can > remove this check. > > Signed-off-by: Daniel Vetter > Reviewed-by: Sam Ravnborg > Reviewed-by: Maarten Lankhorst > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Acked-by: Daniel Thompson > --- > drivers/video/backlight/lcd.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c > index ecdda06989d0..d6b653aa4ee9 100644 > --- a/drivers/video/backlight/lcd.c > +++ b/drivers/video/backlight/lcd.c > @@ -30,17 +30,6 @@ static int fb_notifier_callback(struct notifier_block *self, > struct lcd_device *ld; > struct fb_event *evdata = data; > > - /* If we aren't interested in this event, skip it immediately ... */ > - switch (event) { > - case FB_EVENT_BLANK: > - case FB_EVENT_MODE_CHANGE: > - case FB_EARLY_EVENT_BLANK: > - case FB_R_EARLY_EVENT_BLANK: > - break; > - default: > - return 0; > - } > - > ld = container_of(self, struct lcd_device, fb_notif); > if (!ld->ops) > return 0; > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH 33/33] backlight: simplify lcd notifier Date: Tue, 11 Jun 2019 15:11:25 +0100 Message-ID: <20190611141125.w6vhytsue7toif3g@holly.lan> References: <20190528090304.9388-1-daniel.vetter@ffwll.ch> <20190528090304.9388-34-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3A3389209 for ; Tue, 11 Jun 2019 14:11:28 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id s15so3112163wmj.3 for ; Tue, 11 Jun 2019 07:11:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190528090304.9388-34-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Lee Jones , Intel Graphics Development , LKML , DRI Development , Jingoo Han , Daniel Vetter , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMjgsIDIwMTkgYXQgMTE6MDM6MDRBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBXaXRoIGFsbCB0aGUgd29yayBJJ3ZlIGRvbmUgb24gcmVwbGFjaW5nIGZiIG5vdGlm aWVyIGNhbGxzIHdpdGggZGlyZWN0Cj4gY2FsbHMgaW50byBmYmNvbiB0aGUgYmFja2xpZ2h0L2xj ZCBub3RpZmllciBpcyB0aGUgb25seSB1c2VyIGxlZnQuCj4gCj4gSXQgd2lsbCBvbmx5IHJlY2Vp dmUgZXZlbnRzIG5vdyB0aGF0IGl0IGNhcmVzIGFib3V0LCBoZW5jZSB3ZSBjYW4KPiByZW1vdmUg dGhpcyBjaGVjay4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0 dGVyQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcu b3JnPgo+IFJldmlld2VkLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuY29tPgo+IENjOiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3JnPgo+IENjOiBK aW5nb28gSGFuIDxqaW5nb29oYW4xQGdtYWlsLmNvbT4KCkFja2VkLWJ5OiBEYW5pZWwgVGhvbXBz b24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3JnPgoKCj4gLS0tCj4gIGRyaXZlcnMvdmlkZW8v YmFja2xpZ2h0L2xjZC5jIHwgMTEgLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9sY2Qu YyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L2xjZC5jCj4gaW5kZXggZWNkZGEwNjk4OWQwLi5k NmI2NTNhYTRlZTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvbGNkLmMK PiArKysgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9sY2QuYwo+IEBAIC0zMCwxNyArMzAsNiBA QCBzdGF0aWMgaW50IGZiX25vdGlmaWVyX2NhbGxiYWNrKHN0cnVjdCBub3RpZmllcl9ibG9jayAq c2VsZiwKPiAgCXN0cnVjdCBsY2RfZGV2aWNlICpsZDsKPiAgCXN0cnVjdCBmYl9ldmVudCAqZXZk YXRhID0gZGF0YTsKPiAgCj4gLQkvKiBJZiB3ZSBhcmVuJ3QgaW50ZXJlc3RlZCBpbiB0aGlzIGV2 ZW50LCBza2lwIGl0IGltbWVkaWF0ZWx5IC4uLiAqLwo+IC0Jc3dpdGNoIChldmVudCkgewo+IC0J Y2FzZSBGQl9FVkVOVF9CTEFOSzoKPiAtCWNhc2UgRkJfRVZFTlRfTU9ERV9DSEFOR0U6Cj4gLQlj YXNlIEZCX0VBUkxZX0VWRU5UX0JMQU5LOgo+IC0JY2FzZSBGQl9SX0VBUkxZX0VWRU5UX0JMQU5L Ogo+IC0JCWJyZWFrOwo+IC0JZGVmYXVsdDoKPiAtCQlyZXR1cm4gMDsKPiAtCX0KPiAtCj4gIAls ZCA9IGNvbnRhaW5lcl9vZihzZWxmLCBzdHJ1Y3QgbGNkX2RldmljZSwgZmJfbm90aWYpOwo+ICAJ aWYgKCFsZC0+b3BzKQo+ICAJCXJldHVybiAwOwo+IC0tIAo+IDIuMjAuMQo+IApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=