From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Georgi Djakov <georgi.djakov@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default
Date: Wed, 12 Jun 2019 12:13:47 -0700 [thread overview]
Message-ID: <20190612191347.GE22737@tuxbook-pro> (raw)
In-Reply-To: <49b95f19-4da6-4491-6ed7-5238ecfc35a8@free.fr>
On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:
> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
> we're building MSM_GCC_8916.
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Not sure why these are default at all.
But both drivers are used on platforms other than 8916 as well, so if
anything a fix would be to rename the APCS_MSM8916 to something more
generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
updated and the APCS mailbox driver as well...
Regards,
Bjorn
> ---
> drivers/clk/qcom/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..d5b065f64afc 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,7 @@ if COMMON_CLK_QCOM
>
> config QCOM_A53PLL
> tristate "MSM8916 A53 PLL"
> - default ARCH_QCOM
> + default MSM_GCC_8916
> help
> Support for the A53 PLL on MSM8916 devices. It provides
> the CPU with frequencies above 1GHz.
> @@ -31,7 +31,7 @@ config QCOM_A53PLL
> config QCOM_CLK_APCS_MSM8916
> tristate "MSM8916 APCS Clock Controller"
> depends on QCOM_APCS_IPC || COMPILE_TEST
> - default ARCH_QCOM
> + default MSM_GCC_8916
> help
> Support for the APCS Clock Controller on msm8916 devices. The
> APCS is managing the mux and divider which feeds the CPUs.
> --
> 2.17.1
next prev parent reply other threads:[~2019-06-12 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 15:52 [PATCH v1] clk: qcom: msm8916: Don't build support by default Marc Gonzalez
2019-06-12 19:13 ` Bjorn Andersson [this message]
2019-06-12 19:49 ` Stephen Boyd
2019-06-12 20:03 ` Marc Gonzalez
2019-06-12 22:42 ` Stephen Boyd
2019-06-13 15:05 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612191347.GE22737@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.