All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Takashi Iwai <tiwai@suse.de>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: linux-next: build failure after merge of the sound tree
Date: Fri, 9 Aug 2019 12:54:58 +1000	[thread overview]
Message-ID: <20190809125458.6c7aaa6c@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

Hi all,

After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_read':
sound/hda/hdac_bus.c:228:6: error: implicit declaration of function 'readl'; did you mean 'd_real'? [-Werror=implicit-function-declaration]
  v = readl(aligned_addr);
      ^~~~~
      d_real
sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_write':
sound/hda/hdac_bus.c:244:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
  writel(v, aligned_addr);
  ^~~~~~

Caused by commit

  19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 9 Aug 2019 12:50:25 +1000
Subject: [PATCH] ALSA: hda: readl/writel need linux/io.h

Fixes: 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/hda/hdac_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c
index dc2523ef7d98..cd25e2b3f7f2 100644
--- a/sound/hda/hdac_bus.c
+++ b/sound/hda/hdac_bus.c
@@ -4,6 +4,7 @@
  */
 
 #include <linux/init.h>
+#include <linux/io.h>
 #include <linux/device.h>
 #include <linux/module.h>
 #include <linux/export.h>
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2019-08-09  2:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  2:54 Stephen Rothwell [this message]
2019-08-09  5:55 ` linux-next: build failure after merge of the sound tree Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2023-08-18  3:12 Stephen Rothwell
2023-08-18 11:47 ` Takashi Iwai
2023-05-24  3:54 Stephen Rothwell
2023-05-24  7:14 ` Takashi Iwai
2022-07-15 12:44 Stephen Rothwell
2022-07-15 14:41 ` Takashi Iwai
2022-07-15 19:09   ` Andy Shevchenko
2021-10-18  0:38 Stephen Rothwell
2021-10-18  6:35 ` Takashi Iwai
2020-07-17  3:01 Stephen Rothwell
2020-07-17  5:33 ` Christoph Hellwig
2020-07-17  6:34   ` Takashi Iwai
2020-07-17  6:50     ` Christoph Hellwig
2020-07-17  6:54       ` Takashi Iwai
2017-05-17  1:29 Stephen Rothwell
2017-05-17  5:30 ` Takashi Iwai
2011-09-23  2:49 Stephen Rothwell
2011-09-23  5:21 ` Takashi Iwai
2011-05-19  1:15 Stephen Rothwell
2010-09-23  2:44 Stephen Rothwell
2010-09-23  6:04 ` Takashi Iwai
2010-09-23  8:39   ` Mark Brown
2010-06-24  3:03 Stephen Rothwell
2010-06-24  6:11 ` Takashi Iwai
2010-06-28 16:33   ` Daniel Mack
2010-06-01  2:30 Stephen Rothwell
2010-06-01  5:47 ` Takashi Iwai
2010-04-07  3:39 Stephen Rothwell
2010-04-07  6:06 ` Takashi Iwai
2010-04-07  7:16   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190809125458.6c7aaa6c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.