From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA561C3A5A4 for ; Mon, 26 Aug 2019 14:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DD7E20874 for ; Mon, 26 Aug 2019 14:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566831415; bh=75uu4LHQOMkB6SQjTkZ45jR3ZFWTX8T0IVq1Jeh9hZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OH4KWAmSLxZEXfZX09t6Db/CPxVZ1mNv6B0UqSJ3jO8ruhn3PjUMGxwgnB/QCy47x VKgYr0TOg6x+YTJppaXzf8JHiXbo8kFBuaMkRAqFzbSLEAIpjjjLUrsTcZJr4onIw/ NRJxRtHSZUAP7sFbx3Mn9jee69rkgojwc+e+IyPg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732747AbfHZO4y (ORCPT ); Mon, 26 Aug 2019 10:56:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:55172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732730AbfHZO4y (ORCPT ); Mon, 26 Aug 2019 10:56:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8CA6D20679; Mon, 26 Aug 2019 14:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566831413; bh=75uu4LHQOMkB6SQjTkZ45jR3ZFWTX8T0IVq1Jeh9hZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hI6R1DsK6O9kXqrCtP6Z/9qTWWX1nw0Wq22PQvdtMbBzqRNYXHDACjoVnzEWvZKCu PWmsUmD4BmI1nTX302UJo7UKWNH/fkeMIQWHmygWiw8YB3Y5ZlS02gPSSpRX7e9BFo MbEw1em1+y5xHCVDszSOTeXbV0TVd8gGNKtMvbpU= Date: Mon, 26 Aug 2019 16:56:49 +0200 From: Greg Kroah-Hartman To: Nayna Jain Cc: linuxppc-dev@ozlabs.org, linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Ard Biesheuvel , Jeremy Kerr , Matthew Garret , Mimi Zohar , Claudio Carvalho , George Wilson , Elaine Palmer , Eric Ricther , Oliver O'Halloran Subject: Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Message-ID: <20190826145649.GA27342@kroah.com> References: <1566825818-9731-1-git-send-email-nayna@linux.ibm.com> <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote: > +static struct kobj_attribute size_attr = __ATTR_RO(size); Wait, why not just normal ATTR_RO()? > +static struct bin_attribute data_attr = __BIN_ATTR_RO(data, VARIABLE_MAX_SIZE); And BIN_ATTR_RO() here? Do those not work for you somehow? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AEAC3A59F for ; Mon, 26 Aug 2019 15:01:21 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EA9723407 for ; Mon, 26 Aug 2019 15:01:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hI6R1DsK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EA9723407 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46HFZM1MY0zDqkG for ; Tue, 27 Aug 2019 01:01:15 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46HFTS6493zDqSP for ; Tue, 27 Aug 2019 00:57:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="hI6R1DsK"; dkim-atps=neutral Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by bilbo.ozlabs.org (Postfix) with ESMTP id 46HFTQ5Wxjz8sxl for ; Tue, 27 Aug 2019 00:56:58 +1000 (AEST) Received: by ozlabs.org (Postfix) id 46HFTQ3Dbmz9sN4; Tue, 27 Aug 2019 00:56:58 +1000 (AEST) Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="hI6R1DsK"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46HFTP5mFXz9sN1; Tue, 27 Aug 2019 00:56:55 +1000 (AEST) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8CA6D20679; Mon, 26 Aug 2019 14:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566831413; bh=75uu4LHQOMkB6SQjTkZ45jR3ZFWTX8T0IVq1Jeh9hZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hI6R1DsK6O9kXqrCtP6Z/9qTWWX1nw0Wq22PQvdtMbBzqRNYXHDACjoVnzEWvZKCu PWmsUmD4BmI1nTX302UJo7UKWNH/fkeMIQWHmygWiw8YB3Y5ZlS02gPSSpRX7e9BFo MbEw1em1+y5xHCVDszSOTeXbV0TVd8gGNKtMvbpU= Date: Mon, 26 Aug 2019 16:56:49 +0200 From: Greg Kroah-Hartman To: Nayna Jain Subject: Re: [PATCH v3 2/4] powerpc: expose secure variables to userspace via sysfs Message-ID: <20190826145649.GA27342@kroah.com> References: <1566825818-9731-1-git-send-email-nayna@linux.ibm.com> <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566825818-9731-3-git-send-email-nayna@linux.ibm.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi@vger.kernel.org, Ard Biesheuvel , Eric Ricther , linux-kernel@vger.kernel.org, Mimi Zohar , Claudio Carvalho , Matthew Garret , linuxppc-dev@ozlabs.org, Paul Mackerras , Jeremy Kerr , Elaine Palmer , Oliver O'Halloran , linux-integrity@vger.kernel.org, George Wilson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Aug 26, 2019 at 09:23:36AM -0400, Nayna Jain wrote: > +static struct kobj_attribute size_attr = __ATTR_RO(size); Wait, why not just normal ATTR_RO()? > +static struct bin_attribute data_attr = __BIN_ATTR_RO(data, VARIABLE_MAX_SIZE); And BIN_ATTR_RO() here? Do those not work for you somehow? thanks, greg k-h