From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Goldwyn Rodrigues <rgoldwyn@suse.de>,
Matthew Bobrowski <mbobrowski@mbobrowski.org>
Subject: Re: [PATCH 1/2] iomap: split size and error for iomap_dio_rw ->end_io
Date: Tue, 3 Sep 2019 08:24:07 -0700 [thread overview]
Message-ID: <20190903152407.GG29434@bombadil.infradead.org> (raw)
In-Reply-To: <20190903130327.6023-2-hch@lst.de>
On Tue, Sep 03, 2019 at 03:03:26PM +0200, Christoph Hellwig wrote:
> From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
>
> Modify the calling convention for the iomap_dio_rw ->end_io() callback.
> Rather than passing either dio->error or dio->size as the 'size' argument,
> instead pass both the dio->error and the dio->size value separately.
>
> In the instance that an error occurred during a write, we currently cannot
> determine whether any blocks have been allocated beyond the current EOF and
> data has subsequently been written to these blocks within the ->end_io()
> callback. As a result, we cannot judge whether we should take the truncate
> failed write path. Having both dio->error and dio->size will allow us to
> perform such checks within this callback.
>
> Signed-off-by: Matthew Bobrowski <mbobrowski@mbobrowski.org>
> [hch: minor cleanups]
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2019-09-03 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 13:03 iomap_dio_rw ->end_io improvements Christoph Hellwig
2019-09-03 13:03 ` [PATCH 1/2] iomap: split size and error for iomap_dio_rw ->end_io Christoph Hellwig
2019-09-03 14:44 ` Darrick J. Wong
2019-09-03 15:24 ` Matthew Wilcox [this message]
2019-09-03 13:03 ` [PATCH 2/2] iomap: move the iomap_dio_rw ->end_io callback into a structure Christoph Hellwig
2019-09-03 14:46 ` Darrick J. Wong
2019-09-03 16:14 ` Matthew Wilcox
2019-09-04 12:51 ` Christoph Hellwig
2019-09-03 21:32 ` iomap_dio_rw ->end_io improvements Matthew Bobrowski
2019-09-03 22:16 ` Darrick J. Wong
2019-09-04 2:19 ` Damien Le Moal
2019-09-04 5:12 ` Christoph Hellwig
2019-09-04 11:46 ` Andreas Gruenbacher
2019-09-04 17:45 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903152407.GG29434@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.