From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, armbru@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com,
dplotnikov@virtuozzo.com, den@openvz.org
Subject: [PATCH v8 2/3] docs: define padding for qcow2 header
Date: Fri, 18 Oct 2019 12:47:57 +0300 [thread overview]
Message-ID: <20191018094758.7124-3-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20191018094758.7124-1-vsementsov@virtuozzo.com>
Header extensions ends are already defined to be multiply of 8. Let's
gently ask for header length to be a multiply of 8 too, when we have
some additional fields. Requiring this may be considered as an
incompatible change, so the padding is optional. Actually, padding is
allowed before this patch (due to definition of additional fields),
the only actual change is "SHOULD" word.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
docs/interop/qcow2.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
index 4709f3bb30..b971e59b1a 100644
--- a/docs/interop/qcow2.txt
+++ b/docs/interop/qcow2.txt
@@ -185,6 +185,11 @@ which is covered by @header_length must be zeroed.
< ... No additional fields in the header currently ... >
+Header padding
+ If @header_length is larger than 104, software SHOULD make it a
+ multiply of 8, adding zero-padding after additional fields. Still the
+ padding is optional and may be absent in the image.
+
Directly after the image header, optional sections called header extensions can
be stored. Each extension has a structure like the following:
--
2.21.0
next prev parent reply other threads:[~2019-10-18 9:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 9:47 [PATCH v8 0/3] qcow2: add zstd cluster compression Vladimir Sementsov-Ogievskiy
2019-10-18 9:47 ` [PATCH v8 1/3] docs: improve qcow2 spec about extending image header Vladimir Sementsov-Ogievskiy
2019-10-18 14:00 ` Eric Blake
2019-10-18 14:36 ` Vladimir Sementsov-Ogievskiy
2019-11-06 16:17 ` Vladimir Sementsov-Ogievskiy
2019-11-06 19:19 ` Eric Blake
2019-11-07 12:26 ` Vladimir Sementsov-Ogievskiy
2019-12-02 14:14 ` Vladimir Sementsov-Ogievskiy
2019-10-18 9:47 ` Vladimir Sementsov-Ogievskiy [this message]
2019-10-18 14:02 ` [PATCH v8 2/3] docs: define padding for qcow2 header Eric Blake
2019-10-18 14:37 ` Vladimir Sementsov-Ogievskiy
2019-10-18 9:47 ` [PATCH v8 3/3] docs: qcow2: introduce compression type feature Vladimir Sementsov-Ogievskiy
2019-10-18 14:04 ` Eric Blake
2019-10-18 14:38 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018094758.7124-3-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=dplotnikov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.