All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jamal Shareef <jamal.k.shareef@gmail.com>
Cc: outreachy-kernel@googlegroups.com, eric@anholt.net, wahrenst@gmx.net
Subject: Re: [PATCH 1/2] staging: vc04_services: Remove typedefs in vchi
Date: Thu, 31 Oct 2019 16:56:46 +0100	[thread overview]
Message-ID: <20191031155646.GB748425@kroah.com> (raw)
In-Reply-To: <c558be2e5faa156604a46f695961ebf79a5cbe26.1572513863.git.jamal.k.shareef@gmail.com>

On Thu, Oct 31, 2019 at 02:27:12AM -0700, Jamal Shareef wrote:
> Remove enum, opaque struct pointer, and function pointer typedefs from
> header files and files which include them. Issue found by checkpatch.
> 
> Remove unused API typedef in vchi_common.h because it did not allow
> patch to build.

I don't understand this sentance, why is it in the changelog?

And can you break this down into "one typedef removal per patch" please?
That makes it much easier to review and verify all is correct.

Also, one note below:
>  // Opaque handle for a VCHI instance
> -typedef struct opaque_vchi_instance_handle_t *VCHI_INSTANCE_T;
> +struct vchi_instance_h;

Why the "_h" at the end?  Shouldn't this just be:
	struct vchi_instance_handle;
?

thanks,

greg k-h


  reply	other threads:[~2019-10-31 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31  9:27 [PATCH 0/2] staging: vc04_services: Remove typedefs Jamal Shareef
2019-10-31  9:27 ` [PATCH 1/2] staging: vc04_services: Remove typedefs in vchi Jamal Shareef
2019-10-31 15:56   ` Greg KH [this message]
2019-10-31  9:27 ` [PATCH 2/2] staging: vc04_services: Remove vchiq_arm typedefs Jamal Shareef
2019-10-31  9:30   ` [Outreachy kernel] " Julia Lawall
2019-10-31 15:54     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191031155646.GB748425@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=eric@anholt.net \
    --cc=jamal.k.shareef@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.