From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iSKc9-00063p-H3 for mharc-grub-devel@gnu.org; Wed, 06 Nov 2019 07:40:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58713) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSKc6-00061E-Cu for grub-devel@gnu.org; Wed, 06 Nov 2019 07:40:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSKc5-0008Aa-8Q for grub-devel@gnu.org; Wed, 06 Nov 2019 07:40:42 -0500 Received: from twin.jikos.cz ([91.219.245.39]:53204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iSKc4-00085B-Ui for grub-devel@gnu.org; Wed, 06 Nov 2019 07:40:41 -0500 Received: from twin.jikos.cz (dave@[127.0.0.1]) by twin.jikos.cz (8.13.6/8.13.6) with ESMTP id xA6CeUVd014509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Nov 2019 13:40:31 +0100 Received: (from dave@localhost) by twin.jikos.cz (8.13.6/8.13.6/Submit) id xA6CeU2a014508; Wed, 6 Nov 2019 13:40:30 +0100 Date: Wed, 6 Nov 2019 13:40:30 +0100 From: David Sterba To: The development of GNU GRUB Subject: Re: [PATCH] btrfs: disable zstd support for i386-pc Message-ID: <20191106124030.GB9344@twin.jikos.cz> Reply-To: dave@jikos.cz References: <20191105091949.29559-1-mchang@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191105091949.29559-1-mchang@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x [fuzzy] X-Received-From: 91.219.245.39 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2019 12:40:44 -0000 On Tue, Nov 05, 2019 at 09:19:59AM +0000, Michael Chang wrote: > The zstd support in btrfs has dependenciy to zstd module and core.img > grows its size significantly to 75KB on my system. The resulted image > cannot be installed into btrfs bootloader area in the size of 64KB and > eventually fails with following message. > > /usr/sbin/grub-install: warning: your core.img is unusually large. It > won't fit in the embedding area. > /usr/sbin/grub-install: error: filesystem `btrfs' doesn't support > blocklists. > > The patch disabled the zstd support of btrfs in pc-bios platform to > avoid the regression. The resulting size is 56KB, albeit a bit too close > to the 64KB but works. This is simple workaround until a proper fix > landed upstream. So combination zstd+btrfs+i386-pc never worked? Removing support for zstd could lead to unbootable system, but if that has never worked before it'd be ok to make the build conditional. Looking at zstd code, does not seem to be easy to squeeze the asm to something like 64-56=8K.