From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CF0C5DF60 for ; Thu, 7 Nov 2019 15:09:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72F4B218AE for ; Thu, 7 Nov 2019 15:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573139360; bh=/h8t53roPI/rD/uP7zadW263zkJUzQG8YPGxa8rn2JI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XvybJ+Owq1JgrcZoVzkusl8PAY61TKnCGq0VSMMuROlOxPQDGI54xla8jsfNRiKGW bf1/cQkHDPb1dVfynd2t8t3qY+pk7Up/hmF0WP19OxOJ3eA2VOUNF/VxZ5UsNwdKwe IiSgc2vU5PaW7Upoy4QwIq1PlwF2Ky6pYKtDJP5U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389113AbfKGPJT (ORCPT ); Thu, 7 Nov 2019 10:09:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:34202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388317AbfKGPJT (ORCPT ); Thu, 7 Nov 2019 10:09:19 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F10C21D6C; Thu, 7 Nov 2019 15:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573139358; bh=/h8t53roPI/rD/uP7zadW263zkJUzQG8YPGxa8rn2JI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=anqJp2lFyBxbvu8u/SzWDi+z7rQPRJQwmfoN3ZvB1yBHZlHf/veVg86iN31mSKYuB 1GmDwTCnA4w1Kmh2z/lX0ctooio9LzAt5PXLqDIsS5HfAuDzEf0pw/hyIRYKhOqqBX fkYSi6kOVliw/u1hUYNM7KgrrhU1cWIwT9vjKbKE= Date: Thu, 7 Nov 2019 16:09:16 +0100 From: Greg KH To: Joe Perches Cc: Valery Ivanov , rspringer@google.com, toddpoynor@google.com, benchan@chromium.org, Simon Que , John Joseph , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature Message-ID: <20191107150916.GB154681@kroah.com> References: <20191106180821.GA19385@hwsrv-485799.hostwindsdns.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 11:12:09AM -0800, Joe Perches wrote: > On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote: > > This patch fix the function signature for trace_gasket_ioctl_page_table_data > > to avoid the checkpatch.pl warning: > > > > CHECK: Lines should not end with a '(' > > > > Signed-off-by: Valery Ivanov > > All of this stuff is no-op and could just as easily be removed > completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere. > > Is the actual trace #include file supposed to be available somewhere? > > #ifdef GASKET_KERNEL_TRACE_SUPPORT > #define CREATE_TRACE_POINTS > #include > #else > #define trace_gasket_ioctl_entry(x, ...) > #define trace_gasket_ioctl_exit(x) > #define trace_gasket_ioctl_integer_data(x) > #define trace_gasket_ioctl_eventfd_data(x, ...) > #define trace_gasket_ioctl_page_table_data(x, ...) > #define trace_gasket_ioctl_config_coherent_allocator(x, ...) > #endif > > trace file not found... I'm thinking the whole gasket driver should be deleted as there has not been any effort done to fix it up and get it out of staging. I'll give it until 5.5 before I drop it... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A978AC5DF60 for ; Thu, 7 Nov 2019 15:09:25 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A882218AE for ; Thu, 7 Nov 2019 15:09:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="anqJp2lF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A882218AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3CE4B859EF; Thu, 7 Nov 2019 15:09:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XCrQ0q2Wm-z7; Thu, 7 Nov 2019 15:09:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7FD17857CB; Thu, 7 Nov 2019 15:09:23 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5F11F1BF340 for ; Thu, 7 Nov 2019 15:09:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 593D785B8D for ; Thu, 7 Nov 2019 15:09:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lRr5Gkf3JScF for ; Thu, 7 Nov 2019 15:09:18 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id CC5FB85692 for ; Thu, 7 Nov 2019 15:09:18 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F10C21D6C; Thu, 7 Nov 2019 15:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573139358; bh=/h8t53roPI/rD/uP7zadW263zkJUzQG8YPGxa8rn2JI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=anqJp2lFyBxbvu8u/SzWDi+z7rQPRJQwmfoN3ZvB1yBHZlHf/veVg86iN31mSKYuB 1GmDwTCnA4w1Kmh2z/lX0ctooio9LzAt5PXLqDIsS5HfAuDzEf0pw/hyIRYKhOqqBX fkYSi6kOVliw/u1hUYNM7KgrrhU1cWIwT9vjKbKE= Date: Thu, 7 Nov 2019 16:09:16 +0100 From: Greg KH To: Joe Perches Subject: Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature Message-ID: <20191107150916.GB154681@kroah.com> References: <20191106180821.GA19385@hwsrv-485799.hostwindsdns.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, John Joseph , linux-kernel@vger.kernel.org, Simon Que , rspringer@google.com, Valery Ivanov , toddpoynor@google.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Nov 06, 2019 at 11:12:09AM -0800, Joe Perches wrote: > On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote: > > This patch fix the function signature for trace_gasket_ioctl_page_table_data > > to avoid the checkpatch.pl warning: > > > > CHECK: Lines should not end with a '(' > > > > Signed-off-by: Valery Ivanov > > All of this stuff is no-op and could just as easily be removed > completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere. > > Is the actual trace #include file supposed to be available somewhere? > > #ifdef GASKET_KERNEL_TRACE_SUPPORT > #define CREATE_TRACE_POINTS > #include > #else > #define trace_gasket_ioctl_entry(x, ...) > #define trace_gasket_ioctl_exit(x) > #define trace_gasket_ioctl_integer_data(x) > #define trace_gasket_ioctl_eventfd_data(x, ...) > #define trace_gasket_ioctl_page_table_data(x, ...) > #define trace_gasket_ioctl_config_coherent_allocator(x, ...) > #endif > > trace file not found... I'm thinking the whole gasket driver should be deleted as there has not been any effort done to fix it up and get it out of staging. I'll give it until 5.5 before I drop it... thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel