From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: [PATCH] configure: Check bzip2 is available
Date: Fri, 8 Nov 2019 11:28:05 +0100 [thread overview]
Message-ID: <20191108102805.8258-1-philmd@redhat.com> (raw)
The bzip2 tool is not included in default installations.
On freshly installed systems, ./configure succeeds but 'make'
might fail later:
BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2
/bin/sh: bzip2: command not found
make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127
make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd'
make: *** Waiting for unfinished jobs....
Add a check in ./configure to warn the user if bzip2 is missing.
Fixes: 536d2173b2b
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
configure | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/configure b/configure
index efe165edf9..9957e913e8 100755
--- a/configure
+++ b/configure
@@ -1851,6 +1851,13 @@ python_version=$($python -c 'import sys; print("%d.%d.%d" % (sys.version_info[0]
# Suppress writing compiled files
python="$python -B"
+# Some firmware binaries are compressed with bzip2
+if has bzip2; then
+ :
+else
+ error_exit "bzip2 program not found. Please install it"
+fi
+
# Check that the C compiler works. Doing this here before testing
# the host CPU ensures that we had a valid CC to autodetect the
# $cpu var (and we should bail right here if that's not the case).
--
2.21.0
next reply other threads:[~2019-11-08 10:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 10:28 Philippe Mathieu-Daudé [this message]
2019-11-08 10:31 ` [PATCH] configure: Check bzip2 is available Daniel P. Berrangé
2019-11-08 10:34 ` Thomas Huth
2019-11-08 10:42 ` Philippe Mathieu-Daudé
2019-11-08 11:39 ` Laszlo Ersek
2019-11-08 11:58 ` Philippe Mathieu-Daudé
2019-11-08 12:03 ` Thomas Huth
2019-11-08 11:01 ` Laszlo Ersek
2019-11-08 11:05 ` Daniel P. Berrangé
2019-11-08 11:54 ` Philippe Mathieu-Daudé
2019-11-08 11:57 ` Thomas Huth
2019-11-08 15:43 ` Eric Blake
2019-11-08 17:07 ` Philippe Mathieu-Daudé
2019-11-08 17:10 ` Peter Maydell
2019-11-11 11:51 ` Thomas Huth
2019-11-11 13:33 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108102805.8258-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.