From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=R4X1=Z5=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 34595C43603
	for <netdev@archiver.kernel.org>; Sat,  7 Dec 2019 11:55:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E821F24677
	for <netdev@archiver.kernel.org>; Sat,  7 Dec 2019 11:55:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1575719706;
	bh=G8sWODe3m9KgcYiOVAUre5nxdNZnIw9Agsw5BxV9Btg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=n3Tr4A4a9No/byEzzgKc5gVCvBGVKmtpL/yXaunSRryUjRcFFqckgN6r7EGtmDQ5S
	 vjJ8O7NUBRKN+V1SCZDxnXB+7T6E70FvC/6Y/EeXmZqMjBA9UCWMckDCGV6hwFA3mC
	 30k1ror1CLJRNugZGYqZsEWR4wQ13XeD3QfXCilI=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726378AbfLGLzF (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 7 Dec 2019 06:55:05 -0500
Received: from mail.kernel.org ([198.145.29.99]:60030 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726025AbfLGLzE (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 7 Dec 2019 06:55:04 -0500
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id B0F7824673;
        Sat,  7 Dec 2019 11:55:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1575719704;
        bh=G8sWODe3m9KgcYiOVAUre5nxdNZnIw9Agsw5BxV9Btg=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=yqvwvdKWAfKnsRrx5thLfJ7bWBMpk1XcAn0BLK0bMC1JYRTk//g0+cVyso4yVWGwp
         kJxXPxYaEf3w3rQECIABTAbNQnrsiZ0KQuUVILAbR+PO+iegWtIjN5fW/eH94N99j0
         XbFzxFpuMrFOdTa0hSN9ZqlUea4hiWyqDDzFh1AQ=
Date:   Sat, 7 Dec 2019 12:55:01 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Eric Dumazet <edumazet@google.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Yuchung Cheng <ycheng@google.com>,
        Neal Cardwell <ncardwell@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH v4.14] tcp: exit if nothing to retransmit on RTO timeout
Message-ID: <20191207115501.GA325082@kroah.com>
References: <20191206182016.137529-1-edumazet@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191206182016.137529-1-edumazet@google.com>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, Dec 06, 2019 at 10:20:16AM -0800, Eric Dumazet wrote:
> Two upstream commits squashed together for v4.14 stable :
> 
>  commit 88f8598d0a302a08380eadefd09b9f5cb1c4c428 upstream.
> 
>   Previously TCP only warns if its RTO timer fires and the
>   retransmission queue is empty, but it'll cause null pointer
>   reference later on. It's better to avoid such catastrophic failure
>   and simply exit with a warning.
> 
> Squashed with "tcp: refactor tcp_retransmit_timer()" :
> 
>  commit 0d580fbd2db084a5c96ee9c00492236a279d5e0f upstream.

Note, this commit is only in Dave's tree, not stable just yet.  I'll
queue this up now, but I'm expecting that commit will come in to the
stable trees through the "normal" stable networking process.

thanks,

greg k-h