From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98129C43603 for ; Wed, 11 Dec 2019 15:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F26B208C3 for ; Wed, 11 Dec 2019 15:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077985; bh=NZwHU/3735iugvdYsyLllWoIe3H0BfykBG6HE1i6ty0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kGdo2HWl1gTOCibl0YzLQ7Eiv3rd8sMQVLs3wANmGL5XxoOimPpnPoH1Ee3WHScdw 54Xnqjl6aU5Hvb/H8UX0EPxTk2M210Lb4CLZU5P7NwI6OEAFL7FSU//oM5NnMFhPvO msaknLEX6XEaQu76htM4EruXMyoLzwoZxdDykl8g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733117AbfLKP0Y (ORCPT ); Wed, 11 Dec 2019 10:26:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:59592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732965AbfLKP0V (ORCPT ); Wed, 11 Dec 2019 10:26:21 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAB4922527; Wed, 11 Dec 2019 15:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077981; bh=NZwHU/3735iugvdYsyLllWoIe3H0BfykBG6HE1i6ty0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iFcDxJvwJlx/qM/LZ2t3zvQgA2l0YiGVYXHBEFtUg2Ez/CbLZ9G5+OgFVdr5BPOZj D03nhydvTqDXSe/0vyO8DKQRXhnwB89OgolSNUnEE2GuQuWyXmne4uoBFLHEqF2Iju AfON8ESlLyam9CYiV30YnFvWSjR4BWPZhiNMtvIg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ayush Sawal , Atul Gupta , Herbert Xu Subject: [PATCH 4.19 231/243] crypto: af_alg - cast ki_complete ternary op to int Date: Wed, 11 Dec 2019 16:06:33 +0100 Message-Id: <20191211150354.927140672@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150339.185439726@linuxfoundation.org> References: <20191211150339.185439726@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ayush Sawal commit 64e7f852c47ce99f6c324c46d6a299a5a7ebead9 upstream. when libkcapi test is executed using HW accelerator, cipher operation return -74.Since af_alg_async_cb->ki_complete treat err as unsigned int, libkcapi receive 429467222 even though it expect -ve value. Hence its required to cast resultlen to int so that proper error is returned to libkcapi. AEAD one shot non-aligned test 2(libkcapi test) ./../bin/kcapi -x 10 -c "gcm(aes)" -i 7815d4b06ae50c9c56e87bd7 -k ea38ac0c9b9998c80e28fb496a2b88d9 -a "853f98a750098bec1aa7497e979e78098155c877879556bb51ddeb6374cbaefc" -t "c4ce58985b7203094be1d134c1b8ab0b" -q "b03692f86d1b8b39baf2abb255197c98" Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management") Cc: Signed-off-by: Ayush Sawal Signed-off-by: Atul Gupta Signed-off-by: Herbert Xu Signed-off-by: Ayush Sawal Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/af_alg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -1058,7 +1058,7 @@ void af_alg_async_cb(struct crypto_async af_alg_free_resources(areq); sock_put(sk); - iocb->ki_complete(iocb, err ? err : resultlen, 0); + iocb->ki_complete(iocb, err ? err : (int)resultlen, 0); } EXPORT_SYMBOL_GPL(af_alg_async_cb);