All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephane Eranian <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users <linux-perf-users@vger.kernel.org>,
	Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCHSET 0/9] perf: Improve cgroup profiling (v3)
Date: Thu, 26 Dec 2019 09:46:59 -0300	[thread overview]
Message-ID: <20191226124659.GA20204@kernel.org> (raw)
In-Reply-To: <CAM9d7cj06Hj3hOSdcyTpRWaoBY0wLjPpt7_+CbUqtsF-_08Czg@mail.gmail.com>

Em Tue, Dec 24, 2019 at 09:40:04AM +0900, Namhyung Kim escreveu:
> On Tue, Dec 24, 2019 at 2:35 AM Vince Weaver <vincent.weaver@maine.edu> wrote:
> > On Mon, 23 Dec 2019, Namhyung Kim wrote:
> > > This work is to improve cgroup profiling in perf.  Currently it only
> > > supports profiling tasks in a specific cgroup and there's no way to
> > > identify which cgroup the current sample belongs to.  So I added
> > > PERF_SAMPLE_CGROUP to add cgroup id into each sample.  It's a 64-bit
> > > integer having file handle of the cgroup.  And kernel also generates
> > > PERF_RECORD_CGROUP event for new groups to correlate the cgroup id and
> > > cgroup name (path in the cgroup filesystem).  The cgroup id can be
> > > read from userspace by name_to_handle_at() system call so it can
> > > synthesize the CGROUP event for existing groups.

> > so is there a patch to the manpage that describes this new behavior in
> > perf_event_open()?

> Not yet.  I'll cook a patch once it's merged to the Linus' tree.

Vince, was it ever considered to carry the man page in the kernel
sources and then make it so that new features need to come with the
respective changes to the man page? I think that would be a good move,
you would be the maintainer for that file, what do you think?

- Arnaldo

  reply	other threads:[~2019-12-26 12:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23  6:07 [PATCHSET 0/9] perf: Improve cgroup profiling (v3) Namhyung Kim
2019-12-23  6:07 ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Namhyung Kim
2019-12-27  4:07   ` kbuild test robot
2019-12-27  4:07   ` [RFC PATCH] perf/core: perf_event_cgroup() can be static kbuild test robot
2020-01-07 12:51   ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Peter Zijlstra
2020-01-07 13:46     ` Namhyung Kim
2019-12-23  6:07 ` [PATCH 2/9] perf/core: Add PERF_SAMPLE_CGROUP feature Namhyung Kim
2019-12-23  6:07 ` [PATCH 3/9] perf tools: Basic support for CGROUP event Namhyung Kim
2019-12-23  6:07 ` [PATCH 4/9] perf tools: Maintain cgroup hierarchy Namhyung Kim
2019-12-23  6:07 ` [PATCH 5/9] perf report: Add 'cgroup' sort key Namhyung Kim
2019-12-23  6:07 ` [PATCH 6/9] perf record: Support synthesizing cgroup events Namhyung Kim
2019-12-23  6:07 ` [PATCH 7/9] perf record: Add --all-cgroups option Namhyung Kim
2019-12-23  6:07 ` [PATCH 8/9] perf top: " Namhyung Kim
2019-12-23  6:07 ` [PATCH 9/9] perf script: Add --show-cgroup-events option Namhyung Kim
2019-12-23 17:35 ` [PATCHSET 0/9] perf: Improve cgroup profiling (v3) Vince Weaver
2019-12-24  0:40   ` Namhyung Kim
2019-12-26 12:46     ` Arnaldo Carvalho de Melo [this message]
2019-12-27 18:31       ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191226124659.GA20204@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tj@kernel.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.