From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CEE0C33CA9 for ; Mon, 13 Jan 2020 17:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30B16207FF for ; Mon, 13 Jan 2020 17:45:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OUz1zbml" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728712AbgAMRpT (ORCPT ); Mon, 13 Jan 2020 12:45:19 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:21369 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726109AbgAMRpT (ORCPT ); Mon, 13 Jan 2020 12:45:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578937517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZjupOVr34zDecwnMFqtNXPvApC4Q2OCWXOaNuSUosdM=; b=OUz1zbmlFyfKsy8aq822AesXDhNIiPxfF1FYRsN4aVwyfhKj1G84GIIz/2GbKoQ/llDCDs r4RXzfDvHX1TPgzdK5XUxyCPJSrzWbargUL4Azqsy8a8R1KP9nMFmaqWBA5fVBX1HCpKVR eJfZhso//FywyCGUBQIHwbxVy5EgnLs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-EQyERcpHO2KS3VKae6uwbg-1; Mon, 13 Jan 2020 12:45:14 -0500 X-MC-Unique: EQyERcpHO2KS3VKae6uwbg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 43FE018B9FC1; Mon, 13 Jan 2020 17:45:10 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FB418886A; Mon, 13 Jan 2020 17:44:59 +0000 (UTC) Date: Mon, 13 Jan 2020 18:44:57 +0100 From: Andrew Jones To: Eric Auger Cc: eric.auger.pro@gmail.com, maz@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, peter.maydell@linaro.org, yuzenghui@huawei.com, alexandru.elisei@arm.com, thuth@redhat.com Subject: Re: [kvm-unit-tests PATCH v2 09/16] arm/arm64: ITS: Enable/Disable LPIs at re-distributor level Message-ID: <20200113174457.gg35yyeaftbadqki@kamzik.brq.redhat.com> References: <20200110145412.14937-1-eric.auger@redhat.com> <20200110145412.14937-10-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110145412.14937-10-eric.auger@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jan 10, 2020 at 03:54:05PM +0100, Eric Auger wrote: > This helper function enables or disables the signaling of LPIs > at redistributor level. > > Signed-off-by: Eric Auger > --- > lib/arm/asm/gic-v3-its.h | 1 + > lib/arm/gic-v3-its.c | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/lib/arm/asm/gic-v3-its.h b/lib/arm/asm/gic-v3-its.h > index 93814f7..d2db292 100644 > --- a/lib/arm/asm/gic-v3-its.h > +++ b/lib/arm/asm/gic-v3-its.h > @@ -99,6 +99,7 @@ extern struct its_baser *its_lookup_baser(int type); > extern void set_lpi_config(int n, u8 val); > extern u8 get_lpi_config(int n); > extern void set_pending_table_bit(int rdist, int n, bool set); > +extern void gicv3_rdist_ctrl_lpi(u32 redist, bool set); > > #endif /* !__ASSEMBLY__ */ > #endif /* _ASMARM_GIC_V3_ITS_H_ */ > diff --git a/lib/arm/gic-v3-its.c b/lib/arm/gic-v3-its.c > index 3037c84..c7c6f80 100644 > --- a/lib/arm/gic-v3-its.c > +++ b/lib/arm/gic-v3-its.c > @@ -199,3 +199,21 @@ void init_cmd_queue(void) > its_data.cmd_write = its_data.cmd_base; > writeq(0, its_data.base + GITS_CWRITER); > } > + > +void gicv3_rdist_ctrl_lpi(u32 redist, bool set) > +{ > + void *ptr; > + u64 val; > + > + if (redist >= nr_cpus) > + report_abort("%s redist=%d >= cpu_count=%d\n", > + __func__, redist, nr_cpus); I'd use {} here because of the multiline call. But, we don't use the report API in common code. Well, apparently s390 has report calls in lib/s390x/interrupt.c, but I don't really agree with that. IMO, common code failures should always be unexpected and just assert/assert_msg. > + > + ptr = gicv3_data.redist_base[redist]; > + val = readl(ptr + GICR_CTLR); > + if (set) > + val |= GICR_CTLR_ENABLE_LPIS; > + else > + val &= ~GICR_CTLR_ENABLE_LPIS; > + writel(val, ptr + GICR_CTLR); > +} > -- > 2.20.1 > Also, you can squash this patch into whatever is going to make use of this new helper. Thanks, drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C082C33CA9 for ; Mon, 13 Jan 2020 17:46:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36EA9207FF for ; Mon, 13 Jan 2020 17:46:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OUz1zbml" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36EA9207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3nT-00072i-3d for qemu-devel@archiver.kernel.org; Mon, 13 Jan 2020 12:46:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43965) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3mC-00065B-Ic for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:45:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir3mB-0004MW-56 for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:45:20 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:43617 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ir3mA-0004Km-VL for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:45:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578937517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZjupOVr34zDecwnMFqtNXPvApC4Q2OCWXOaNuSUosdM=; b=OUz1zbmlFyfKsy8aq822AesXDhNIiPxfF1FYRsN4aVwyfhKj1G84GIIz/2GbKoQ/llDCDs r4RXzfDvHX1TPgzdK5XUxyCPJSrzWbargUL4Azqsy8a8R1KP9nMFmaqWBA5fVBX1HCpKVR eJfZhso//FywyCGUBQIHwbxVy5EgnLs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-EQyERcpHO2KS3VKae6uwbg-1; Mon, 13 Jan 2020 12:45:14 -0500 X-MC-Unique: EQyERcpHO2KS3VKae6uwbg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 43FE018B9FC1; Mon, 13 Jan 2020 17:45:10 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FB418886A; Mon, 13 Jan 2020 17:44:59 +0000 (UTC) Date: Mon, 13 Jan 2020 18:44:57 +0100 From: Andrew Jones To: Eric Auger Subject: Re: [kvm-unit-tests PATCH v2 09/16] arm/arm64: ITS: Enable/Disable LPIs at re-distributor level Message-ID: <20200113174457.gg35yyeaftbadqki@kamzik.brq.redhat.com> References: <20200110145412.14937-1-eric.auger@redhat.com> <20200110145412.14937-10-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110145412.14937-10-eric.auger@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, thuth@redhat.com, kvm@vger.kernel.org, maz@kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, yuzenghui@huawei.com, alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jan 10, 2020 at 03:54:05PM +0100, Eric Auger wrote: > This helper function enables or disables the signaling of LPIs > at redistributor level. > > Signed-off-by: Eric Auger > --- > lib/arm/asm/gic-v3-its.h | 1 + > lib/arm/gic-v3-its.c | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/lib/arm/asm/gic-v3-its.h b/lib/arm/asm/gic-v3-its.h > index 93814f7..d2db292 100644 > --- a/lib/arm/asm/gic-v3-its.h > +++ b/lib/arm/asm/gic-v3-its.h > @@ -99,6 +99,7 @@ extern struct its_baser *its_lookup_baser(int type); > extern void set_lpi_config(int n, u8 val); > extern u8 get_lpi_config(int n); > extern void set_pending_table_bit(int rdist, int n, bool set); > +extern void gicv3_rdist_ctrl_lpi(u32 redist, bool set); > > #endif /* !__ASSEMBLY__ */ > #endif /* _ASMARM_GIC_V3_ITS_H_ */ > diff --git a/lib/arm/gic-v3-its.c b/lib/arm/gic-v3-its.c > index 3037c84..c7c6f80 100644 > --- a/lib/arm/gic-v3-its.c > +++ b/lib/arm/gic-v3-its.c > @@ -199,3 +199,21 @@ void init_cmd_queue(void) > its_data.cmd_write = its_data.cmd_base; > writeq(0, its_data.base + GITS_CWRITER); > } > + > +void gicv3_rdist_ctrl_lpi(u32 redist, bool set) > +{ > + void *ptr; > + u64 val; > + > + if (redist >= nr_cpus) > + report_abort("%s redist=%d >= cpu_count=%d\n", > + __func__, redist, nr_cpus); I'd use {} here because of the multiline call. But, we don't use the report API in common code. Well, apparently s390 has report calls in lib/s390x/interrupt.c, but I don't really agree with that. IMO, common code failures should always be unexpected and just assert/assert_msg. > + > + ptr = gicv3_data.redist_base[redist]; > + val = readl(ptr + GICR_CTLR); > + if (set) > + val |= GICR_CTLR_ENABLE_LPIS; > + else > + val &= ~GICR_CTLR_ENABLE_LPIS; > + writel(val, ptr + GICR_CTLR); > +} > -- > 2.20.1 > Also, you can squash this patch into whatever is going to make use of this new helper. Thanks, drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 727B0C33CA9 for ; Mon, 13 Jan 2020 17:45:22 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id F3B0D207FF for ; Mon, 13 Jan 2020 17:45:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XZVEAag0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3B0D207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 700DC4AF28; Mon, 13 Jan 2020 12:45:21 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XdFCvR+EIKdg; Mon, 13 Jan 2020 12:45:20 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5F4FD4AF20; Mon, 13 Jan 2020 12:45:20 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5DE9A4AF1E for ; Mon, 13 Jan 2020 12:45:19 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Eactxp6R1IyP for ; Mon, 13 Jan 2020 12:45:18 -0500 (EST) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 69A9B4AF1D for ; Mon, 13 Jan 2020 12:45:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578937518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZjupOVr34zDecwnMFqtNXPvApC4Q2OCWXOaNuSUosdM=; b=XZVEAag03/tiqHDFVndvaz9+whL6gJBJTatYbgEfGpQH/qCEVgoc4xwZCjnN53zqVO1q1E ak4esKf9/u83JwkGIut/0V6JjGKcruq1oRTJMczgOlzOfMg0fqgKjeOiV7wb7sIJaLgoIP UpRhdCAC8cDYQne+ojZzDwLhTxtsyFI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-EQyERcpHO2KS3VKae6uwbg-1; Mon, 13 Jan 2020 12:45:14 -0500 X-MC-Unique: EQyERcpHO2KS3VKae6uwbg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 43FE018B9FC1; Mon, 13 Jan 2020 17:45:10 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FB418886A; Mon, 13 Jan 2020 17:44:59 +0000 (UTC) Date: Mon, 13 Jan 2020 18:44:57 +0100 From: Andrew Jones To: Eric Auger Subject: Re: [kvm-unit-tests PATCH v2 09/16] arm/arm64: ITS: Enable/Disable LPIs at re-distributor level Message-ID: <20200113174457.gg35yyeaftbadqki@kamzik.brq.redhat.com> References: <20200110145412.14937-1-eric.auger@redhat.com> <20200110145412.14937-10-eric.auger@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200110145412.14937-10-eric.auger@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Cc: thuth@redhat.com, kvm@vger.kernel.org, maz@kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jan 10, 2020 at 03:54:05PM +0100, Eric Auger wrote: > This helper function enables or disables the signaling of LPIs > at redistributor level. > > Signed-off-by: Eric Auger > --- > lib/arm/asm/gic-v3-its.h | 1 + > lib/arm/gic-v3-its.c | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/lib/arm/asm/gic-v3-its.h b/lib/arm/asm/gic-v3-its.h > index 93814f7..d2db292 100644 > --- a/lib/arm/asm/gic-v3-its.h > +++ b/lib/arm/asm/gic-v3-its.h > @@ -99,6 +99,7 @@ extern struct its_baser *its_lookup_baser(int type); > extern void set_lpi_config(int n, u8 val); > extern u8 get_lpi_config(int n); > extern void set_pending_table_bit(int rdist, int n, bool set); > +extern void gicv3_rdist_ctrl_lpi(u32 redist, bool set); > > #endif /* !__ASSEMBLY__ */ > #endif /* _ASMARM_GIC_V3_ITS_H_ */ > diff --git a/lib/arm/gic-v3-its.c b/lib/arm/gic-v3-its.c > index 3037c84..c7c6f80 100644 > --- a/lib/arm/gic-v3-its.c > +++ b/lib/arm/gic-v3-its.c > @@ -199,3 +199,21 @@ void init_cmd_queue(void) > its_data.cmd_write = its_data.cmd_base; > writeq(0, its_data.base + GITS_CWRITER); > } > + > +void gicv3_rdist_ctrl_lpi(u32 redist, bool set) > +{ > + void *ptr; > + u64 val; > + > + if (redist >= nr_cpus) > + report_abort("%s redist=%d >= cpu_count=%d\n", > + __func__, redist, nr_cpus); I'd use {} here because of the multiline call. But, we don't use the report API in common code. Well, apparently s390 has report calls in lib/s390x/interrupt.c, but I don't really agree with that. IMO, common code failures should always be unexpected and just assert/assert_msg. > + > + ptr = gicv3_data.redist_base[redist]; > + val = readl(ptr + GICR_CTLR); > + if (set) > + val |= GICR_CTLR_ENABLE_LPIS; > + else > + val &= ~GICR_CTLR_ENABLE_LPIS; > + writel(val, ptr + GICR_CTLR); > +} > -- > 2.20.1 > Also, you can squash this patch into whatever is going to make use of this new helper. Thanks, drew _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm