From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default Date: Fri, 17 Jan 2020 00:59:51 +0100 Message-ID: <20200116235951.GD8400@dvetter-linux.ger.corp.intel.com> References: <20200115125226.13843-1-tzimmermann@suse.de> <20200115125226.13843-5-tzimmermann@suse.de> <20200116064107.GB8400@dvetter-linux.ger.corp.intel.com> <33fdd33f-ce8d-70d3-544e-fac727d2686b@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Emil Velikov Cc: Laurent Pinchart , Thomas Zimmermann , oleksandr_andrushchenko@epam.com, Dave Airlie , Sean Paul , ML dri-devel , "open list:VIRTIO GPU DRIVER" , Hans de Goede , Gerd Hoffmann , Daniel Vetter , xen-devel@lists.xenproject.org, Emil Velikov , Sam Ravnborg , david@lechnology.com List-Id: virtualization@lists.linuxfoundation.org T24gVGh1LCBKYW4gMTYsIDIwMjAgYXQgMDU6MjI6MzRQTSArMDAwMCwgRW1pbCBWZWxpa292IHdy b3RlOgo+IEhpIGFsbCwKPiAKPiBPbiBUaHUsIDE2IEphbiAyMDIwIGF0IDA3OjM3LCBUaG9tYXMg WmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4gd3JvdGU6Cj4gCj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19zdGF0ZV9oZWxwZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jCj4gPiA+IGluZGV4IDdjZjNjZjkzNjU0 Ny4uMjNkMmY1MWZjMWQ0IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19zdGF0ZV9oZWxwZXIuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21p Y19zdGF0ZV9oZWxwZXIuYwo+ID4gPiBAQCAtMTQ5LDYgKzE0OSwxMSBAQCB2b2lkIF9fZHJtX2F0 b21pY19oZWxwZXJfY3J0Y19kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ ID4gPiAgICAgICAvKiBTZWxmIHJlZnJlc2ggc2hvdWxkIGJlIGNhbmNlbGVkIHdoZW4gYSBuZXcg dXBkYXRlIGlzIGF2YWlsYWJsZSAqLwo+ID4gPiAgICAgICBzdGF0ZS0+YWN0aXZlID0gZHJtX2F0 b21pY19jcnRjX2VmZmVjdGl2ZWx5X2FjdGl2ZShzdGF0ZSk7Cj4gPiA+ICAgICAgIHN0YXRlLT5z ZWxmX3JlZnJlc2hfYWN0aXZlID0gZmFsc2U7Cj4gPiA+ICsKPiA+ID4gKyAgICAgaWYgKGRybV9k ZXZfaGFzX3ZibGFuayhjcnRjLT5kZXYpKQo+ID4gPiArICAgICAgICAgICAgIHN0YXRlLT5ub192 YmxhbmsgPSB0cnVlOwo+ID4gPiArICAgICBlbHNlCj4gPiA+ICsgICAgICAgICAgICAgc3RhdGUt Pm5vX3ZibGFuayA9IGZhbHNlOwo+ID4gPiAgfQo+ID4gPiAgRVhQT1JUX1NZTUJPTChfX2RybV9h dG9taWNfaGVscGVyX2NydGNfZHVwbGljYXRlX3N0YXRlKTsKPiA+Cj4gPiBJIHRoaW5rIHRoZSBp Zi9lbHNlIGJyYW5jaGVzIGFyZSBpbiB0aGUgd3Jvbmcgb3JkZXIuCgpZZWFoIGZ1bWJsZWQgdGhh dC4KCj4gPiBCdXQgZ2VuZXJhbGx5IHNwZWFraW5nLCBpcyBpdCByZWFsbHkgdGhhdCBlYXN5PyBU aGUgeGVuIGRyaXZlciBhbHJlYWR5Cj4gPiBoYXMgdG8gd29yayBhcm91bmQgc2ltcGxlLWttcydz IGF1dG8tZW5hYmxpbmcgb2Ygbm9fdmJsYW5rIChzZWUgcGF0Y2gKPiA+IDQpLiBNYXliZSB0aGlz IHNldHRpbmdzIGludGVyZmVyZXMgd2l0aCBvdGhlciBkcml2ZXJzIGFzIHdlbGwuIEF0IGxlYXN0 Cj4gPiB0aGUgY2FsbHMgZm9yIHNlbmRpbmcgZmFrZSB2YmxhbmtzIHNob3VsZCBiZSByZW1vdmVk IGZyb20gYWxsIGFmZmVjdGVkCj4gPiBkcml2ZXJzLgoKSG0geGVuIGlzIHJlYWxseSBzcGVjaWFs LCBpbiB0aGF0IGl0IGhhcyBhIGZsaXAgY29tcGxldGUgZXZlbnQsIGJ1dCBub3QgYQp2Ymxhbmsu IEkgdGhpbmsgZm9yY2luZyBkcml2ZXJzIHRvIG92ZXJ3cml0ZSBzdHVmZiBpbiB0aGF0IGNhc2Ug bWFrZXMKc2Vuc2UuCgo+IEknbSBub3Qgc3VyZSBpZiBzZXR0aW5nIG5vX3ZibGFuayBiYXNlZCBv biBkZXYtPm51bV9jcnRjcyBpcyB0aGUgY29ycmVjdCB0aGluZy4KPiBGcm9tIHRoZSBvcmlnaW5h bCBjb21taXQgYW5kIGFzc29jaWF0ZWQgZGVzY3JpcHRpb24gZm9yIG5vX3ZibGFuazoKPiAKPiBJ biBzb21lIGNhc2VzIENSVENzIGFyZSBhY3RpdmUgYnV0IGFyZSBub3QgYWJsZSB0byBnZW5lcmF0 aW5nIGV2ZW50cywgYXQKPiBsZWFzdCBub3QgYXQgZXZlcnkgZnJhbWUgYXQgaXQncyBleHBlY3Rl ZCB0by4KPiBUaGlzIGlzIHR5cGljYWxseSB0aGUgY2FzZSB3aGVuIHRoZSBDUlRDIGlzIGZlZWRp bmcgYSB3cml0ZWJhY2sgY29ubmVjdG9yLi4uCgpZZWFoLCBidXQgVGhvbWFzJyBzZXJpZXMgaGVy ZSB3YW50cyB0byBleHRlbmQgdGhhdC4gQW5kIEkgdGhpbmsgaWYgd2Ugcm9sbAp0aGlzIG91dCB0 aGUgY29tbW9uIGNhc2Ugd2lsbCBiZSAibm8gaHcgdmJsYW5rIiwgYW5kIHRoZSB3cml0ZWJhY2sg c3BlY2lhbApjYXNlIGlzIGdvaW5nIHRvIGJlIHRoZSBleGNlcHRpb24gdG8gdGhlIGV4Y2VwdGlv bi4gWXVwLCBwYXRjaCAxIHRoYXQKdXBkYXRlcyB0aGUgZG9jcyBkb2Vzbid0IHJlZmxlY3QgdGhh dCwgd2hpY2ggaXMgd2h5IEknbSBicmluZ2luZyB1cCBtb3JlCnN1Z2dlc3Rpb25zIGhlcmUgYXJv dW5kIGNvZGUgJiBzZW1hbnRpY3Mgb2YgYWxsIHRoZXNlIHBpZWNlcyB0byBtYWtlIHRoZW0KZG8g dGhlIG1vc3QgcmVhc29uYWJsZSB0aGluZyBmb3IgbW9zdCBvZiB0aGUgZHJpdmVycy4KCj4gUmVm bGVjdHMgdGhlIGFiaWxpdHkgb2YgYSBDUlRDIHRvIHNlbmQgVkJMQU5LIGV2ZW50cy4uLi4KPiAK PiAKPiBUaGUgcHJvcG9zZWQgaGFuZGxpbmcgb2Ygbm9fdmJsYW5rIGZlZWxzIGEgbGl0dGxlIGRp cnR5LCBhbHRob3VnaAo+IG5vdGhpbmcgYmV0dGVyIGNvbWVzIHRvIG1pbmQuCj4gTmV2ZXJ0aGVs ZXNzIGNvZGUgc2VlbXMgcGVyZmVjdGx5IHJlYXNvbmFibGUsIHNvIGlmIGl0IHdlcmUgbWUgSSdk IG1lcmdlIGl0LgoKVGhlIGlkZWEgd2l0aCBzZXR0aW5nIGl0IHZlcnkgZWFybHkgaXMgdGhhdCBk cml2ZXJzIGNhbiBvdmVyd3JpdGUgaXQgdmVyeQplYXNpbHkuIEZlZWxzIHNsaWdodGx5IGRpcnR5 LCBzbyBJIGd1ZXNzIHdlIGNvdWxkIGFsc28gc2V0IGl0IHNvbWV3aGVyZSBpbgp0aGUgYXRvbWlj X2hlbHBlcl9jaGVjayBmdW5jdGlvbiAoc2ltaWxhciB0byBob3cgd2Ugc2V0IHRoZSB2YXJpb3Vz CmNydGMtPipfY2hhbmdlZCBmbGFncywgYnV0IHdlJ3JlIG5vdCBlbnRpcmVseSBjb25zaXN0ZW50 IG9uIHRoZXNlIGVpdGhlcikuCgpGb3IgdGhlIG92ZXJhbGwgdGhpbmcgd2hhdCBmZWVscyBpcmt5 IHRvIG1lIGlzIG1ha2luZyB0aGlzIG5vX3ZibGFuawpkZWZhdWx0IGxvZ2ljIChob3dldmVyIHdl IGVuZCB1cCBjb21wdXRpbmcgaXQgaW4gdGhlIGVuZCwgd2hldGhlciBsaWtlCnRoaXMgb3Igd2hh dCBJIHN1Z2dlc3RlZCkgc3BlY2lmaWMgdG8gc2ltcGxlIHBpcGUgaGVscGVycyBmZWVscyBraW5k YQp3cm9uZy4gU2ltcGxlIHBpcGUgdGVuZHMgdG8gaGF2ZSBhIGhpZ2hlciByYXRpbyBvZiBkcml2 ZXJzIGZvciBodyB3aXRob3V0CnZibGFuayBzdXBwb3J0LCBidXQgYnkgZmFyIG5vdCB0aGUgb25s eSBvbmVzLiBIYXZpbmcgdGhhdCBzcGVjaWFsIGNhc2UKZmVlbHMgY29uZnVzaW5nIHRvIG1lIChh bmQgbGlrZWx5IHdpbGwgdHJpcCB1cCBzb21lIHBlb3BsZSwgdmJsYW5rIGFuZApldmVudCBoYW5k bGluZyBpcyBhbHJlYWR5IGEgaHVnZSBzb3VyY2Ugb2YgY29uZnVzaW9uIGluIGRybSkuCgpPbmUg aWRlYSBiZWhpbmQgZHJtX2Rldl9oYXNfdmJsYW5rKCkgaXMgYWxzbyB0aGF0IHdlIGNvdWxkIGZv cm1hbGl6ZSBhIGJpdAphbGwgdGhhdCwgYXQgbGVhc3QgZm9yIHRoZSB1c3VhbCBjYXNlIC0geGVu IGFuZCBtYXliZSBvdGhlcnMgYmVpbmcgc29tZQpleGNlcHRpb25zIGFzIHVzdWFsIChoZW5jZSBk ZWZpbml0ZWx5IG5vdCBzb21ldGhpbmcgdGhlIGNvcmUgY29kZSBzaG91bGQKaGFuZGxlKS4KCkNo ZWVycywgRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF32C33CAF for ; Fri, 17 Jan 2020 00:00:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF074206E6 for ; Fri, 17 Jan 2020 00:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="jbhk43Hg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF074206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DD4A6E49C; Fri, 17 Jan 2020 00:00:03 +0000 (UTC) Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E3936E49C for ; Fri, 17 Jan 2020 00:00:01 +0000 (UTC) Received: by mail-pj1-x1041.google.com with SMTP id m13so2434871pjb.2 for ; Thu, 16 Jan 2020 16:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Gho4j8nrfzG7IIa/FHOMHSYrFD9fBFO6dW7IZ3T+oY4=; b=jbhk43HgBzxIo1ehyWHQ3muHVCKVicJMw4lGK9hDDoNneH25t7nrMv/E81aXUS90/s 3tvwCtF0XAuQrXjsOwIjUXKjNYyVv6RXJn8sJTbf2LmSn7P6svL8hVeQ5WF1FFtipGyl /2ioKaex4roC/Vnvketgbv7xEvV/AMxjAEG4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gho4j8nrfzG7IIa/FHOMHSYrFD9fBFO6dW7IZ3T+oY4=; b=JbkN3aPDHlPDzJKyrcZRrxk5D9tzO5lU/6AQe0cxKo40tKDVZwIRjeZOntucNXw1lg 0+IUskTN09wd79o7Sk2F3+xOuELWsZrmiZucHaRx6bjYqK217E2J0xYno5OjsPKR3FdE AmWmVWfp1C3+1RSI/WK51WEzmGZQsQ27xPrsKzjd9P/TDgFV+M3ElHF3btu8jdGoi2pE pcHmQ3EFklDGZ4sdO6PAib5kpUzR/Lrb6H1pN2i8V7P37mDqk24MWRcNMKAhxQYtA9da BI6Z3BNgozf9GqYC+8uHUZlKIPk6Ae+Z/yOnedDxLSwwPMAouInhmElNkdRRnJkJhTLb btXQ== X-Gm-Message-State: APjAAAWBeyRqwjFoYt7P4ZwpjAAANKl3OF81xQO5YkbwFR38Kym10yIw q56L7/6JyNgHYqPzInLP7C/2vw== X-Google-Smtp-Source: APXvYqxP2Z2WaBH4UioHB+9TA8u7yA9J5IQZGxDpGRFn2bAKhkdPT8u9RWRLkISvPb3UIhMzZ3zSGA== X-Received: by 2002:a17:902:8bc3:: with SMTP id r3mr28824480plo.220.1579219200714; Thu, 16 Jan 2020 16:00:00 -0800 (PST) Received: from dvetter-linux.ger.corp.intel.com ([138.44.248.126]) by smtp.gmail.com with ESMTPSA id d26sm25172656pgv.66.2020.01.16.15.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 16:00:00 -0800 (PST) Date: Fri, 17 Jan 2020 00:59:51 +0100 From: Daniel Vetter To: Emil Velikov Subject: Re: [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default Message-ID: <20200116235951.GD8400@dvetter-linux.ger.corp.intel.com> References: <20200115125226.13843-1-tzimmermann@suse.de> <20200115125226.13843-5-tzimmermann@suse.de> <20200116064107.GB8400@dvetter-linux.ger.corp.intel.com> <33fdd33f-ce8d-70d3-544e-fac727d2686b@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux dvetter-linux.ger.corp.intel.com 5.2.11-200.fc30.x86_64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , Thomas Zimmermann , oleksandr_andrushchenko@epam.com, Dave Airlie , Sean Paul , ML dri-devel , "open list:VIRTIO GPU DRIVER" , Hans de Goede , Gerd Hoffmann , xen-devel@lists.xenproject.org, Emil Velikov , Sam Ravnborg , david@lechnology.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 16, 2020 at 05:22:34PM +0000, Emil Velikov wrote: > Hi all, > > On Thu, 16 Jan 2020 at 07:37, Thomas Zimmermann wrote: > > > > diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c > > > index 7cf3cf936547..23d2f51fc1d4 100644 > > > --- a/drivers/gpu/drm/drm_atomic_state_helper.c > > > +++ b/drivers/gpu/drm/drm_atomic_state_helper.c > > > @@ -149,6 +149,11 @@ void __drm_atomic_helper_crtc_duplicate_state(struct drm_crtc *crtc, > > > /* Self refresh should be canceled when a new update is available */ > > > state->active = drm_atomic_crtc_effectively_active(state); > > > state->self_refresh_active = false; > > > + > > > + if (drm_dev_has_vblank(crtc->dev)) > > > + state->no_vblank = true; > > > + else > > > + state->no_vblank = false; > > > } > > > EXPORT_SYMBOL(__drm_atomic_helper_crtc_duplicate_state); > > > > I think the if/else branches are in the wrong order. Yeah fumbled that. > > But generally speaking, is it really that easy? The xen driver already > > has to work around simple-kms's auto-enabling of no_vblank (see patch > > 4). Maybe this settings interferes with other drivers as well. At least > > the calls for sending fake vblanks should be removed from all affected > > drivers. Hm xen is really special, in that it has a flip complete event, but not a vblank. I think forcing drivers to overwrite stuff in that case makes sense. > I'm not sure if setting no_vblank based on dev->num_crtcs is the correct thing. > From the original commit and associated description for no_vblank: > > In some cases CRTCs are active but are not able to generating events, at > least not at every frame at it's expected to. > This is typically the case when the CRTC is feeding a writeback connector... Yeah, but Thomas' series here wants to extend that. And I think if we roll this out the common case will be "no hw vblank", and the writeback special case is going to be the exception to the exception. Yup, patch 1 that updates the docs doesn't reflect that, which is why I'm bringing up more suggestions here around code & semantics of all these pieces to make them do the most reasonable thing for most of the drivers. > Reflects the ability of a CRTC to send VBLANK events.... > > > The proposed handling of no_vblank feels a little dirty, although > nothing better comes to mind. > Nevertheless code seems perfectly reasonable, so if it were me I'd merge it. The idea with setting it very early is that drivers can overwrite it very easily. Feels slightly dirty, so I guess we could also set it somewhere in the atomic_helper_check function (similar to how we set the various crtc->*_changed flags, but we're not entirely consistent on these either). For the overall thing what feels irky to me is making this no_vblank default logic (however we end up computing it in the end, whether like this or what I suggested) specific to simple pipe helpers feels kinda wrong. Simple pipe tends to have a higher ratio of drivers for hw without vblank support, but by far not the only ones. Having that special case feels confusing to me (and likely will trip up some people, vblank and event handling is already a huge source of confusion in drm). One idea behind drm_dev_has_vblank() is also that we could formalize a bit all that, at least for the usual case - xen and maybe others being some exceptions as usual (hence definitely not something the core code should handle). Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B8EC33CB3 for ; Fri, 17 Jan 2020 00:00:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A98B4207E0 for ; Fri, 17 Jan 2020 00:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="jbhk43Hg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A98B4207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1isF3T-0000V3-Io; Fri, 17 Jan 2020 00:00:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1isF3S-0000H8-AW for xen-devel@lists.xenproject.org; Fri, 17 Jan 2020 00:00:02 +0000 X-Inumbo-ID: 4e9e7378-38bc-11ea-a985-bc764e2007e4 Received: from mail-pj1-x1044.google.com (unknown [2607:f8b0:4864:20::1044]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4e9e7378-38bc-11ea-a985-bc764e2007e4; Fri, 17 Jan 2020 00:00:01 +0000 (UTC) Received: by mail-pj1-x1044.google.com with SMTP id n96so2327377pjc.3 for ; Thu, 16 Jan 2020 16:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Gho4j8nrfzG7IIa/FHOMHSYrFD9fBFO6dW7IZ3T+oY4=; b=jbhk43HgBzxIo1ehyWHQ3muHVCKVicJMw4lGK9hDDoNneH25t7nrMv/E81aXUS90/s 3tvwCtF0XAuQrXjsOwIjUXKjNYyVv6RXJn8sJTbf2LmSn7P6svL8hVeQ5WF1FFtipGyl /2ioKaex4roC/Vnvketgbv7xEvV/AMxjAEG4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gho4j8nrfzG7IIa/FHOMHSYrFD9fBFO6dW7IZ3T+oY4=; b=MlsjE8ptDbj5FrYmbKWawDcCuv39pSAElpNDWP9fj3XBVcBrIshMeMFk3vKqZDf1b8 peAA83C8CsfLT09FlpnfxRnPXeC69rUfTglCgAKXmG6DROz9oa2bpgIokoaXlWeD4gju qI/r5Y7G/6PBQ13wwvpCFhBxTGqduwWvZAgRhLP+qDMwCerqAIg/R2a/ieWx7Qr7eKH2 j4jv7MXCLR19RTBWQs0HhcmUqmi1losMD4gZOENR/E1XapczCbDzM1fvwBMQ2d3p4Xse Irj1sqKXhQLbRJWfw5m6o7/09boN/uPEe+AtS99RTv0y6CrD5dT5I269or0SLcf1vii1 TNnQ== X-Gm-Message-State: APjAAAVDWzPbHdEf4SzGkedst+odccfbyQ8Kt5TOl9FGUDpsSvEMRO4l xzaFeCqVFQvejPPMYxW2Hpvp0w== X-Google-Smtp-Source: APXvYqxP2Z2WaBH4UioHB+9TA8u7yA9J5IQZGxDpGRFn2bAKhkdPT8u9RWRLkISvPb3UIhMzZ3zSGA== X-Received: by 2002:a17:902:8bc3:: with SMTP id r3mr28824480plo.220.1579219200714; Thu, 16 Jan 2020 16:00:00 -0800 (PST) Received: from dvetter-linux.ger.corp.intel.com ([138.44.248.126]) by smtp.gmail.com with ESMTPSA id d26sm25172656pgv.66.2020.01.16.15.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 16:00:00 -0800 (PST) Date: Fri, 17 Jan 2020 00:59:51 +0100 From: Daniel Vetter To: Emil Velikov Message-ID: <20200116235951.GD8400@dvetter-linux.ger.corp.intel.com> References: <20200115125226.13843-1-tzimmermann@suse.de> <20200115125226.13843-5-tzimmermann@suse.de> <20200116064107.GB8400@dvetter-linux.ger.corp.intel.com> <33fdd33f-ce8d-70d3-544e-fac727d2686b@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux dvetter-linux.ger.corp.intel.com 5.2.11-200.fc30.x86_64 Subject: Re: [Xen-devel] [PATCH v2 4/4] drm/simple-kms: Let DRM core send VBLANK events by default X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , Thomas Zimmermann , oleksandr_andrushchenko@epam.com, Dave Airlie , Sean Paul , ML dri-devel , "open list:VIRTIO GPU DRIVER" , Hans de Goede , Gerd Hoffmann , Daniel Vetter , xen-devel@lists.xenproject.org, Emil Velikov , Sam Ravnborg , david@lechnology.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gVGh1LCBKYW4gMTYsIDIwMjAgYXQgMDU6MjI6MzRQTSArMDAwMCwgRW1pbCBWZWxpa292IHdy b3RlOgo+IEhpIGFsbCwKPiAKPiBPbiBUaHUsIDE2IEphbiAyMDIwIGF0IDA3OjM3LCBUaG9tYXMg WmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4gd3JvdGU6Cj4gCj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19zdGF0ZV9oZWxwZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jCj4gPiA+IGluZGV4IDdjZjNjZjkzNjU0 Ny4uMjNkMmY1MWZjMWQ0IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pY19zdGF0ZV9oZWxwZXIuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21p Y19zdGF0ZV9oZWxwZXIuYwo+ID4gPiBAQCAtMTQ5LDYgKzE0OSwxMSBAQCB2b2lkIF9fZHJtX2F0 b21pY19oZWxwZXJfY3J0Y19kdXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ ID4gPiAgICAgICAvKiBTZWxmIHJlZnJlc2ggc2hvdWxkIGJlIGNhbmNlbGVkIHdoZW4gYSBuZXcg dXBkYXRlIGlzIGF2YWlsYWJsZSAqLwo+ID4gPiAgICAgICBzdGF0ZS0+YWN0aXZlID0gZHJtX2F0 b21pY19jcnRjX2VmZmVjdGl2ZWx5X2FjdGl2ZShzdGF0ZSk7Cj4gPiA+ICAgICAgIHN0YXRlLT5z ZWxmX3JlZnJlc2hfYWN0aXZlID0gZmFsc2U7Cj4gPiA+ICsKPiA+ID4gKyAgICAgaWYgKGRybV9k ZXZfaGFzX3ZibGFuayhjcnRjLT5kZXYpKQo+ID4gPiArICAgICAgICAgICAgIHN0YXRlLT5ub192 YmxhbmsgPSB0cnVlOwo+ID4gPiArICAgICBlbHNlCj4gPiA+ICsgICAgICAgICAgICAgc3RhdGUt Pm5vX3ZibGFuayA9IGZhbHNlOwo+ID4gPiAgfQo+ID4gPiAgRVhQT1JUX1NZTUJPTChfX2RybV9h dG9taWNfaGVscGVyX2NydGNfZHVwbGljYXRlX3N0YXRlKTsKPiA+Cj4gPiBJIHRoaW5rIHRoZSBp Zi9lbHNlIGJyYW5jaGVzIGFyZSBpbiB0aGUgd3Jvbmcgb3JkZXIuCgpZZWFoIGZ1bWJsZWQgdGhh dC4KCj4gPiBCdXQgZ2VuZXJhbGx5IHNwZWFraW5nLCBpcyBpdCByZWFsbHkgdGhhdCBlYXN5PyBU aGUgeGVuIGRyaXZlciBhbHJlYWR5Cj4gPiBoYXMgdG8gd29yayBhcm91bmQgc2ltcGxlLWttcydz IGF1dG8tZW5hYmxpbmcgb2Ygbm9fdmJsYW5rIChzZWUgcGF0Y2gKPiA+IDQpLiBNYXliZSB0aGlz IHNldHRpbmdzIGludGVyZmVyZXMgd2l0aCBvdGhlciBkcml2ZXJzIGFzIHdlbGwuIEF0IGxlYXN0 Cj4gPiB0aGUgY2FsbHMgZm9yIHNlbmRpbmcgZmFrZSB2YmxhbmtzIHNob3VsZCBiZSByZW1vdmVk IGZyb20gYWxsIGFmZmVjdGVkCj4gPiBkcml2ZXJzLgoKSG0geGVuIGlzIHJlYWxseSBzcGVjaWFs LCBpbiB0aGF0IGl0IGhhcyBhIGZsaXAgY29tcGxldGUgZXZlbnQsIGJ1dCBub3QgYQp2Ymxhbmsu IEkgdGhpbmsgZm9yY2luZyBkcml2ZXJzIHRvIG92ZXJ3cml0ZSBzdHVmZiBpbiB0aGF0IGNhc2Ug bWFrZXMKc2Vuc2UuCgo+IEknbSBub3Qgc3VyZSBpZiBzZXR0aW5nIG5vX3ZibGFuayBiYXNlZCBv biBkZXYtPm51bV9jcnRjcyBpcyB0aGUgY29ycmVjdCB0aGluZy4KPiBGcm9tIHRoZSBvcmlnaW5h bCBjb21taXQgYW5kIGFzc29jaWF0ZWQgZGVzY3JpcHRpb24gZm9yIG5vX3ZibGFuazoKPiAKPiBJ biBzb21lIGNhc2VzIENSVENzIGFyZSBhY3RpdmUgYnV0IGFyZSBub3QgYWJsZSB0byBnZW5lcmF0 aW5nIGV2ZW50cywgYXQKPiBsZWFzdCBub3QgYXQgZXZlcnkgZnJhbWUgYXQgaXQncyBleHBlY3Rl ZCB0by4KPiBUaGlzIGlzIHR5cGljYWxseSB0aGUgY2FzZSB3aGVuIHRoZSBDUlRDIGlzIGZlZWRp bmcgYSB3cml0ZWJhY2sgY29ubmVjdG9yLi4uCgpZZWFoLCBidXQgVGhvbWFzJyBzZXJpZXMgaGVy ZSB3YW50cyB0byBleHRlbmQgdGhhdC4gQW5kIEkgdGhpbmsgaWYgd2Ugcm9sbAp0aGlzIG91dCB0 aGUgY29tbW9uIGNhc2Ugd2lsbCBiZSAibm8gaHcgdmJsYW5rIiwgYW5kIHRoZSB3cml0ZWJhY2sg c3BlY2lhbApjYXNlIGlzIGdvaW5nIHRvIGJlIHRoZSBleGNlcHRpb24gdG8gdGhlIGV4Y2VwdGlv bi4gWXVwLCBwYXRjaCAxIHRoYXQKdXBkYXRlcyB0aGUgZG9jcyBkb2Vzbid0IHJlZmxlY3QgdGhh dCwgd2hpY2ggaXMgd2h5IEknbSBicmluZ2luZyB1cCBtb3JlCnN1Z2dlc3Rpb25zIGhlcmUgYXJv dW5kIGNvZGUgJiBzZW1hbnRpY3Mgb2YgYWxsIHRoZXNlIHBpZWNlcyB0byBtYWtlIHRoZW0KZG8g dGhlIG1vc3QgcmVhc29uYWJsZSB0aGluZyBmb3IgbW9zdCBvZiB0aGUgZHJpdmVycy4KCj4gUmVm bGVjdHMgdGhlIGFiaWxpdHkgb2YgYSBDUlRDIHRvIHNlbmQgVkJMQU5LIGV2ZW50cy4uLi4KPiAK PiAKPiBUaGUgcHJvcG9zZWQgaGFuZGxpbmcgb2Ygbm9fdmJsYW5rIGZlZWxzIGEgbGl0dGxlIGRp cnR5LCBhbHRob3VnaAo+IG5vdGhpbmcgYmV0dGVyIGNvbWVzIHRvIG1pbmQuCj4gTmV2ZXJ0aGVs ZXNzIGNvZGUgc2VlbXMgcGVyZmVjdGx5IHJlYXNvbmFibGUsIHNvIGlmIGl0IHdlcmUgbWUgSSdk IG1lcmdlIGl0LgoKVGhlIGlkZWEgd2l0aCBzZXR0aW5nIGl0IHZlcnkgZWFybHkgaXMgdGhhdCBk cml2ZXJzIGNhbiBvdmVyd3JpdGUgaXQgdmVyeQplYXNpbHkuIEZlZWxzIHNsaWdodGx5IGRpcnR5 LCBzbyBJIGd1ZXNzIHdlIGNvdWxkIGFsc28gc2V0IGl0IHNvbWV3aGVyZSBpbgp0aGUgYXRvbWlj X2hlbHBlcl9jaGVjayBmdW5jdGlvbiAoc2ltaWxhciB0byBob3cgd2Ugc2V0IHRoZSB2YXJpb3Vz CmNydGMtPipfY2hhbmdlZCBmbGFncywgYnV0IHdlJ3JlIG5vdCBlbnRpcmVseSBjb25zaXN0ZW50 IG9uIHRoZXNlIGVpdGhlcikuCgpGb3IgdGhlIG92ZXJhbGwgdGhpbmcgd2hhdCBmZWVscyBpcmt5 IHRvIG1lIGlzIG1ha2luZyB0aGlzIG5vX3ZibGFuawpkZWZhdWx0IGxvZ2ljIChob3dldmVyIHdl IGVuZCB1cCBjb21wdXRpbmcgaXQgaW4gdGhlIGVuZCwgd2hldGhlciBsaWtlCnRoaXMgb3Igd2hh dCBJIHN1Z2dlc3RlZCkgc3BlY2lmaWMgdG8gc2ltcGxlIHBpcGUgaGVscGVycyBmZWVscyBraW5k YQp3cm9uZy4gU2ltcGxlIHBpcGUgdGVuZHMgdG8gaGF2ZSBhIGhpZ2hlciByYXRpbyBvZiBkcml2 ZXJzIGZvciBodyB3aXRob3V0CnZibGFuayBzdXBwb3J0LCBidXQgYnkgZmFyIG5vdCB0aGUgb25s eSBvbmVzLiBIYXZpbmcgdGhhdCBzcGVjaWFsIGNhc2UKZmVlbHMgY29uZnVzaW5nIHRvIG1lIChh bmQgbGlrZWx5IHdpbGwgdHJpcCB1cCBzb21lIHBlb3BsZSwgdmJsYW5rIGFuZApldmVudCBoYW5k bGluZyBpcyBhbHJlYWR5IGEgaHVnZSBzb3VyY2Ugb2YgY29uZnVzaW9uIGluIGRybSkuCgpPbmUg aWRlYSBiZWhpbmQgZHJtX2Rldl9oYXNfdmJsYW5rKCkgaXMgYWxzbyB0aGF0IHdlIGNvdWxkIGZv cm1hbGl6ZSBhIGJpdAphbGwgdGhhdCwgYXQgbGVhc3QgZm9yIHRoZSB1c3VhbCBjYXNlIC0geGVu IGFuZCBtYXliZSBvdGhlcnMgYmVpbmcgc29tZQpleGNlcHRpb25zIGFzIHVzdWFsIChoZW5jZSBk ZWZpbml0ZWx5IG5vdCBzb21ldGhpbmcgdGhlIGNvcmUgY29kZSBzaG91bGQKaGFuZGxlKS4KCkNo ZWVycywgRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA==