From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 247F6C35240 for ; Fri, 24 Jan 2020 00:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E831D206D4 for ; Fri, 24 Jan 2020 00:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729654AbgAXAtj (ORCPT ); Thu, 23 Jan 2020 19:49:39 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:34194 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729425AbgAXAtj (ORCPT ); Thu, 23 Jan 2020 19:49:39 -0500 Received: from dread.disaster.area (pa49-195-162-125.pa.nsw.optusnet.com.au [49.195.162.125]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 46DDF3A4471; Fri, 24 Jan 2020 11:49:37 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1iunAG-0008Or-PE; Fri, 24 Jan 2020 11:49:36 +1100 Date: Fri, 24 Jan 2020 11:49:36 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 02/12] xfs: make xfs_buf_read return an error code Message-ID: <20200124004936.GC7090@dread.disaster.area> References: <157976531016.2388944.3654360225810285604.stgit@magnolia> <157976532333.2388944.17938500318924937596.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157976532333.2388944.17938500318924937596.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=eqEhQ2W7mF93FbYHClaXRw==:117 a=eqEhQ2W7mF93FbYHClaXRw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Jdjhy38mL1oA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=A_EQMfEfxFmmGZRKqFsA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jan 22, 2020 at 11:42:03PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Convert xfs_buf_read() to return numeric error codes like most > everywhere else in xfs. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_attr_remote.c | 8 ++++---- > fs/xfs/xfs_buf.h | 13 +++++++++++-- > fs/xfs/xfs_log_recover.c | 16 +++++++--------- > fs/xfs/xfs_symlink.c | 8 ++++---- > 4 files changed, 26 insertions(+), 19 deletions(-) Looks fine. All of the callers have exactly the same error handling, so this makes sense to pull that up into xfs_buf_read() as a first step. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com