From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF194C35240 for ; Fri, 24 Jan 2020 02:07:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 989F821D7E for ; Fri, 24 Jan 2020 02:07:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730158AbgAXCHa (ORCPT ); Thu, 23 Jan 2020 21:07:30 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:43459 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729340AbgAXCHa (ORCPT ); Thu, 23 Jan 2020 21:07:30 -0500 Received: from dread.disaster.area (pa49-195-162-125.pa.nsw.optusnet.com.au [49.195.162.125]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id CBEBE3A32CD; Fri, 24 Jan 2020 13:07:28 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1iuoNb-0000Wu-RG; Fri, 24 Jan 2020 13:07:27 +1100 Date: Fri, 24 Jan 2020 13:07:27 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 12/12] xfs: fix xfs_buf_ioerror_alert location reporting Message-ID: <20200124020727.GM7090@dread.disaster.area> References: <157976531016.2388944.3654360225810285604.stgit@magnolia> <157976538741.2388944.8089997383572416484.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157976538741.2388944.8089997383572416484.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=W5xGqiek c=1 sm=1 tr=0 a=eqEhQ2W7mF93FbYHClaXRw==:117 a=eqEhQ2W7mF93FbYHClaXRw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Jdjhy38mL1oA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=wMuAIHmlbTaK4TqVxD4A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jan 22, 2020 at 11:43:07PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Instead of passing __func__ to the error reporting function, let's use > the return address builtins so that the messages actually tell you which > higher level function called the buffer functions. This was previously > true for the xfs_buf_read callers, but not for the xfs_trans_read_buf > callers. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_buf.c | 12 +++++++----- > fs/xfs/xfs_buf.h | 7 ++++--- > fs/xfs/xfs_buf_item.c | 2 +- > fs/xfs/xfs_log_recover.c | 4 ++-- > fs/xfs/xfs_trans_buf.c | 5 +++-- > 5 files changed, 17 insertions(+), 13 deletions(-) Makes sense, but I have a concern that this series now has added two new parameters to the buffer read functions. Perhaps we should consider wrapping this all up in an args structure? That's a separate piece of work, not for this patchset. So far this patch, Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com