From: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
To: u-boot@lists.denx.de
Subject: [PATCH] board: tbs2910: Add support for generic distro configuration
Date: Tue, 28 Jan 2020 22:12:07 +0100 [thread overview]
Message-ID: <20200128221153.003abb14@primarylaptop.localdomain> (raw)
In-Reply-To: <ffa537bd-c738-9329-e89a-f611480e74c2@web.de>
On Sun, 26 Jan 2020 01:40:13 +0100
Soeren Moch <smoch@web.de> wrote:
> >> Why do you define CONFIG_BOOTCOMMAND here instead of modifying the
> >> existing one?
> > I'm a bit confused with it: There seem to be many way to do the same
> > thing and I'm not sure which one is the best.
> >
> > Because of that, I just kept it in the code as it was (instead of
> > moving it to tbs2910_defconfig).
> This is ok. What I mean: You moved it in the file, and therefore you
> unnecessarily changed a lot of lines without actually changing most of
> it's contents.
If CONFIG_BOOTCOMMAND is not defined before, it will be defined in
config_distro_bootcmd.h
This means that the order in which defines and #include
<config_distro_bootcmd.h> is done matters.
Which lead me to do the inclusion of config_distro_bootcmd.h as early
as possible in the tbs2910.h.
This way if there are some unintended redefinition due to things having
changed in config_distro_bootcmd.h in the future, the compiler will at
warn or error about it.
Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200128/78b15063/attachment.sig>
prev parent reply other threads:[~2020-01-28 21:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 1:42 [PATCH] board: tbs2910: Add support for generic distro configuration Denis 'GNUtoo' Carikli
2020-01-25 16:24 ` Tom Rini
2020-01-25 19:56 ` Soeren Moch
2020-01-25 20:33 ` Tom Rini
2020-01-25 19:52 ` Soeren Moch
2020-01-25 23:15 ` Denis 'GNUtoo' Carikli
2020-01-26 0:40 ` Soeren Moch
2020-01-28 17:02 ` Denis 'GNUtoo' Carikli
2020-01-28 17:23 ` Soeren Moch
2020-01-28 17:04 ` [PATCH v2][ 1/3] tbs2910: disable fuse command Denis 'GNUtoo' Carikli
2020-01-28 17:04 ` [PATCH v2][ 2/3] tbs2910: disable loadb and loads commands Denis 'GNUtoo' Carikli
2020-01-28 17:37 ` Soeren Moch
2020-01-28 17:04 ` [PATCH v2][ 3/3] board: tbs2910: Add support for generic distro configuration Denis 'GNUtoo' Carikli
2020-01-28 17:51 ` Soeren Moch
2020-01-28 21:16 ` Denis 'GNUtoo' Carikli
2020-01-28 21:27 ` Denis 'GNUtoo' Carikli
2020-01-29 23:48 ` Soeren Moch
2020-01-30 22:14 ` Soeren Moch
2020-01-28 17:07 ` [PATCH v2][ 1/3] tbs2910: disable fuse command Fabio Estevam
[not found] ` <7efe72d0-27e3-99d1-00c6-82dafdc3b345@videantis.de>
2020-01-28 17:16 ` Soeren Moch
2020-01-28 17:30 ` Sören Moch
2020-01-28 21:12 ` Denis 'GNUtoo' Carikli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128221153.003abb14@primarylaptop.localdomain \
--to=gnutoo@cyberdimension.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.