From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E37C2BA83 for ; Wed, 12 Feb 2020 11:58:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D06F42073C for ; Wed, 12 Feb 2020 11:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Npfa2wf8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D06F42073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1qf1-0006yB-2u for qemu-devel@archiver.kernel.org; Wed, 12 Feb 2020 06:58:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50869) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1qeK-0006ZZ-LT for qemu-devel@nongnu.org; Wed, 12 Feb 2020 06:57:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1qeJ-0001sp-0C for qemu-devel@nongnu.org; Wed, 12 Feb 2020 06:57:48 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:38980) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1qeI-0001qD-PE for qemu-devel@nongnu.org; Wed, 12 Feb 2020 06:57:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581508665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=btWYDtI+6EosQ1MU3I1LXB/ONeVfPffX7dHe3R52T8w=; b=Npfa2wf8r+TC8SWeZxD5c44d/ax36MvSHmHmqcjJx6sQPelukaNOa6AG4SSvB/5Ra2Lv6C Z3hA6bruIQHiJJ8XE52i9GpD6n+HNLlzqoZkUqHDppHcKo9CQZb1OOoow3ttzbxJ0VHX3a xlBNNjOAUjZ7r4dn6D2rj669bJftjnA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-MkVIj0JlO4yD41H9O5mlgQ-1; Wed, 12 Feb 2020 06:57:40 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C870213EA; Wed, 12 Feb 2020 11:57:39 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-39.ams2.redhat.com [10.36.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 860091001B05; Wed, 12 Feb 2020 11:57:34 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BFC989D6B; Wed, 12 Feb 2020 12:57:33 +0100 (CET) Date: Wed, 12 Feb 2020 12:57:33 +0100 From: Gerd Hoffmann To: Joshua Watt Subject: Re: [PATCH v3 5/7] ui/gtk: implement show-cursor option Message-ID: <20200212115733.eha47pyo4wos6fql@sirius.home.kraxel.org> References: <20200207101753.25812-1-kraxel@redhat.com> <20200207101753.25812-6-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: MkVIj0JlO4yD41H9O5mlgQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , jtomko@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > > + if (s->opts->has_show_cursor && s->opts->show_cursor) { > > + s->null_cursor =3D NULL; /* default pointer */ > > + } else { > > + s->null_cursor =3D gdk_cursor_new_for_display(window_display, > > + GDK_BLANK_CURSOR); > > + } >=20 > I think it would make more sense to have all the logic related to what > cursor is used in the same location, instead of split up between here and > gd_update_cursor(). Note that it isn't that simple. There are a few more places in gd_grab_*() which use s->null_cursor and would need adaption. cheers, Gerd