From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Dave Airlie <airlied@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Ben Skeggs <bskeggs@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
Luis
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [RESEND PATCH v2 5/9] arc: Constify ioreadX() iomem argument (as in generic implementation)
Date: Wed, 19 Feb 2020 18:50:03 +0100 [thread overview]
Message-ID: <20200219175007.13627-6-krzk__1508.79149311862$1582134735$gmane$org@kernel.org> (raw)
In-Reply-To: <20200219175007.13627-1-krzk@kernel.org>
The ioreadX() helpers have inconsistent interface. On some architectures
void *__iomem address argument is a pointer to const, on some not.
Implementations of ioreadX() do not modify the memory under the
address so they can be converted to a "const" version for const-safety
and consistency among architectures.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
---
Changes since v1:
1. Add Alexey's ack.
---
arch/arc/plat-axs10x/axs10x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
index 63ea5a606ecd..180c260a8221 100644
--- a/arch/arc/plat-axs10x/axs10x.c
+++ b/arch/arc/plat-axs10x/axs10x.c
@@ -84,7 +84,7 @@ static void __init axs10x_print_board_ver(unsigned int creg, const char *str)
unsigned int val;
} board;
- board.val = ioread32((void __iomem *)creg);
+ board.val = ioread32((const void __iomem *)creg);
pr_info("AXS: %s FPGA Date: %u-%u-%u\n", str, board.d, board.m,
board.y);
}
@@ -95,7 +95,7 @@ static void __init axs10x_early_init(void)
char mb[32];
/* Determine motherboard version */
- if (ioread32((void __iomem *) CREG_MB_CONFIG) & (1 << 28))
+ if (ioread32((const void __iomem *) CREG_MB_CONFIG) & (1 << 28))
mb_rev = 3; /* HT-3 (rev3.0) */
else
mb_rev = 2; /* HT-2 (rev2.0) */
--
2.17.1
next prev parent reply other threads:[~2020-02-19 17:51 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:49 [RESEND PATCH v2 0/9] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` [RESEND PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
[not found] ` <20200219175007.13627-2-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 2/9] rtl818x: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski [this message]
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-03-12 10:49 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementati Thomas Zimmermann
2020-03-12 10:49 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-14 10:59 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementati Krzysztof Kozlowski
2020-03-14 10:59 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-24 8:39 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementati Thomas Zimmermann
2020-03-24 8:39 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
[not found] ` <20200219175007.13627-7-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-02-19 17:50 ` [RESEND PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementatio Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-03-12 8:01 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implement Hans Verkuil
2020-03-12 8:01 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementation) Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
[not found] ` <20200219175007.13627-9-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-03-12 8:01 ` Hans Verkuil
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 9/9] ath5k: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-20 9:48 ` Jiri Slaby
[not found] ` <20200219175007.13627-10-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-02-20 9:48 ` Jiri Slaby
2020-02-19 17:50 ` Krzysztof Kozlowski
[not found] ` <20200219175007.13627-1-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-02-19 17:49 ` [RESEND PATCH v2 1/9] iomap: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 2/9] rtl818x: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 9/9] ath5k: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20200219175007.13627-6-krzk__1508.79149311862$1582134735$gmane$org@kernel.org' \
--to=krzk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bskeggs@redhat.com \
--cc=dalias@libc.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=ink@jurassic.park.msu.ru \
--cc=jirislaby@gmail.com \
--cc=mattst88@gmail.com \
--cc=mchehab@kernel.org \
--cc=mickflemm@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=vgupta@synopsys.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.