Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on tip/perf/core] [also build test ERROR on linus/master v5.6-rc2] [cannot apply to tip/x86/core rcu/dev next-20200221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Peter-Zijlstra/tracing-vs-world/20200223-012357 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git fdb64822443ec9fb8c3a74b598a74790ae8d2e22 config: x86_64-randconfig-s2-20200223 (attached as .config) compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from arch/x86/include/asm/math_emu.h:5:0, from arch/x86/include/asm/processor.h:13, from arch/x86/include/asm/cpufeature.h:5, from arch/x86/include/asm/thread_info.h:53, from include/linux/thread_info.h:38, from arch/x86/include/asm/preempt.h:7, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/stat.h:19, from include/linux/module.h:13, from arch/x86/kernel/alternative.c:4: arch/x86/kernel/alternative.c: In function 'poke_int3_handler': arch/x86/include/asm/ptrace.h:126:28: error: inlining failed in call to always_inline 'user_mode.isra.1': function attribute mismatch static __always_inline int user_mode(struct pt_regs *regs) ^ arch/x86/kernel/alternative.c:1000:6: error: called from here if (user_mode(regs)) ^ >> arch/x86/kernel/alternative.c:961:26: error: inlining failed in call to always_inline 'try_get_desc.constprop': function attribute mismatch struct bp_patching_desc *try_get_desc(struct bp_patching_desc **descp) ^ arch/x86/kernel/alternative.c:1013:7: error: called from here desc = try_get_desc(&bp_desc); ^ In file included from arch/x86/kernel/alternative.c:17:0: include/linux/bsearch.h:8:7: error: inlining failed in call to always_inline '__bsearch.constprop': function attribute mismatch void *__bsearch(const void *key, const void *base, size_t num, size_t size, cmp_func_t cmp) ^ arch/x86/kernel/alternative.c:1026:6: error: called from here tp = __bsearch(ip, desc->vec, desc->nr_entries, ^ arch/x86/kernel/alternative.c:977:30: error: inlining failed in call to always_inline 'text_poke_addr.isra.6': function attribute mismatch static __always_inline void *text_poke_addr(struct text_poke_loc *tp) ^ arch/x86/kernel/alternative.c:1033:7: error: called from here if (text_poke_addr(tp) != ip) ^ In file included from arch/x86/include/asm/kprobes.h:18:0, from include/linux/kprobes.h:30, from arch/x86/kernel/alternative.c:15: arch/x86/include/asm/text-patching.h:67:28: error: inlining failed in call to always_inline 'text_opcode_size': function attribute mismatch static __always_inline int text_opcode_size(u8 opcode) ^ arch/x86/kernel/alternative.c:1037:6: error: called from here len = text_opcode_size(tp->opcode); ^ In file included from arch/x86/include/asm/kprobes.h:18:0, from include/linux/kprobes.h:30, from arch/x86/kernel/alternative.c:15: arch/x86/include/asm/text-patching.h:144:6: error: inlining failed in call to always_inline 'int3_emulate_call': function attribute mismatch void int3_emulate_call(struct pt_regs *regs, unsigned long func) ^ arch/x86/kernel/alternative.c:1049:3: error: called from here int3_emulate_call(regs, (long)ip + tp->rel32); ^ In file included from arch/x86/include/asm/kprobes.h:18:0, from include/linux/kprobes.h:30, from arch/x86/kernel/alternative.c:15: arch/x86/include/asm/text-patching.h:122:6: error: inlining failed in call to always_inline 'int3_emulate_jmp.isra.4': function attribute mismatch void int3_emulate_jmp(struct pt_regs *regs, unsigned long ip) ^ arch/x86/kernel/alternative.c:1054:3: error: called from here int3_emulate_jmp(regs, (long)ip + tp->rel32); ^ arch/x86/kernel/alternative.c:971:29: error: inlining failed in call to always_inline 'put_desc': function attribute mismatch static __always_inline void put_desc(struct bp_patching_desc *desc) ^ arch/x86/kernel/alternative.c:1064:2: error: called from here put_desc(desc); ^ vim +961 arch/x86/kernel/alternative.c 1f676247f36a4b Peter Zijlstra 2019-12-11 959 fd85274efb2876 Thomas Gleixner 2020-02-21 960 static __always_inline fd85274efb2876 Thomas Gleixner 2020-02-21 @961 struct bp_patching_desc *try_get_desc(struct bp_patching_desc **descp) 1f676247f36a4b Peter Zijlstra 2019-12-11 962 { 2a78c27ec07053 Peter Zijlstra 2020-02-21 963 struct bp_patching_desc *desc = READ_ONCE_NOCHECK(*descp); /* rcu_dereference */ 1f676247f36a4b Peter Zijlstra 2019-12-11 964 2a78c27ec07053 Peter Zijlstra 2020-02-21 965 if (!desc || !arch_atomic_inc_not_zero(&desc->refs)) 1f676247f36a4b Peter Zijlstra 2019-12-11 966 return NULL; 1f676247f36a4b Peter Zijlstra 2019-12-11 967 1f676247f36a4b Peter Zijlstra 2019-12-11 968 return desc; 1f676247f36a4b Peter Zijlstra 2019-12-11 969 } 1f676247f36a4b Peter Zijlstra 2019-12-11 970 :::::: The code at line 961 was first introduced by commit :::::: fd85274efb2876ccb2c8f8c5a413910ac0edc08d x86/int3: Ensure that poke_int3_handler() is not traced :::::: TO: Thomas Gleixner :::::: CC: 0day robot --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org