From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/2] Fix file listing logic for top-level parallel build
Date: Wed, 26 Feb 2020 20:43:42 +0100 [thread overview]
Message-ID: <20200226194345.1087529-1-thomas.petazzoni@bootlin.com> (raw)
Hello,
The current logic in pkg-generic.mk that calculates the list of files
installed by packages is not compatible with top-level parallel
build. Indeed, when package N-1 has been finished installing, we keep
a file that is then used after package N is installed to calculate
which files were installed by package N. This is inherently broken for
top-level parallel build, and we have seen build failures caused by
this in top-level parallel build mode.
For example:
http://autobuild.buildroot.net/results/4e6/4e60fa31b1cd08bc7fdf9c5dd3a3f4941e029ba3/build-end.log
shows:
>>> capnproto 0.7.0 Installing to staging directory
comm: /home/giuliobenetti/autobuild/run/instance-0/output-1/build/.files-list-staging.new: No such file or directory
package/pkg-generic.mk:311: recipe for target '/home/giuliobenetti/autobuild/run/instance-0/output-1/build/c-ares-1.15.0/.stamp_staging_installed' failed
which is an example of that: the .new file has been deleted in the
mean time by another package being built.
This paytch series fixes that by making the installed file calculation
a per-package logic, until target-finalize which will use the
per-package file lists and gather them in a single global file list.
Thanks!
Thomas
Thomas Petazzoni (2):
package/pkg-generic.mk: simplify step_pkg_size
package/pkg-generic: make file list logic parallel build compatible
Makefile | 15 ++++------
package/pkg-generic.mk | 65 +++++++++++++++++++-----------------------
2 files changed, 36 insertions(+), 44 deletions(-)
--
2.24.1
next reply other threads:[~2020-02-26 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 19:43 Thomas Petazzoni [this message]
2020-02-26 19:43 ` [Buildroot] [PATCH 1/2] package/pkg-generic.mk: simplify step_pkg_size Thomas Petazzoni
2020-02-27 21:51 ` Peter Korsgaard
2020-02-27 21:55 ` Thomas Petazzoni
2020-02-27 22:32 ` Peter Korsgaard
2020-02-26 19:43 ` [Buildroot] [PATCH 2/2] package/pkg-generic: make file list logic parallel build compatible Thomas Petazzoni
2020-02-27 22:04 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226194345.1087529-1-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.